Re: [PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:32写道: > > On Thu, Jan 16, 2025 at 03:26:05PM +0800, Jun Nie wrote: > > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > > enabled. > > Why? What is the issue that you are solving? To support high-resolution cases that exceed the width

Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 10:22:07PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 16:18写道: > > > > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > > > Support SSPP assignment for quad-pipe case with unified method. > > > The first 2 pipes can share a set of mixer config and enab

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 11:36:21PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 18:08写道: > > > > On Thu, Jan 16, 2025 at 05:49:43PM +0800, Jun Nie wrote: > > > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > > > Stor

Re: [PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 10:38:33PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 15:44写道: > > > > > On Thu, Jan 16, 2025 at 03:25:50PM +0800, Jun Nie wrote: > > > Move requreiment check to routine of every pipe check. As sblk > > > and pipe_hw_caps of r_pipe are not checked in current im

Re: [PATCH RFC 1/4] drm/msm/adreno: Add speedbin support for X1-85

2025-01-16 Thread Konrad Dybcio
On 15.01.2025 8:59 PM, Dmitry Baryshkov wrote: > On Thu, Jan 16, 2025 at 01:07:17AM +0530, Akhil P Oommen wrote: >> On 1/9/2025 7:27 PM, Konrad Dybcio wrote: >>> On 8.01.2025 11:42 PM, Akhil P Oommen wrote: Adreno X1-85 has an additional bit which is at a non-contiguous location in qfprom

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 18:08写道: > > On Thu, Jan 16, 2025 at 05:49:43PM +0800, Jun Nie wrote: > > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > > Store pipes in array with removing dedicated r_pipe. There are > > > > 2 pi

Re: [PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 15:44写道: > > On Thu, Jan 16, 2025 at 03:25:50PM +0800, Jun Nie wrote: > > Move requreiment check to routine of every pipe check. As sblk > > and pipe_hw_caps of r_pipe are not checked in current implementation. > How about this version? The capability stored in

Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:18写道: > > On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > > Support SSPP assignment for quad-pipe case with unified method. > > The first 2 pipes can share a set of mixer config and enable > > multi-rect mode if condition is met. It is also the case for

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Daniel Stone
On Thu, 16 Jan 2025 at 10:35, Dmitry Baryshkov wrote: > On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: > > On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen > > wrote: > > > On the platforms I have been using (omap, tidss, xilinx, rcar) the dumb > > > buffers are the only buffe

Re: [PATCH v4 13/16] drm/msm/dpu: support plane splitting in quad-pipe case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 06:20:48PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 16:14写道: > > > > On Thu, Jan 16, 2025 at 03:26:02PM +0800, Jun Nie wrote: > > > The content of every half of screen is sent out via one interface in > > > dual-DSI case. The content for every interface is ble

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen > wrote: > > On 16/01/2025 10:09, Thomas Zimmermann wrote: > > > Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: > > > [...] > > >> > > >> My point is that we have the current UAPI, a

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Tomi Valkeinen
Hi, On 16/01/2025 12:17, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we have the current UAPI, and we have userspace using it, but we don't

Re: [PATCH v4 13/16] drm/msm/dpu: support plane splitting in quad-pipe case

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:14写道: > > On Thu, Jan 16, 2025 at 03:26:02PM +0800, Jun Nie wrote: > > The content of every half of screen is sent out via one interface in > > dual-DSI case. The content for every interface is blended by a LM > > pair in quad-pipe case, thus a LM pair should not

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Geert Uytterhoeven
On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: > On 16/01/2025 10:09, Thomas Zimmermann wrote: > > Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: > > [...] > >> > >> My point is that we have the current UAPI, and we have userspace using > >> it, but we don't have clear rules what the ioctl d

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 05:49:43PM +0800, Jun Nie wrote: > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > Store pipes in array with removing dedicated r_pipe. There are > > > 2 pipes in a drm plane at most currently, while 4 pipes are

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Tomi Valkeinen
Hi, On 16/01/2025 11:38, Laurent Pinchart wrote: On Thu, Jan 16, 2025 at 10:43:40AM +0200, Laurent Pinchart wrote: On Wed, Jan 15, 2025 at 02:34:26PM +, Daniel Stone wrote: On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: No disagreement there, we need CREATE_DUMB2. My point is that w

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Tomi Valkeinen
Hi, On 16/01/2025 10:09, Thomas Zimmermann wrote: Hi Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we have the current UAPI, and we have userspace using it, but we don't have clear rules what the ioctl does with specific parameters, and we don't document how it has to

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Jun Nie
Jun Nie 于2025年1月16日周四 17:49写道: > > Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > > Store pipes in array with removing dedicated r_pipe. There are > > > 2 pipes in a drm plane at most currently, while 4 pipes are > > > required for qua

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Jun Nie
Dmitry Baryshkov 于2025年1月16日周四 16:00写道: > > On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > > Store pipes in array with removing dedicated r_pipe. There are > > 2 pipes in a drm plane at most currently, while 4 pipes are > > required for quad-pipe case. Generalize the handling to pipe p

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Laurent Pinchart
On Thu, Jan 16, 2025 at 10:43:40AM +0200, Laurent Pinchart wrote: > On Wed, Jan 15, 2025 at 02:34:26PM +, Daniel Stone wrote: > > On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > > > No disagreement there, we need CREATE_DUMB2. > > > > > > My point is that we have the current UAPI, and we

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Laurent Pinchart
On Wed, Jan 15, 2025 at 02:34:26PM +, Daniel Stone wrote: > On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > > No disagreement there, we need CREATE_DUMB2. > > > > My point is that we have the current UAPI, and we have userspace using > > it, but we don't have clear rules what the ioctl do

Re: [PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:05PM +0800, Jun Nie wrote: > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > enabled. Why? What is the issue that you are solving? > 4 pipes are preferred for dual DSI case for it is power optimal > for DSC. > > Signed-off-by: Jun Nie > ---

Re: [PATCH v4 15/16] drm/msm/dpu: Disable SSPP multi-rect mode for every pair

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:04PM +0800, Jun Nie wrote: > Currently, 2 pipes are supported at most. It is enough to check id to > know which pipe is in multi-rect mode and disable it. Multiple pairs > are used and need to check multirect_index to decide what pipes are in > multi-rect mode to disab

Re: [PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:03PM +0800, Jun Nie wrote: > Support SSPP assignment for quad-pipe case with unified method. > The first 2 pipes can share a set of mixer config and enable > multi-rect mode if condition is met. It is also the case for > the later 2 pipes. Missing problem description.

Re: [PATCH v4 13/16] drm/msm/dpu: support plane splitting in quad-pipe case

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:02PM +0800, Jun Nie wrote: > The content of every half of screen is sent out via one interface in > dual-DSI case. The content for every interface is blended by a LM > pair in quad-pipe case, thus a LM pair should not blend any content > that cross the half of screen i

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Thomas Zimmermann
Hi Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we have the current UAPI, and we have userspace using it, but we don't have clear rules what the ioctl does with specific parameters, and we don't document how it has to be used. Perhaps the situation is bad, and all we

Re: [PATCH v4 12/16] drm/msm/dpu: blend pipes per mixer pairs config

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:01PM +0800, Jun Nie wrote: > Currently, only 2 pipes are used at most for a plane. A stage structure > describes the configuration for a mixer pair. So only one stage is needed > for current usage cases. The quad-pipe case will be added in future and 2 > stages are use

Re: [PATCH v4 11/16] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:26:00PM +0800, Jun Nie wrote: > Split the PIPES_PER_STAGE definition per plane and mixer pair. Why are you trying to repeat commit subject? I noticed this pattern in other patches too. > Currently, 2 pipes are supported for a plane at most. A stage struct > contains con

Re: [PATCH v4 09/16] drm/msm/dpu: Add pipe as trace argument

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:58PM +0800, Jun Nie wrote: > Add pipe as trace argument in trace_dpu_crtc_setup_mixer() to ease > converting pipe into pipe array later. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h

Re: [PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-16 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:59PM +0800, Jun Nie wrote: > Store pipes in array with removing dedicated r_pipe. There are > 2 pipes in a drm plane at most currently, while 4 pipes are > required for quad-pipe case. Generalize the handling to pipe pair > and ease handling to another pipe pair later.