Re: [PATCH v2 02/22] drm: Add valid clones check

2024-12-06 Thread Jessica Zhang
On 9/25/2024 12:23 AM, Maxime Ripard wrote: On Tue, Sep 24, 2024 at 03:59:18PM GMT, Jessica Zhang wrote: Check that all encoders attached to a given CRTC are valid possible_clones of each other. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic_helper.c | 23

Re: [PATCH v3 5/9] drm/msm/dpu: Add SM6150 support

2024-12-06 Thread Abhinav Kumar
On 11/22/2024 1:56 AM, Fange Zhang wrote: From: Li Liu Add definitions for the display hardware used on the Qualcomm SM6150 platform. Signed-off-by: Li Liu Signed-off-by: Fange Zhang --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_sm6150.h | 263 + drivers/gpu/drm/msm

Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes

2024-12-06 Thread Abhinav Kumar
On 12/3/2024 5:58 AM, Dmitry Baryshkov wrote: On Tue, Dec 03, 2024 at 03:41:53PM +0800, Xiangxu Yin wrote: On 12/2/2024 5:32 PM, Dmitry Baryshkov wrote: On Mon, 2 Dec 2024 at 11:05, Xiangxu Yin wrote: On 11/29/2024 9:52 PM, Dmitry Baryshkov wrote: On Fri, 29 Nov 2024 at 09:59, Xiangx

[PATCH] drm/msm/dpu: filter out too wide modes if no 3dmux is present

2024-12-06 Thread Abhinav Kumar
+*/ + if (!dpu_kms->catalog->caps->has_3d_merge + && mode->hdisplay > dpu_kms->catalog->caps->max_mixer_width) + return MODE_BAD; /* * max crtc width is equal to the max mixer width * 2 and max height is 4K *

Re: [PATCH 44/45] arm64: dts: qcom: add mst support for pixel stream clk for DP0

2024-12-06 Thread Konrad Dybcio
On 6.12.2024 5:32 AM, Abhinav Kumar wrote: > From: Yongxing Mou > > Populate the pixel clock for stream 1 for DP0 for sa8775p DP controller. > > Signed-off-by: Yongxing Mou > Signed-off-by: Abhinav Kumar > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 > 1 file changed, 8 inse

Re: [PATCH 13/45] drm/msm/dp: separate dp_display_prepare() into its own API

2024-12-06 Thread Stephan Gerhold
On Thu, Dec 05, 2024 at 08:31:44PM -0800, Abhinav Kumar wrote: > dp_display_prepare() only prepares the link in case its not > already ready before dp_display_enable(). Hence separate it into > its own API. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 24 +++

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-12-06 Thread Johan Hovold
Hi Dmitry, On Wed, Nov 20, 2024 at 09:39:27AM +0100, Johan Hovold wrote: > On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote: > > During suspend/resume process all connectors are explicitly disabled and > > then reenabled. However resume fails because of the connector_status check:

Re: [PATCH 31/45] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:32:02PM -0800, Abhinav Kumar wrote: > Add a new file dp_mst_drm to manage the DP MST bridge operations > similar to the dp_drm file which manages the SST bridge operations. > Each MST encoder creates one bridge and each bridge is bound to its > own dp_panel abstraction to

[PATCH v2 06/10] drm/i915/audio: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Reviewed-by: Jani Nikula Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshko

[PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amd

[PATCH v2 10/10] drm/vc4: hdmi: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--

[PATCH v2 09/10] drm/sti: hdmi: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Acked-by: Raphael Gallais-Pou Signed-off-by: Dmitry Baryshkov --- drivers/gp

[PATCH v2 05/10] drm/exynos: hdmi: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2

[PATCH v2 08/10] drm/radeon: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/radeon/radeon_audio.c | 2

[PATCH v2 07/10] drm/msm/dp: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Acked-by: Abhinav Kumar Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Bary

[PATCH v2 02/10] drm/bridge: anx7625: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH v2 03/10] drm/bridge: ite-it66121: use eld_mutex to protect access to connector->eld

2024-12-06 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ite-it66121.c | 2

[PATCH v2 01/10] drm/connector: add mutex to protect ELD from concurrent access

2024-12-06 Thread Dmitry Baryshkov
The connector->eld is accessed by the .get_eld() callback. This access can collide with the drm_edid_to_eld() updating the data at the same time. Add drm_connector.eld_mutex to protect the data from concurrenct access. Individual drivers are not updated (to reduce possible issues while applying the

[PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-06 Thread Dmitry Baryshkov
The connector->eld is accessed by the .get_eld() callback. This access can collide with the drm_edid_to_eld() updating the data at the same time. Add drm_connector.eld_mutex to protect the data from concurrenct access. The individual drivers were just compile tested. I propose to merge the drm_con

Re: [PATCH 16/45] drm/msm/dp: add support for programming p1 register block

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:47PM -0800, Abhinav Kumar wrote: > p1 register block is needed for the second mst stream. > Add support in the catalog to be able to program this block. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 29 + >

Re: [PATCH 16/45] drm/msm/dp: add support for programming p1 register block

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:47PM -0800, Abhinav Kumar wrote: > p1 register block is needed for the second mst stream. > Add support in the catalog to be able to program this block. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 29 + >

Re: [PATCH 29/45] drm/msm/dp: skip reading the EDID for MST cases

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:32:00PM -0800, Abhinav Kumar wrote: > For MST cases, EDID is handled through AUX sideband messaging. > Skip the EDID read during hotplug handle for MST cases. But why? Isn't EDID being read at the hotplug time to update drm_connector's data? > > Signed-off-by: Abhinav

Re: [PATCH 37/45] drm/msm: add support for non-blocking commits

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:32:08PM -0800, Abhinav Kumar wrote: > Hook up the mst framework APIs with atomic_commit_setup() and > atomic_commit_tail() APIs to handle non-blocking commits. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/msm_atomic.c | 2 ++ > drivers/gpu/drm/msm/msm_d

Re: [PATCH 41/45] drm/msm/dpu: use msm_dp_get_mst_intf_id() to get the intf id

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:32:12PM -0800, Abhinav Kumar wrote: > Use msm_dp_get_mst_intf_id() to get the intf id for the DP MST > controller as the intf_id is unique for each MST stream of each > DP controller. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [PATCH 40/45] drm/msm: add a stream to intf map for DP controller

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:32:11PM -0800, Abhinav Kumar wrote: > Each DP controller capable of MST can support multiple streams > and each of the streams maps to an interface block ID which can > vary based on chipset. Add a stream to interface map for MST capable > DP controllers. > > Signed-off-

Re: [PATCH 11/45] drm/msm/dp: split dp_ctrl_off() into stream and link parts

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:42PM -0800, Abhinav Kumar wrote: > Split dp_ctrl_off() into stream and link parts so that for MST > cases we can control the link and pixel parts separately. Please start by describing the problem. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp

Re: [PATCH 07/45] drm/msm/dp: break up dp_display_enable into two parts

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:38PM -0800, Abhinav Kumar wrote: > dp_display_enable() currently re-trains the link if needed > and then enables the pixel clock, programs the controller to > start sending the pixel stream. Break up these two parts into > separate APIs to distinguish these two parts b

Re: [PATCH 10/45] drm/msm/dp: move the pixel clock control to its own API

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:41PM -0800, Abhinav Kumar wrote: > Enable/Disable of DP pixel clock happens in multiple code paths > leading to code duplication. Move it into individual helpers so that > the helpers can be called wherever necessary. > > Signed-off-by: Abhinav Kumar > --- > drivers

Re: [PATCH 09/45] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:40PM -0800, Abhinav Kumar wrote: > Currently, the dp_ctrl stream APIs operate on their own dp_panel > which is cached inside the dp_ctrl's private struct. However with MST, > the cached panel represents the fixed link and not the sinks which > are hotplugged. Allow the

Re: [PATCH 06/45] drm/msm/dp: remove dp_display's dp_mode and use dp_panel's instead

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:37PM -0800, Abhinav Kumar wrote: > dp_display caches the current display mode and then passes it onto > the panel to be used for programming the panel params. Remove this > two level passing and directly populated the panel's dp_display_mode > instead. Remove both and

Re: [PATCH 05/45] drm/msm/dp: add a helper to read mst caps for dp_panel

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:36PM -0800, Abhinav Kumar wrote: > Add a helper to check whether a dp_panel is mst capable. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_aux.h | 1 + > drivers/gpu/drm/msm/dp/dp_panel.c | 14 ++ > drivers/gpu/drm/msm/dp/dp_panel.

Re: [PATCH 04/45] drm/msm/dp: split msm_dp_panel_read_sink_caps() into two parts

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:35PM -0800, Abhinav Kumar wrote: > In preparation of DP MST where link caps are read for the > immediate downstream device and the edid is read through > sideband messaging, split the msm_dp_panel_read_sink_caps() into > two parts which read the link parameters and the

Re: [PATCH 03/45] drm/msm/dp: fix the intf_type of MST interfaces

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:34PM -0800, Abhinav Kumar wrote: > Interface type of MST interfaces is currently INTF_NONE. > Fix this to INTF_DP. Neither subject nor commit message tell that this is limited to sa8775p only. Please consider toggling all catalog files which are supposed to handle MST

Re: [PATCH 02/45] drm/msm/dp: disable the opp table request even for dp_ctrl_off_link()

2024-12-06 Thread Dmitry Baryshkov
On Thu, Dec 05, 2024 at 08:31:33PM -0800, Abhinav Kumar wrote: > dp_ctrl_off_link() was created to handle a case where we received > a cable connect and then get a cable disconnect without the corresponding > dp_display_enable(). For such cases the pixel clock will be off but the > link clock will