[PATCH 10/10] drm/vc4: hdmi: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 09/10] drm/sti: hdmi: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/sti/sti_hdmi.c | 2 ++ 1 file changed, 2 insertions(+

[PATCH 08/10] drm/radeon: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/radeon/radeon_audio.c | 2 ++ 1 file changed, 2 inser

[PATCH 07/10] drm/msm/dp: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 2 ++ 1 file changed, 2 insertion

[PATCH 06/10] drm/i915/audio: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_audio.c | 3 +++ 1 file changed, 3

[PATCH 03/10] drm/bridge: ite-it66121: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/ite-it66121.c | 2 ++ 1 file changed, 2 insert

[PATCH 05/10] drm/exynos: hdmi: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ 1 file changed, 2 insert

[PATCH 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file chan

[PATCH 02/10] drm/bridge: anx7625: use eld_mutex to protect access to connector->eld

2024-11-30 Thread Dmitry Baryshkov
Reading access to connector->eld can happen at the same time the drm_edid_to_eld() updates the data. Take the newly added eld_mutex in order to protect connector->eld from concurrent access. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++ 1 file changed, 2 i

[PATCH 01/10] drm/connector: add mutex to protect ELD from concurrent access

2024-11-30 Thread Dmitry Baryshkov
The connector->eld is accessed by the .get_eld() callback. This access can collide with the drm_edid_to_eld() updating the data at the same time. Add drm_connector.eld_mutex to protect the data from concurrenct access. Individual drivers are not updated (to reduce possible issues while applying the

[PATCH 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-11-30 Thread Dmitry Baryshkov
The connector->eld is accessed by the .get_eld() callback. This access can collide with the drm_edid_to_eld() updating the data at the same time. Add drm_connector.eld_mutex to protect the data from concurrenct access. The individual drivers were just compile tested. I propose to merge the drm_con

Re: [PATCH v3 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-11-30 Thread Akhil P Oommen
On 11/29/2024 9:03 PM, Konrad Dybcio wrote: > On 28.11.2024 11:25 AM, Neil Armstrong wrote: >> The Adreno GPU Management Unit (GMU) can also scale the DDR Bandwidth >> along the Frequency and Power Domain level, until now we left the OPP >> core scale the OPP bandwidth via the interconnect path. >>

Re: [PATCH v3 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-30 Thread Akhil P Oommen
On 11/28/2024 3:55 PM, Neil Armstrong wrote: > The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along > the Frequency and Power Domain level, but by default we leave the > OPP core scale the interconnect ddr path. > > While scaling via the interconnect path was sufficient, newer G

Re: [PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-30 Thread Akhil P Oommen
On 11/28/2024 3:55 PM, Neil Armstrong wrote: > Even if the code uses ARRAY_SIZE() to fill those tables, > it's still a best practice to not use magic values for > tables in structs. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong Reviewed-by: Akhil P Oommen -Akhil > --- >

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-30 Thread Akhil P Oommen
On 11/27/2024 9:17 PM, neil.armstr...@linaro.org wrote: > On 27/11/2024 16:29, Akhil P Oommen wrote: >> On 11/25/2024 1:42 PM, Neil Armstrong wrote: >>> On 23/11/2024 23:46, Akhil P Oommen wrote: On Sun, Nov 24, 2024 at 02:52:46AM +0530, Akhil P Oommen wrote: > On Tue, Nov 19, 2024 at 06:5

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-11-30 Thread Akhil P Oommen
On 11/30/2024 7:01 PM, Konrad Dybcio wrote: > On 25.11.2024 5:33 PM, Akhil P Oommen wrote: >> There are a few chipsets which don't have system cache a.k.a LLC. >> Currently, the assumption in the driver is that the system cache >> availability correlates with the presence of GMU or RPMH, which >> i

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-11-30 Thread Konrad Dybcio
On 25.11.2024 5:33 PM, Akhil P Oommen wrote: > There are a few chipsets which don't have system cache a.k.a LLC. > Currently, the assumption in the driver is that the system cache > availability correlates with the presence of GMU or RPMH, which > is not true. For instance, Snapdragon 6 Gen 1 has R