Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config

2024-11-20 Thread Rob Clark
On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel wrote: > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel wrote: > > > > It will be used in the next commit for DRM_MSM. > > > > Suggested-by: Rob Clark > > > Signed-off-by: Petr Vorel > > > --- > > > Changes v3->v4: > > > * Move definition to the end of

Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config

2024-11-20 Thread Masahiro Yamada
On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel wrote: > > It will be used in the next commit for DRM_MSM. > > Suggested-by: Rob Clark > Signed-off-by: Petr Vorel > --- > Changes v3->v4: > * Move definition to the end of the file I prefer to not check the tool. Why don't you install python3? >

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-20 Thread Rob Clark
On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov wrote: > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > Now the features defines have the right name, introduce a features > > bitfield and move the features defines in it, fixing all code checking > > for them. > > > > No fun

Re: [RFC][PATCH 1/1] drm/msm: require python3 and xml.parsers.expat module

2024-11-20 Thread Rob Clark
On Wed, Nov 20, 2024 at 7:49 AM Petr Vorel wrote: > > 0fddd045f88e introduced python3 dependency, require it to quick early. > > Signed-off-by: Petr Vorel > --- > Hi all, > > RFC because I'm not sure if previous failed build wasn't better: > > GENHDR drivers/gpu/drm/msm/generated/a2xx.xm

[PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-20 Thread Neil Armstrong
The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core vote for the interconnect ddr path. While scaling via the interconnect path was sufficient, newer GPUs like the A750 requires specific vote paremet

Re: [PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:45PM +0100, Neil Armstrong wrote: > Each GPU OPP requires a specific peak DDR bandwidth, let's add > those to each OPP and also the related interconnect path. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++ > 1 file c

[PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dheeraj Reddy Jonnalagadda
The variable pixel_div can remain zero due to an invalid rate input, leading to a potential division by zero issue. This patch fixes it and the function now logs an error and returns early. Additionally, this patch resolves trailing whitespace issues detected by checkpatch.pl in the same file. Si

[PATCH v2 02/11] drm/msm: adreno: rename quirks that are features

2024-11-20 Thread Neil Armstrong
Half of the current "Quirks" are in fact features, so rename the defines with FEAT instead of QUIRK. They will be moved in a separate bitfield in a second time. No functional changes. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 62 +++-

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dheeraj Reddy Jonnalagadda
On Wed, Nov 20, 2024 at 01:02:32PM +0200, Dmitry Baryshkov wrote: > On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > > The variable pixel_div can remain zero due to an invalid rate input, > > No, it can not. Rate is set by the driver, which knowns which rates are > sup

Re: [PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-20 Thread Neil Armstrong
On 20/11/2024 12:47, Dmitry Baryshkov wrote: On Tue, Nov 19, 2024 at 06:56:45PM +0100, Neil Armstrong wrote: Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-20 Thread Neil Armstrong
On 20/11/2024 12:19, Dmitry Baryshkov wrote: On Tue, Nov 19, 2024 at 06:56:39PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core vote for the interconnect ddr path.

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-20 Thread Neil Armstrong
On 20/11/2024 12:42, Dmitry Baryshkov wrote: On Tue, Nov 19, 2024 at 06:56:40PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. In ord

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 05:24:20PM +0530, Dheeraj Reddy Jonnalagadda wrote: > On Wed, Nov 20, 2024 at 01:02:32PM +0200, Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > > > The variable pixel_div can remain zero due to an invalid rate input,

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:39PM +0100, Neil Armstrong wrote: > The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth > along the Frequency and Power Domain level, but by default we leave the > OPP core vote for the interconnect ddr path. > > While scaling via the interconnect pa

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:40PM +0100, Neil Armstrong wrote: > The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth along > the Frequency and Power Domain level, but by default we leave the > OPP core scale the interconnect ddr path. > > In order to calculate vote values used by th

Re: [PATCH v2 11/11] arm64: qcom: dts: sm8650: add interconnect and opp-peak-kBps for GPU

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:46PM +0100, Neil Armstrong wrote: > Each GPU OPP requires a specific peak DDR bandwidth, let's add > those to each OPP and also the related interconnect path. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 14 ++ > 1 fil

Re: [PATCH v2 09/11] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:44PM +0100, Neil Armstrong wrote: > Now all the DDR bandwidth voting via the GPU Management Unit (GMU) > is in place, declare the Bus Control Modules (BCMs) and the > corresponding parameters in the GPU info struct and add the > GMU_BW_VOTE feature bit to enable it. >

Re: [PATCH v2 07/11] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:42PM +0100, Neil Armstrong wrote: > The Adreno GMU Management Unit (GMU) can also scale the DDR Bandwidth > along the Frequency and Power Domain level, until now we left the OPP > core scale the OPP bandwidth via the interconnect path. > > In order to enable bandwidth

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > Now the features defines have the right name, introduce a features > bitfield and move the features defines in it, fixing all code checking > for them. > > No functional changes intended. I think it might be better to squahs this p

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > The variable pixel_div can remain zero due to an invalid rate input, No, it can not. Rate is set by the driver, which knowns which rates are supported. > leading to a potential division by zero issue. This patch fixes

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-11-20 Thread Johan Hovold
On Fri, Aug 02, 2024 at 10:47:33PM +0300, Dmitry Baryshkov wrote: > During suspend/resume process all connectors are explicitly disabled and > then reenabled. However resume fails because of the connector_status check: > > [ 1185.831970] [dpu error]connector not connected 3 Please also include th

Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-11-20 Thread Johan Hovold
On Tue, Nov 19, 2024 at 10:02:33PM -0500, Leonard Lausen wrote: > The finding is that while 6.10.14 with this patch applied still suffers from > that regression, 6.11.9 and 6.12 do not face the CRTC state regression. > Therefore, whatever issue the patch uncovered in older kernels and which > just