Re: [PATCH v9 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Rob Clark
On Mon, Oct 28, 2024 at 4:53 AM Mostafa Saleh wrote: > > Hi Rob, > > On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This series extends io-pgtable-arm with a method to retrieve the page > > table entries traversed in the process of address translation, and

[PATCH v10 3/4] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-10-28 Thread Rob Clark
From: Rob Clark Add an io-pgtable method to walk the pgtable returning the raw PTEs that would be traversed for a given iova access. Signed-off-by: Rob Clark --- drivers/iommu/io-pgtable-arm.c | 25 + include/linux/io-pgtable.h | 15 +++ 2 files changed,

[PATCH v10 2/4] iommu/io-pgtable-arm: Re-use the pgtable walk for iova_to_phys

2024-10-28 Thread Rob Clark
From: Rob Clark Re-use the generic pgtable walk path. Signed-off-by: Rob Clark --- drivers/iommu/io-pgtable-arm.c | 74 +- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c index 7e9c0

[PATCH v10 4/4] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-10-28 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v10 1/4] iommu/io-pgtable-arm: Make pgtable walker more generic

2024-10-28 Thread Rob Clark
From: Rob Clark We can re-use this basic pgtable walk logic in a few places. Signed-off-by: Rob Clark --- drivers/iommu/io-pgtable-arm.c | 67 ++ 1 file changed, 43 insertions(+), 24 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pg

[PATCH v10 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

[pull] drm/msm: drm-msm-next-2024-10-28 for v6.13

2024-10-28 Thread Rob Clark
Hi Dave, Simona, This is the main pull for v6.13. Further description below. The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tags/drm-

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-28 Thread Adrián Larumbe
On 16.10.2024 09:07, Tvrtko Ursulin wrote: > > On 15/10/2024 20:05, Adrián Larumbe wrote: > > Hi Tvrtko, > > > > On 10.10.2024 10:50, Tvrtko Ursulin wrote: > > > > > > On 09/10/2024 23:55, Adrián Larumbe wrote: > > > > Hi Tvrtko, > > > > > > > > On 04.10.2024 14:41, Tvrtko Ursulin wrote: > > >

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 12:31:50PM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:52 AM, Dmitry Baryshkov wrote: > > On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > >> On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > >>> On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen > >>> wrote:

[PATCH 3/3] drm/msm/dp: tidy up platform data names

2024-10-28 Thread Dmitry Baryshkov
Follow the established symbol name pattern and rename platform data structures. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 11:52 AM, Dmitry Baryshkov wrote: > On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: >> On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: >>> On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen >>> wrote: On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > On Sun, Oc

Re: [PATCH v9 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-10-28 Thread Mostafa Saleh
Hi Rob, On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > From: Rob Clark > > This series extends io-pgtable-arm with a method to retrieve the page > table entries traversed in the process of address translation, and then > beefs up drm/msm gpu devcore dump to include this (and additi

[PATCH 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-28 Thread Dmitry Baryshkov
Follow the estalished prefix and rename eDP bridge symbols to use msm_dp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff -

[PATCH 0/3] drm/msm/dp: mass-rename symbols

2024-10-28 Thread Dmitry Baryshkov
| 42 +- drivers/gpu/drm/msm/dp/dp_utils.c | 20 +- drivers/gpu/drm/msm/dp/dp_utils.h | 8 +- 20 files changed, 1918 insertions(+), 1918 deletions(-) --- base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d change-id: 20241028-msm-dp-rename-f0eed848e231 Best regards, -- Dmitry Baryshkov

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >>> Clang-19 and above sometimes end up with multiple copies of the large >>> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >>> a

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen > > wrote: > >> > >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > >>> On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrot

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:39:16AM +0100, Konrad Dybcio wrote: > On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: > >>> Clang-19 and above sometimes end up with multiple copies of the large > >>

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: > > On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > >> Clang-19 and above sometimes end up with multiple copies of the large > >> a6xx_hfi_msg_bw_table structure on the stack. T

Re: [PATCH v6 2/9] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-10-28 Thread Dmitry Baryshkov
On Fri, Oct 25, 2024 at 12:00:20PM -0700, Abhinav Kumar wrote: > > > On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: > > In preparation for virtualized planes support, move pstate->pipe > > initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In > > case of virtual planes the plane's

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: >> >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: >>> On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: Clang-19 and above sometimes end up with multiple copies of the large

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number o

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number of device spe

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,