Re: [PATCH v3 07/10] drm/msm/A6xx: Add traces for preemption

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:25PM +0200, Antonino Maniscalco wrote: > Add trace points corresponding to preemption being triggered and being > completed for latency measurement purposes. > > Signed-off-by: Antonino Maniscalco > Tested-by: Neil Armstrong # on SM8650-QRD > --- > drivers/gpu/drm/

Re: [PATCH v3 06/10] drm/msm/A6xx: Use posamble to reset counters on preemption

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:24PM +0200, Antonino Maniscalco wrote: > Use the postamble to reset perf counters when switching between rings, > except when sysprof is enabled, analogously to how they are reset > between submissions when switching pagetables. > > Signed-off-by: Antonino Maniscalco

Re: [PATCH v3 00/10] Preemption support for A7XX

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:18PM +0200, Antonino Maniscalco wrote: > This series implements preemption for A7XX targets, which allows the GPU to > switch to an higher priority ring when work is pushed to it, reducing latency > for high priority submissions. > > This series enables L1 preemption

Re: [PATCH v3 04/10] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-06 Thread Akhil P Oommen
On Thu, Sep 05, 2024 at 04:51:22PM +0200, Antonino Maniscalco wrote: > This patch implements preemption feature for A6xx targets, this allows > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > hardware as such supports multiple levels of preemption granularities, > ranging

Re: [PATCH 11/21] drm/msm/dpu: Add RM support for allocating CWB

2024-09-06 Thread Dmitry Baryshkov
On Fri, 6 Sept 2024 at 19:53, Jessica Zhang wrote: > > > > On 9/5/2024 6:30 AM, Dmitry Baryshkov wrote: > > On Tue, Sep 03, 2024 at 06:04:13PM GMT, Jessica Zhang wrote: > >> > >> > >> On 8/30/2024 3:16 PM, Dmitry Baryshkov wrote: > >>> On Fri, 30 Aug 2024 at 22:28, Jessica Zhang > >>> wrote: > >

Re: [PATCH 11/21] drm/msm/dpu: Add RM support for allocating CWB

2024-09-06 Thread Jessica Zhang
On 9/5/2024 6:30 AM, Dmitry Baryshkov wrote: On Tue, Sep 03, 2024 at 06:04:13PM GMT, Jessica Zhang wrote: On 8/30/2024 3:16 PM, Dmitry Baryshkov wrote: On Fri, 30 Aug 2024 at 22:28, Jessica Zhang wrote: On 8/30/2024 10:18 AM, Dmitry Baryshkov wrote: On Thu, Aug 29, 2024 at 01:48:32PM

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Robin Murphy
On 06/09/2024 11:56 am, Will Deacon wrote: On Thu, Sep 05, 2024 at 05:27:28PM +0100, Robin Murphy wrote: On 05/09/2024 4:53 pm, Will Deacon wrote: On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Rob Clark
On Fri, Sep 6, 2024 at 5:24 AM Robin Murphy wrote: > > On 2024-09-05 6:10 pm, Rob Clark wrote: > > On Thu, Sep 5, 2024 at 10:00 AM Rob Clark wrote: > >> > >> On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: > >>> > >>> On 05/09/2024 4:53 pm, Will Deacon wrote: > Hi Rob, > > On T

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Robin Murphy
On 2024-09-05 6:10 pm, Rob Clark wrote: On Thu, Sep 5, 2024 at 10:00 AM Rob Clark wrote: On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: On 05/09/2024 4:53 pm, Will Deacon wrote: Hi Rob, On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: From: Rob Clark This reverts commit 8

[PATCH] treewide: Correct the typo 'retun'

2024-09-06 Thread WangYuli
There are some spelling mistakes of 'retun' in comments which should be instead of 'return'. Signed-off-by: WangYuli --- arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 +- drivers/infiniband/core/sa_query.c| 2 +- drivers/input/misc/wistro

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Will Deacon
On Thu, Sep 05, 2024 at 05:27:28PM +0100, Robin Murphy wrote: > On 05/09/2024 4:53 pm, Will Deacon wrote: > > On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. > > > > > > It was causing gpu

Re: [PATCH 1/5] drm/atomic: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Dmitry Baryshkov
On Fri, Sep 06, 2024 at 04:23:21PM GMT, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 9021c317b770 ("drm/imx: Add initial support for DCS

Re: [PATCH 3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Dmitry Baryshkov
On Fri, Sep 06, 2024 at 04:23:23PM GMT, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only a

Re: [PATCH 2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Dmitry Baryshkov
On Fri, Sep 06, 2024 at 04:23:22PM GMT, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 9021c317b770 ("drm/imx: Add initial support for DCS

Re: [PATCH 5/5] drm/msm/adreno: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Dmitry Baryshkov
On Fri, Sep 06, 2024 at 04:23:25PM GMT, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support") >

[PATCH 5/5] drm/msm/adreno: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c

[PATCH 4/5] drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9e532b3ad9a7 ("drm/tegra: dpaux: Disable interrupt when detached") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/tegr

[PATCH 3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only after adding the crtc") Signed-off-by: Jinjie Ruan --- drivers/gpu/d

[PATCH 2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/imx/dc

[PATCH 0/5] drm: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") said, reqeust_irq() and then disable_irq() is unsafe. In the small time gap between request_irq() and disable_irq(), interrupts can still come. IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents the a

[PATCH 1/5] drm/atomic: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-06 Thread Jinjie Ruan
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/imx/dc