Re: [PATCH] drm/msm/dpu: move dpu_encoder's connector assignment to atomic_enable()

2024-08-01 Thread Dmitry Baryshkov
On Wed, Jul 31, 2024 at 12:17:22PM GMT, Abhinav Kumar wrote: > For cases where the crtc's connectors_changed was set without enable/active > getting toggled , there is an atomic_enable() call followed by an > atomic_disable() but without an atomic_mode_set(). > > This results in a NULL ptr access

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-08-01 Thread Dmitry Baryshkov
On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > This patch series add dpu support for MSM8996/MSM8953 devices. > > Note, by default these platforms are still handled by the MDP5 driver > unless the `msm.prefer_mdp5=false' parameter is provided. Could you please provide a summary

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-08-01 Thread Dmitry Baryshkov
On Thu, Aug 01, 2024 at 06:45:03PM GMT, Barnabás Czémán wrote: > Should i resend this patch set? No. It was the merge window. > > On June 28, 2024 4:39:38 PM GMT+02:00, "Barnabás Czémán" > wrote: > >This patch series add dpu support for MSM8996/MSM8953 devices. > > > >Note, by default these pl

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-01 Thread Connor Abbott
On Thu, Aug 1, 2024 at 3:26 PM Vladimir Lypak wrote: > > On Thu, Aug 01, 2024 at 01:52:32PM +0100, Connor Abbott wrote: > > On Thu, Aug 1, 2024 at 1:25 PM Vladimir Lypak > > wrote: > > > > > > On Mon, Jul 29, 2024 at 06:26:45PM +0100, Connor Abbott wrote: > > > > On Thu, Jul 11, 2024 at 11:10 AM

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-01 Thread Vladimir Lypak
On Thu, Aug 01, 2024 at 01:52:32PM +0100, Connor Abbott wrote: > On Thu, Aug 1, 2024 at 1:25 PM Vladimir Lypak > wrote: > > > > On Mon, Jul 29, 2024 at 06:26:45PM +0100, Connor Abbott wrote: > > > On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak > > > wrote: > > > > > > > > On A5XX GPUs when pree

Re: [PATCH 2/4] drm/msm/a5xx: properly clear preemption records on resume

2024-08-01 Thread Akhil P Oommen
On Thu, Jul 11, 2024 at 10:00:19AM +, Vladimir Lypak wrote: > Two fields of preempt_record which are used by CP aren't reset on > resume: "data" and "info". This is the reason behind faults which happen > when we try to switch to the ring that was active last before suspend. > In addition those

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-01 Thread Connor Abbott
On Thu, Aug 1, 2024 at 1:25 PM Vladimir Lypak wrote: > > On Mon, Jul 29, 2024 at 06:26:45PM +0100, Connor Abbott wrote: > > On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak > > wrote: > > > > > > On A5XX GPUs when preemption is used it's invietable to enter a soft > > > lock-up state in which GPU

Re: [PATCH 1/4] drm/msm/a5xx: disable preemption in submits by default

2024-08-01 Thread Akhil P Oommen
On Mon, Jul 15, 2024 at 02:00:10PM -0700, Rob Clark wrote: > On Thu, Jul 11, 2024 at 3:02 AM Vladimir Lypak > wrote: > > > > Fine grain preemption (switching from/to points within submits) > > requires extra handling in command stream of those submits, especially > > when rendering with tiling (u

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-08-01 Thread Vladimir Lypak
On Mon, Jul 29, 2024 at 06:26:45PM +0100, Connor Abbott wrote: > On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak > wrote: > > > > On A5XX GPUs when preemption is used it's invietable to enter a soft > > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > > This appears as ful