Re: [PATCH v5 10/16] drm/msm/dpu: move pitch check to _dpu_format_get_plane_sizes_linear()

2024-07-17 Thread Abhinav Kumar
On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: The _dpu_format_get_plane_sizes_linear() already compares pitches of the framebuffer with the calculated pitches. Move the check to the same place, demoting DPU_ERROR to DPU_DEBUG to prevent user from spamming the kernel log. Signed-off-by: Dmitry

Re: [PATCH v5 08/16] drm/msm/dpu: drop msm_format from struct dpu_hw_fmt_layout

2024-07-17 Thread Dmitry Baryshkov
On Wed, 17 Jul 2024 at 23:15, Abhinav Kumar wrote: > > > > On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: > > The struct dpu_hw_fmt_layout defines hardware data layout (addresses, > > sizes and pitches. Drop format field from this structure as it's not a > Missing closing brace ")" here? > > > part

Re: [PATCH v5 09/16] drm/msm/dpu: pass drm_framebuffer to _dpu_format_get_plane_sizes()

2024-07-17 Thread Abhinav Kumar
On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: Instead of passing width / height / pitches, pass drm_framebuffer directly. This allows us to drop the useless check for !pitches, since an array can not be NULL. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c |

Re: [PATCH v5 08/16] drm/msm/dpu: drop msm_format from struct dpu_hw_fmt_layout

2024-07-17 Thread Abhinav Kumar
On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: The struct dpu_hw_fmt_layout defines hardware data layout (addresses, sizes and pitches. Drop format field from this structure as it's not a Missing closing brace ")" here? part of the data layout. Its a bit subjective IMO whether you conside

Re: [PATCH 0/4] fixes for Adreno A5Xx preemption

2024-07-17 Thread Connor Abbott
On Wed, Jul 17, 2024 at 5:33 PM Vladimir Lypak wrote: > > On Wed, Jul 17, 2024 at 10:40:26AM +0100, Connor Abbott wrote: > > On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak > > wrote: > > > > > > There are several issues with preemption on Adreno A5XX GPUs which > > > render system unusable if mo

[PATCH v6 2/2] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-07-17 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v6 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-07-17 Thread Rob Clark
From: Rob Clark Add an io-pgtable method to walk the pgtable returning the raw PTEs that would be traversed for a given iova access. Signed-off-by: Rob Clark Acked-by: Joerg Roedel --- drivers/iommu/io-pgtable-arm.c | 36 +- include/linux/io-pgtable.h | 17

[PATCH v6 0/2] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-07-17 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

Re: [PATCH 0/4] fixes for Adreno A5Xx preemption

2024-07-17 Thread Vladimir Lypak
On Wed, Jul 17, 2024 at 10:40:26AM +0100, Connor Abbott wrote: > On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak > wrote: > > > > There are several issues with preemption on Adreno A5XX GPUs which > > render system unusable if more than one priority level is used. Those > > issues include persiste

Re: [PATCH v4 2/5] drm/drm_property: require DRM_MODE_PROP_IMMUTABLE for single-value props

2024-07-17 Thread Dmitry Baryshkov
On Wed, Jul 17, 2024 at 03:42:46PM GMT, Maxime Ripard wrote: > Hi, > > On Mon, Jul 15, 2024 at 09:33:02AM GMT, Dmitry Baryshkov wrote: > > Document that DRM_MODE_PROP_IMMUTABLE must be set for the properties > > that are immutable by definition - e.g. ranges with min == max or enums > > with a sin

Re: [PATCH v4 2/5] drm/drm_property: require DRM_MODE_PROP_IMMUTABLE for single-value props

2024-07-17 Thread Maxime Ripard
Hi, On Mon, Jul 15, 2024 at 09:33:02AM GMT, Dmitry Baryshkov wrote: > Document that DRM_MODE_PROP_IMMUTABLE must be set for the properties > that are immutable by definition - e.g. ranges with min == max or enums > with a single value. This matches the behaviour of the IGT tests, see > kms_propert

Re: [PATCH 0/4] fixes for Adreno A5Xx preemption

2024-07-17 Thread Connor Abbott
On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak wrote: > > There are several issues with preemption on Adreno A5XX GPUs which > render system unusable if more than one priority level is used. Those > issues include persistent GPU faults and hangs, full UI lockups with > idling GPU. > > --- > Vladi