Re: [PATCH v3 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 03:51:13PM GMT, Rob Clark wrote: > From: Rob Clark > > Move the hwcg tables into the hw catalog. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 619 ++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 617 --

Re: [PATCH v3 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 03:51:12PM GMT, Rob Clark wrote: > From: Rob Clark > > Split each gen's gpu table into it's own file. Only code-motion, no > functional change. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile | 5 + > drivers/gpu/drm/msm/adreno/a2xx_ca

Re: [PATCH v3 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 03:51:11PM GMT, Rob Clark wrote: > From: Rob Clark > > Split into a separate table per generation, in preparation to move each > gen's device table to it's own file. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +--

Re: [PATCH v2 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 03:28:59PM GMT, Rob Clark wrote: > From: Rob Clark > > Split into a separate table per generation, in preparation to move each > gen's device table to it's own file. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +--

[PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-17 Thread Rob Clark
From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +-- drivers/gpu/drm/

[PATCH v3 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 247 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 257 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 + drive

[PATCH v3 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 619 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 617 - drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 - 3 files chang

[PATCH v3 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-17 Thread Rob Clark
From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 52 ++ drivers/gpu/drm/msm/adreno/a3xx_catalog.c | 81 +++ dr

[PATCH v3 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Rob Clark
From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 2 files change

[PATCH v3 0/5] drm/msm/adreno: Introduce/rework device hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Split the single flat gpulist table into per-gen tables that exist in their own per-gen files, and start moving more info into the device table. This at least gets all the big tables of register settings out of the heart of the a6xx_gpu code. Probably more could be moved, to rem

[PATCH v2 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 247 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 257 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 + drive

[PATCH v2 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 619 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 617 - drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 - 3 files chang

[PATCH v2 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-17 Thread Rob Clark
From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +-- drivers/gpu/drm/

[PATCH v2 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-17 Thread Rob Clark
From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 52 ++ drivers/gpu/drm/msm/adreno/a3xx_catalog.c | 81 +++ dr

[PATCH v2 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Rob Clark
From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 2 files change

[PATCH v2 0/5] drm/msm/adreno: Introduce/rework device hw catalog

2024-06-17 Thread Rob Clark
From: Rob Clark Split the single flat gpulist table into per-gen tables that exist in their own per-gen files, and start moving more info into the device table. This at least gets all the big tables of register settings out of the heart of the a6xx_gpu code. Probably more could be moved, to rem

Re: [PATCH v4 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-06-17 Thread Jeffrey Hugo
On 6/15/2024 5:35 AM, Konrad Dybcio wrote: On 14.06.2024 12:33 PM, Dmitry Baryshkov wrote: On Fri, Jun 14, 2024 at 01:55:46AM GMT, Konrad Dybcio wrote: [...] GCC_HDMI_CLKREF_CLK is a child of xo, so you can drop the latter. It would also be worth confirming whether it's really powering th

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-17 Thread Robin Murphy
On 23/05/2024 6:52 pm, Rob Clark wrote: From: Rob Clark Add an io-pgtable method to walk the pgtable returning the raw PTEs that would be traversed for a given iova access. Have to say I'm a little torn here - with my iommu-dma hat on I'm not super enthusiastic about adding any more overhead