Re: [PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-15 Thread Guenter Roeck
On Fri, Mar 15, 2024 at 2:37 PM Douglas Anderson wrote: > > As documented in the description of the transfer() function of > "struct drm_dp_aux", the transfer() function can be called at any time > regardless of the state of the DP port. Specifically if the kernel has > the DP AUX character device

Re: [PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Dmitry Baryshkov
1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28193 > > > > Signed-off-by: Dmitry Baryshkov > > --- > > Changes in v3: > > - Split XML and git rm patches in hope to pass ML limitations > > - Link to v2: > > https://lore.kernel.org/r/20240315-

[PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-15 Thread Douglas Anderson
Before the introduction of the wait_hpd_asserted() callback in commit 841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux") the API between panel drivers and DP AUX bus drivers was that it was up to the AUX bus driver to wait for HPD in the transfer() function. Now wait_hp

[PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-15 Thread Douglas Anderson
This is a no-op change to just fix a typo in the name of a static function. Signed-off-by: Douglas Anderson --- Changes in v2: - ("Fix typo in static function (ststus => status)") new for v2. drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH v2 2/4] drm/msm/dp: Account for the timeout in wait_hpd_asserted() callback

2024-03-15 Thread Douglas Anderson
The DP wait_hpd_asserted() callback is passed a timeout which indicates how long we should wait for HPD. This timeout was being ignored in the MSM DP implementation and instead a hardcoded 500 ms timeout was used. Fix it to use the proper timeout. As part of this we move the hardcoded 500 ms numbe

[PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-15 Thread Douglas Anderson
As documented in the description of the transfer() function of "struct drm_dp_aux", the transfer() function can be called at any time regardless of the state of the DP port. Specifically if the kernel has the DP AUX character device enabled and userspace accesses "/dev/drm_dp_auxN" directly then th

[PATCH v2 0/4] drm/msm/dp: Improve DP AUX transfer vs. HPD interactions

2024-03-15 Thread Douglas Anderson
The main goal of this patch series is to avoid problems running "fwupd" on Qualcomm devices. Right now several of the plugins used with fwupd try talking over all DP AUX busses and this results in a very long timeout on Qualcomm devices. As part of fixing this, I noticed a case where the MSM DP

Re: [PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Rob Clark
send the next iteration. > > [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28193 > > Signed-off-by: Dmitry Baryshkov > --- > Changes in v3: > - Split XML and git rm patches in hope to pass ML limitations > - Link to v2: > https://lore.kernel.org/r/20240315-fd-xml-shippe

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-15 Thread Johan Hovold
On Thu, Mar 14, 2024 at 09:30:57AM -0700, Abhinav Kumar wrote: > On 3/14/2024 8:38 AM, Johan Hovold wrote: > > On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote: > > Perhaps I'm missing something in the race that you are trying to > > describe (and which I've asked you to describe in m

[PATCH RFC v3 08/12] drm/msm: import gen_header.py script from Mesa

2024-03-15 Thread Dmitry Baryshkov
Import the gen_headers.py script from Mesa, commit FIXME. This script will be used to generate MSM register files on the fly during compilation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/gen_header.py | 958 1 file changed, 958 insertions(+)

[PATCH RFC v3 09/12] drm/msm: generate headers on the fly

2024-03-15 Thread Dmitry Baryshkov
Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease reviews). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

[PATCH RFC v3 04/12] drm/msm: move msm_gpummu.c to adreno/a2xx_gpummu.c

2024-03-15 Thread Dmitry Baryshkov
The msm_gpummu.c implementation is used only on A2xx and it is tied to the A2xx registers. Rename the source file accordingly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 +- drivers/gpu/d

[PATCH RFC v3 03/12] drm/msm/dsi: drop mmss_cc.xml.h

2024-03-15 Thread Dmitry Baryshkov
The mmss_cc.xml.h file describes bits of the MMSS clock controller on APQ8064 / MSM8960 platforms. They are not used by the driver and do not belong to the DRM MSM driver. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/mmss_cc.xml.h | 131 -

[PATCH RFC v3 02/12] drm/msm/hdmi: drop qfprom.xml.h

2024-03-15 Thread Dmitry Baryshkov
The qfprom.xml.h contains definitions for the nvmem code. They are not used in the existing code. Also if we were to use them later, we should have used nvmem cell API instead of using these defs. Drop the file. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61 -

[PATCH RFC v3 01/12] drm/msm/mdp5: add writeback block bases

2024-03-15 Thread Dmitry Baryshkov
In order to stop patching the mdp5 headers, import definitions for the writeback blocks. This part is extracted from the old Rob's patch. Co-developed-by: Rob Clark Signed-off-by: Rob Clark Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++ 1 file ch

[PATCH RFC v3 00/12] drm/msm: generate register header files

2024-03-15 Thread Dmitry Baryshkov
Baryshkov --- Changes in v3: - Split XML and git rm patches in hope to pass ML limitations - Link to v2: https://lore.kernel.org/r/20240315-fd-xml-shipped-v2-0-7cd68ecc4...@linaro.org Changes in v2: - Removed the _shipped files, always generating the headers (Masahiro Yamada) - Replaced headergen2