Re: [Freedreno] [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-25 Thread kernel test robot
Hi Matthew, kernel test robot noticed the following build warnings: [auto build test WARNING on 201c8a7bd1f3f415920a2df4b8a8817e973f42fe] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/drm-sched-Add-drm_sched_wqueue_-helpers/20231026-121313 base: 201c8a7bd1f3f415920a2df4

Re: [Freedreno] [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-25 Thread Luben Tuikov
On 2023-10-26 00:12, Matthew Brost wrote: > From: Luben Tuikov > > The GPU scheduler has now a variable number of run-queues, which are set up at > drm_sched_init() time. This way, each driver announces how many run-queues it > requires (supports) per each GPU scheduler it creates. Note, that run

[Freedreno] [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-25 Thread Matthew Brost
From: Luben Tuikov The GPU scheduler has now a variable number of run-queues, which are set up at drm_sched_init() time. This way, each driver announces how many run-queues it requires (supports) per each GPU scheduler it creates. Note, that run-queues correspond to scheduler "priorities", thus i

Re: [Freedreno] [PATCH v5 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

2023-10-25 Thread Bjorn Andersson
On Thu, Oct 26, 2023 at 01:28:06AM +0300, Dmitry Baryshkov wrote: > Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the > same functionality for the DRM bridge chain termination. > Reviewed-by: Bjorn Andersson Acked-by: Bjorn Andersson Regards, Bjorn

[Freedreno] [PATCH v5 4/6] drm/bridge: implement generic DP HPD bridge

2023-10-25 Thread Dmitry Baryshkov
Several USB-C controllers implement a pretty simple DRM bridge which implements just the HPD notification operations. Add special helper for creating such simple bridges. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/Kconfig | 8 ++ drivers/gpu/drm/bridge/Makefile

[Freedreno] [PATCH v5 3/6] usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE

2023-10-25 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Reviewed-by: Heikki Krogerus Acked-by: Greg Kroah-Hartman Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +- drivers/usb/typ

[Freedreno] [PATCH v5 6/6] usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE

2023-10-25 Thread Dmitry Baryshkov
Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/tcpm/Kconfig| 1 + drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 41 +++ 2 files

[Freedreno] [PATCH v5 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

2023-10-25 Thread Dmitry Baryshkov
Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/Kconfig | 1 + drivers/soc/qcom/pmic_glink_altmode.c | 33 --- 2 files changed

[Freedreno] [PATCH v5 2/6] phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE

2023-10-25 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Acked-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44

[Freedreno] [PATCH v5 1/6] drm/bridge: add transparent bridge helper

2023-10-25 Thread Dmitry Baryshkov
Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any additio

[Freedreno] [PATCH v5 0/6] drm: simplify support for transparent DRM bridges

2023-10-25 Thread Dmitry Baryshkov
Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a different way resulted either in series of hacks or in device tree not reflecting the actual hardware design. This results in drivers having similar boile

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-25 Thread Dmitry Baryshkov
On 25/10/2023 15:44, Maxime Ripard wrote: On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: The MIPI DSI links do not fully fall into the DRM callbacks model.

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Simon Ser
On Wednesday, October 25th, 2023 at 14:45, Dmitry Baryshkov wrote: > On 25/10/2023 15:29, Simon Ser wrote: > > > On Wednesday, October 25th, 2023 at 14:22, Johan Hovold jo...@kernel.org > > wrote: > > > > > I was just going to post a patch fixing this after finally investigating > > > why the

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Dmitry Baryshkov
On 25/10/2023 15:23, Johan Hovold wrote: On Wed, Oct 11, 2023 at 01:52:29AM +0300, Dmitry Baryshkov wrote: As it was pointed out by Simon Ser, the DRM_MODE_CONNECTOR_USB connector is reserved for the GUD devices. Other drivers (i915, amdgpu) use DRM_MODE_CONNECTOR_DisplayPort even if the DP stre

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Dmitry Baryshkov
On 25/10/2023 15:29, Simon Ser wrote: On Wednesday, October 25th, 2023 at 14:22, Johan Hovold wrote: I was just going to post a patch fixing this after finally investigating why the DisplayPort outputs on the X13s were annoyingly identified as "Unknown20-1" and "Unknown20-2" instead of the ex

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-25 Thread Maxime Ripard
On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > > > The MIPI DSI links do not fully fall into the DRM callbacks model. > > > > Explaining why would hel

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Johan Hovold
On Wed, Oct 25, 2023 at 12:29:26PM +, Simon Ser wrote: > On Wednesday, October 25th, 2023 at 14:22, Johan Hovold > wrote: > > > I was just going to post a patch fixing this after finally investigating > > why the DisplayPort outputs on the X13s were annoyingly identified as > > "Unknown20-1"

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Simon Ser
On Wednesday, October 25th, 2023 at 14:22, Johan Hovold wrote: > I was just going to post a patch fixing this after finally investigating > why the DisplayPort outputs on the X13s were annoyingly identified as > "Unknown20-1" and "Unknown20-2" instead of the expected "DP-1" and > "DP-2". Note,

Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-25 Thread Johan Hovold
On Wed, Oct 11, 2023 at 01:52:29AM +0300, Dmitry Baryshkov wrote: > As it was pointed out by Simon Ser, the DRM_MODE_CONNECTOR_USB connector > is reserved for the GUD devices. Other drivers (i915, amdgpu) use > DRM_MODE_CONNECTOR_DisplayPort even if the DP stream is handled by the > USB-C altmode.

Re: [Freedreno] [PATCH v2] drm/msm: remove unnecessary NULL check

2023-10-25 Thread Dmitry Baryshkov
On 13/10/2023 11:25, Dan Carpenter wrote: This NULL check was required when it was added, but we shuffled the code around and now it's not. The inconsistent NULL checking triggers a Smatch warning: drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: variable dereferenced be

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-25 Thread Dmitry Baryshkov
On 07/10/2023 13:08, Bryan O'Donoghue wrote: On 07/10/2023 00:45, Konrad Dybcio wrote: On 4.10.2023 14:52, Bryan O'Donoghue wrote: On 04/10/2023 13:08, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_

[Freedreno] [PATCH v2 2/2] drm/msm/dp: attach the DP subconnector property

2023-10-25 Thread Dmitry Baryshkov
While developing and testing the commit bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type") I had the patch [1] in my tree. I haven't noticed that it was a dependency for the commit in question. Mea culpa. Since the patch has not landed yet (and even was not reviewed) and since o

[Freedreno] [PATCH v2 0/2] drm/msm/dp: fix DP subconnector handling

2023-10-25 Thread Dmitry Baryshkov
Fix two failovers in the DP subconnector's patch. I didn't notice that I had another patch adding the property in my tree and later Abel pointed out that we shouldn't use subconnector type for eDP panels. Fixes since v1: - Add Abel's patch. Abel Vesa (1): drm/msm/dp: don't touch DP subconnecto

[Freedreno] [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case

2023-10-25 Thread Dmitry Baryshkov
From: Abel Vesa In case of the eDP connection there is no subconnetor and as such no subconnector property. Put drm_dp_set_subconnector_property() calls under the !is_edp condition. Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type") Signed-off-by: Abel Vesa Signed-off-

Re: [Freedreno] [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-10-25 Thread Dmitry Baryshkov
On 26/09/2023 23:03, Konrad Dybcio wrote: On 26.09.2023 21:10, Danila Tikhonov wrote: I think you mean by name downstream dt - sdmmagpie-gpu.dtsi You can see the forked version of the mainline here: https://github.com/sm7150-mainline/linux/blob/next/arch/arm64/boot/dts/qcom/sm7150.dtsi All fd

Re: [Freedreno] [PATCH 8/8] drm/msm: dsi: add support for DSI 2.8.0

2023-10-25 Thread Dmitry Baryshkov
On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: > > Add DSI Controller version 2.8.0 support for the SM8650 platform. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 17 + > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 18 insertio

Re: [Freedreno] [PATCH 7/8] drm/msm: dsi: add support for DSI-PHY on SM8650

2023-10-25 Thread Dmitry Baryshkov
On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: > > Add DSI PHY support for the SM8650 platform. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 27 +

Re: [Freedreno] [PATCH 5/8] drm/msm: dpu1: add support for SM8650 DPU

2023-10-25 Thread Neil Armstrong
On 25/10/2023 09:49, Dmitry Baryshkov wrote: On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: Add DPU version 10.0 support for the SM8650 platform. Signed-off-by: Neil Armstrong Thanks for your patch. Could you please rebase it on top of https://patchwork.freedesktop.org/series/119804/

Re: [Freedreno] [PATCH 6/8] drm/msm: mdss: add support for SM8650

2023-10-25 Thread Dmitry Baryshkov
On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: > > Add Mobile Display Subsystem (MDSS) support for the SM8650 platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_mdss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/

Re: [Freedreno] [PATCH 5/8] drm/msm: dpu1: add support for SM8650 DPU

2023-10-25 Thread Dmitry Baryshkov
On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: > > Add DPU version 10.0 support for the SM8650 platform. > > Signed-off-by: Neil Armstrong Thanks for your patch. Could you please rebase it on top of https://patchwork.freedesktop.org/series/119804/ ? > --- > .../drm/msm/disp/dpu1/catalog/d

[Freedreno] [PATCH 8/8] drm/msm: dsi: add support for DSI 2.8.0

2023-10-25 Thread Neil Armstrong
Add DSI Controller version 2.8.0 support for the SM8650 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 17 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu

[Freedreno] [PATCH 7/8] drm/msm: dsi: add support for DSI-PHY on SM8650

2023-10-25 Thread Neil Armstrong
Add DSI PHY support for the SM8650 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 27 +++ 3 files changed, 30 insertions(+) diff

[Freedreno] [PATCH 5/8] drm/msm: dpu1: add support for SM8650 DPU

2023-10-25 Thread Neil Armstrong
Add DPU version 10.0 support for the SM8650 platform. Signed-off-by: Neil Armstrong --- .../drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h| 458 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers

[Freedreno] [PATCH 6/8] drm/msm: mdss: add support for SM8650

2023-10-25 Thread Neil Armstrong
Add Mobile Display Subsystem (MDSS) support for the SM8650 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/msm_mdss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 6865db1e3ce8..33947a2e313c 100644 --- a/

[Freedreno] [PATCH 4/8] dt-bindings: display: msm: document the SM8650 Mobile Display Subsystem

2023-10-25 Thread Neil Armstrong
Document the Mobile Display Subsystem (MDSS) on the SM8650 Platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8650-mdss.yaml | 322 + 1 file changed, 322 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.y

[Freedreno] [PATCH 3/8] dt-bindings: display: msm: document the SM8650 DPU

2023-10-25 Thread Neil Armstrong
Document the DPU Display Controller on the SM8650 Platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8650-dpu.yaml | 127 + 1 file changed, 127 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Docu

[Freedreno] [PATCH 2/8] dt-bindings: display: msm-dsi-controller-main: document the SM8650 DSI Controller

2023-10-25 Thread Neil Armstrong
Document the DSI Controller on the SM8650 Platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentat

[Freedreno] [PATCH 1/8] dt-bindings: display: msm-dsi-phy-7nm: document the SM8650 DSI PHY

2023-10-25 Thread Neil Armstrong
Document the DSI PHY on the SM8650 Platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/di

[Freedreno] [PATCH 0/8] drm/msm: Introduce display support for SM8650

2023-10-25 Thread Neil Armstrong
The SM8650 MDSS is very close from the MDSS 9.0.0 found on the SM8550 SoC, with the following difference: - DSI PHY 2.8.8, no significant differences - DPU 10.0.0: - Enhanced max_linewidth to 8k - PINGPONG_8 & PINGPONG_9 - MERGE_3D_4 - DSC_4 & DSC_5, DSC_NATIVE_42x on DSC0/1 This patchset