Re: [Freedreno] [PATCH -next 3/7] drm/msm: Remove unnecessary NULL values

2023-08-11 Thread Abhinav Kumar
On 8/8/2023 8:44 PM, Ruan Jinjie wrote: The NULL initialization of the pointers assigned by kzalloc() first is not necessary, because if the kzalloc() failed, the pointers will be assigned NULL, otherwise it works as usual. so remove it. Signed-off-by: Ruan Jinjie --- drivers/gpu/drm/msm/d

Re: [Freedreno] [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Rob Clark
It is in https://gitlab.freedesktop.org/drm/msm/-/merge_requests/75 so should be in msm-next for v6.6 BR, -R On Fri, Aug 11, 2023 at 9:11 AM Fabio Estevam wrote: > > Hi Rob, > > Any comments, please? > > On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > > > Hi Rob, > > > > A gentle ping.

Re: [Freedreno] [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-08-11 Thread Rob Herring
On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > > Changes in v2: > - Removed the unnecessary inclusion of header rpmpd.h. > > This patch is

Re: [Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:31 AM Konrad Dybcio wrote: > > On 11.08.2023 18:21, Rob Clark wrote: > > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio > > wrote: > >> > >> On 11.08.2023 18:09, Rob Clark wrote: > >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > > From: Rob Clark > >>>

Re: [Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
On 11.08.2023 18:21, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio > wrote: >> >> On 11.08.2023 18:09, Rob Clark wrote: >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: From: Rob Clark There isn't actually a a690_gmu.bin. But it appears that the norma

Re: [Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio wrote: > > On 11.08.2023 18:09, Rob Clark wrote: > > On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > >> > >> From: Rob Clark > >> > >> There isn't actually a a690_gmu.bin. But it appears that the normal > >> a660_gmu.bin works fine. Normally all

Re: [Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
On 11.08.2023 18:09, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: >> >> From: Rob Clark >> >> There isn't actually a a690_gmu.bin. But it appears that the normal >> a660_gmu.bin works fine. Normally all the devices within a sub- >> generation (or "family") will use the sa

Re: [Freedreno] [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-08-11 Thread Fabio Estevam
Hi Rob, Any comments, please? On Mon, Jul 24, 2023 at 5:28 PM Fabio Estevam wrote: > > Hi Rob, > > A gentle ping. > > On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov > wrote: > > > > On 21/06/2023 02:23, Fabio Estevam wrote: > > > From: Fabio Estevam > > > > > > The adreno_is_a20x() and adren

Re: [Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: > > From: Rob Clark > > There isn't actually a a690_gmu.bin. But it appears that the normal > a660_gmu.bin works fine. Normally all the devices within a sub- > generation (or "family") will use the same fw, and a690 is in the a660 > family. > po

[Freedreno] [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Rob Clark
From: Rob Clark There isn't actually a a690_gmu.bin. But it appears that the normal a660_gmu.bin works fine. Normally all the devices within a sub- generation (or "family") will use the same fw, and a690 is in the a660 family. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_de