Re: [Freedreno] [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-26 Thread Rohit Agarwal
On 7/27/2023 11:06 AM, Pavan Kondeti wrote: On Thu, Jul 27, 2023 at 10:21:10AM +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-

Re: [Freedreno] [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-26 Thread Rob Herring
On Thu, 27 Jul 2023 10:21:10 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml| 3 ++- > Documentation/de

Re: [Freedreno] [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-26 Thread Pavan Kondeti
On Thu, Jul 27, 2023 at 10:21:10AM +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml| 3 ++- > Documentatio

[Freedreno] [PATCH] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-26 Thread Rohit Agarwal
Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml| 3 ++- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 3 ++- Documentation

[Freedreno] [PATCH -next] drm/msm: Remove redundant DRM_DEV_ERROR()

2023-07-26 Thread Ruan Jinjie
There is no need to call the DRM_DEV_ERROR() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c |

Re: [Freedreno] [PATCH 6/6] drm/msm/dpu: drop UBWC configuration

2023-07-26 Thread Abhinav Kumar
On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: As the DPU driver has switched to fetching data from MDSS driver, we can now drop the UBWC and highest_bank_bit parts of the DPU hw catalog. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 6 -- ..

Re: [Freedreno] [PATCH 5/6] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-26 Thread Abhinav Kumar
On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 18 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 7

Re: [Freedreno] [PATCH 4/6] drm/msm/mdss: populate missing data

2023-07-26 Thread Abhinav Kumar
On 7/26/2023 3:58 PM, Dmitry Baryshkov wrote: On Thu, 27 Jul 2023 at 01:30, Abhinav Kumar wrote: On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: As we are going to use MDSS data for DPU programming, populate missing MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS programming

Re: [Freedreno] [PATCH 4/6] drm/msm/mdss: populate missing data

2023-07-26 Thread Dmitry Baryshkov
On Thu, 27 Jul 2023 at 01:30, Abhinav Kumar wrote: > > > > On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: > > As we are going to use MDSS data for DPU programming, populate missing > > MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS > > programming, so skip them. > > > > Can you pls

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Rob Clark
On Wed, Jul 26, 2023 at 3:33 PM Dmitry Baryshkov wrote: > > On Thu, 27 Jul 2023 at 01:04, Rob Clark wrote: > > > > On Wed, Jul 26, 2023 at 2:43 PM Dmitry Baryshkov > > wrote: > > > > > > On 26/07/2023 23:11, Rob Clark wrote: > > > > On Wed, Jul 26, 2023 at 1:00 PM Dmitry Baryshkov > > > > wrote

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Dmitry Baryshkov
On Thu, 27 Jul 2023 at 01:04, Rob Clark wrote: > > On Wed, Jul 26, 2023 at 2:43 PM Dmitry Baryshkov > wrote: > > > > On 26/07/2023 23:11, Rob Clark wrote: > > > On Wed, Jul 26, 2023 at 1:00 PM Dmitry Baryshkov > > > wrote: > > >> > > >> On Wed, 26 Jul 2023 at 21:28, Rob Clark wrote: > > >>> > >

Re: [Freedreno] [PATCH 4/6] drm/msm/mdss: populate missing data

2023-07-26 Thread Abhinav Kumar
On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: As we are going to use MDSS data for DPU programming, populate missing MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS programming, so skip them. Can you pls point me to the downstream references you used for msm8998? Was that ju

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Rob Clark
On Wed, Jul 26, 2023 at 2:43 PM Dmitry Baryshkov wrote: > > On 26/07/2023 23:11, Rob Clark wrote: > > On Wed, Jul 26, 2023 at 1:00 PM Dmitry Baryshkov > > wrote: > >> > >> On Wed, 26 Jul 2023 at 21:28, Rob Clark wrote: > >>> > >>> On Thu, Jul 13, 2023 at 1:26 PM Akhil P Oommen > >>> wrote: > >

Re: [Freedreno] [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-26 Thread Rob Clark
On Sat, Jul 15, 2023 at 6:38 AM Konrad Dybcio wrote: > > On 7.07.2023 18:08, Rob Clark wrote: > > On Thu, Jul 6, 2023 at 5:25 PM Konrad Dybcio > > wrote: > >> > >> Apart from all these comments, I don't really see the point of this patch, > >> other than trying to tie together Qualcomm's almost-

Re: [Freedreno] [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-26 Thread Dmitry Baryshkov
On 27/07/2023 00:44, Rob Clark wrote: On Wed, Jul 26, 2023 at 2:38 PM Dmitry Baryshkov wrote: On 27/07/2023 00:37, Rob Clark wrote: On Thu, Jul 6, 2023 at 8:45 PM Dmitry Baryshkov wrote: On 07/07/2023 00:10, Rob Clark wrote: From: Rob Clark /* Helper for formating the chip_id in the

Re: [Freedreno] [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-26 Thread Rob Clark
On Wed, Jul 26, 2023 at 2:38 PM Dmitry Baryshkov wrote: > > On 27/07/2023 00:37, Rob Clark wrote: > > On Thu, Jul 6, 2023 at 8:45 PM Dmitry Baryshkov > > wrote: > >> > >> On 07/07/2023 00:10, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>>/* Helper for formating the chip_id in the way tha

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Dmitry Baryshkov
On 26/07/2023 23:11, Rob Clark wrote: On Wed, Jul 26, 2023 at 1:00 PM Dmitry Baryshkov wrote: On Wed, 26 Jul 2023 at 21:28, Rob Clark wrote: On Thu, Jul 13, 2023 at 1:26 PM Akhil P Oommen wrote: On Fri, Jul 07, 2023 at 05:34:04AM +0300, Dmitry Baryshkov wrote: On 07/07/2023 00:10, Rob

Re: [Freedreno] [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-26 Thread Dmitry Baryshkov
On 27/07/2023 00:37, Rob Clark wrote: On Thu, Jul 6, 2023 at 8:45 PM Dmitry Baryshkov wrote: On 07/07/2023 00:10, Rob Clark wrote: From: Rob Clark Since the revision becomes an opaque identifier with future GPUs, move away from treating different ranges of bits as having a given meaning. Th

Re: [Freedreno] [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-26 Thread Rob Clark
On Thu, Jul 6, 2023 at 8:45 PM Dmitry Baryshkov wrote: > > On 07/07/2023 00:10, Rob Clark wrote: > > From: Rob Clark > > > > Since the revision becomes an opaque identifier with future GPUs, move > > away from treating different ranges of bits as having a given meaning. > > This means that we nee

Re: [Freedreno] [PATCH 3/6] drm/msm/mdss: export UBWC data

2023-07-26 Thread Dmitry Baryshkov
On Thu, 27 Jul 2023 at 00:21, Abhinav Kumar wrote: > > > > On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: > > DPU programming requires knowledge of some of UBWC parameters. This > > results in duplication of UBWC data between MDSS and DPU drivers. Export > > the required data from MDSS driver. > >

Re: [Freedreno] [PATCH 3/6] drm/msm/mdss: export UBWC data

2023-07-26 Thread Abhinav Kumar
On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: DPU programming requires knowledge of some of UBWC parameters. This results in duplication of UBWC data between MDSS and DPU drivers. Export the required data from MDSS driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c

Re: [Freedreno] [PATCH 2/6] drm/msm/mdss: rename ubwc_version to ubwc_enc_version

2023-07-26 Thread Abhinav Kumar
On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: Rename the ubwc_version field to ubwc_enc_version, it denotes the version of the UBWC encoder, not the "UBWC version". Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 26 +- 1 file changed, 13 inse

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Rob Clark
On Wed, Jul 26, 2023 at 1:00 PM Dmitry Baryshkov wrote: > > On Wed, 26 Jul 2023 at 21:28, Rob Clark wrote: > > > > On Thu, Jul 13, 2023 at 1:26 PM Akhil P Oommen > > wrote: > > > > > > On Fri, Jul 07, 2023 at 05:34:04AM +0300, Dmitry Baryshkov wrote: > > > > > > > > On 07/07/2023 00:10, Rob Cla

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Dmitry Baryshkov
On Wed, 26 Jul 2023 at 21:28, Rob Clark wrote: > > On Thu, Jul 13, 2023 at 1:26 PM Akhil P Oommen > wrote: > > > > On Fri, Jul 07, 2023 at 05:34:04AM +0300, Dmitry Baryshkov wrote: > > > > > > On 07/07/2023 00:10, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > There are cases where th

Re: [Freedreno] [PATCH 06/12] drm/msm/adreno: Allow SoC specific gpu device table entries

2023-07-26 Thread Rob Clark
On Thu, Jul 13, 2023 at 1:26 PM Akhil P Oommen wrote: > > On Fri, Jul 07, 2023 at 05:34:04AM +0300, Dmitry Baryshkov wrote: > > > > On 07/07/2023 00:10, Rob Clark wrote: > > > From: Rob Clark > > > > > > There are cases where there are differences due to SoC integration. > > > Such as cache-coher

Re: [Freedreno] [PATCH v4 04/17] dt-bindings: display/msm: Remove DSI1 ports from SM6350/SM6375 example

2023-07-26 Thread Rob Herring
On Sun, 23 Jul 2023 18:08:42 +0200, Marijn Suijten wrote: > Both SM6350 and SM6375 support only a single DSI link, and don't have a > corresponding dsi1 node in DTS. Their examples should not suggest an > output interface port on the display-controller node to this inexistant > DSI host, with a

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
On 26/07/2023 15:27, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > It fixes a kernel panic (arm-smmu: Unhandled context fault > at this particular memory region) reported on DB845c running > v5.10.y. > >

[Freedreno] [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Amit Pundir
Adding a reserved memory region for the framebuffer memory (the splash memory region set up by the bootloader). It fixes a kernel panic (arm-smmu: Unhandled context fault at this particular memory region) reported on DB845c running v5.10.y. Cc: sta...@vger.kernel.org # v5.10+ Reviewed-by: Caleb C

[Freedreno] [PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-26 Thread Amit Pundir
Add and document the reserved memory region property in the mdss-common schema. For now (sdm845-db845c), it points to a framebuffer memory region reserved by the bootloader for splash screen. Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring Signed-off-by: Amit Pundir --- v6: Re-sending w

Re: [Freedreno] [PATCH v5 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
On 13/07/2023 18:52, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > Signed-off-by: Amit Pundir > --- I think your commit msg misses describing the actual problem, impact to users and finally cc-stable. B

Re: [Freedreno] [PATCH v5 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-26 Thread Krzysztof Kozlowski
On 13/07/2023 18:52, Amit Pundir wrote: > Add and document the reserved memory region property in the > mdss-common schema. > > For now (sdm845-db845c), it points to a framebuffer memory > region reserved by the bootloader for splash screen. > > Signed-off-by: Amit Pundir > --- Acked-by: Krzysz

Re: [Freedreno] [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-26 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. What's the status wrt to this regression (caused by 8ddce13ae69 from Marek)? It looks like things are stalled and the regression still is unresolved, but I ask because I migh

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Marijn Suijten
On 2023-07-26 10:42:24, Dmitry Baryshkov wrote: > On 26/07/2023 10:31, Krzysztof Kozlowski wrote: > > On 26/07/2023 09:27, Krzysztof Kozlowski wrote: > >> On 25/07/2023 13:46, Marijn Suijten wrote: > >>> On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: > Example DTS should not have 'status'

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Dmitry Baryshkov
On 26/07/2023 10:31, Krzysztof Kozlowski wrote: On 26/07/2023 09:27, Krzysztof Kozlowski wrote: On 25/07/2023 13:46, Marijn Suijten wrote: On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: Example DTS should not have 'status' property. Signed-off-by: Krzysztof Kozlowski --- .../devicetree

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 26/07/2023 09:27, Krzysztof Kozlowski wrote: > On 25/07/2023 13:46, Marijn Suijten wrote: >> On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >>> Example DTS should not have 'status' property. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> .../devicetree/bindings/display/msm/qcom,sm6

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 25/07/2023 13:46, Marijn Suijten wrote: > On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >> Example DTS should not have 'status' property. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml | 6 -- > > This is not needed: it h