The msm_gem_get_vaddr() returns an ERR_PTR() on failure, and a null
is catastrophic here, so we should use IS_ERR_OR_NULL() to check
the return value.
Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl")
Signed-off-by: Gaosheng Cui
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kum
v6:
- Update the first patch, return dev_err_probe(...), Thanks!
v5:
- Update the third patch, change IS_ERR to IS_ERR_OR_NULL.
Thanks!
v4:
- 1. Update the second patch's commit messages.
2. Update the first patch, use dev_err_probe() instead of dev_err().
Thanks!
v3:
- Update the second
The komeda_pipeline_get_state() returns an ERR_PTR() on failure,
and a null is catastrophic here we should use IS_ERR_OR_NULL()
to check the return value.
Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE")
Signed-off-by: Gaosheng Cui
Reviewed-by: Liviu Dudau
---
drivers
The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
we should use IS_ERR() to check the return value.
By the way, use dev_err_probe instead of dev_err to print the error code.
Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC
panels")
Signed-off-by: Ga
From: Rob Clark
A fence id of zero is expected to be invalid, and is not removed from
the fence_idr table. If userspace is requesting to specify the fence
id with the FENCE_SN_IN flag, we need to reject a zero fence id value.
Fixes: 17154addc5c1 ("drm/msm: Add MSM_SUBMIT_FENCE_SN_IN")
Signed-of
Hi Rob,
A gentle ping.
On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov
wrote:
>
> On 21/06/2023 02:23, Fabio Estevam wrote:
> > From: Fabio Estevam
> >
> > The adreno_is_a20x() and adreno_is_a225() functions rely on the
> > GPU revision, but such information is retrieved inside adreno_gpu_init
Hi Gaosheng,
On Mon, Jul 24, 2023 at 10:00:34PM +0800, Gaosheng Cui wrote:
> The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
> we should use IS_ERR() to check the return value.
>
> By the way, use dev_err_probe instead of dev_err to print the error code.
>
> Fixes: 623a3531e9
If you're going to update the other patches to use IS_ERR_OR_NULL() please do so
here too. You can keep my R-b for that change.
Thanks for taking time to review the patch.
I have update the patch set and add this change to v5.
On 2023/7/21 18:24, Liviu Dudau wrote:
Hi Gaosheng,
On Fri, Jul 1
The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
we should use IS_ERR() to check the return value.
By the way, use dev_err_probe instead of dev_err to print the error code.
Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC
panels")
Signed-off-by: Ga
The komeda_pipeline_get_state() returns an ERR_PTR() on failure,
and a null is catastrophic here we should use IS_ERR_OR_NULL()
to check the return value.
Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE")
Signed-off-by: Gaosheng Cui
Reviewed-by: Liviu Dudau
---
drivers
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, and a null
is catastrophic here, so we should use IS_ERR_OR_NULL() to check
the return value.
Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl")
Signed-off-by: Gaosheng Cui
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kum
v5:
- Update the third patch, change IS_ERR to IS_ERR_OR_NULL.
Thanks!
v4:
- 1. Update the second patch's commit messages.
2. Update the first patch, use dev_err_probe() instead of dev_err().
Thanks!
v3:
- Update the second patch:
1. change IS_ERR to IS_ERR_OR_NULL
2. add Dmitry's R-b
On 22/07/2023 05:49, Bjorn Andersson wrote:
On Tue, Jul 18, 2023 at 09:09:41AM +0300, Dmitry Baryshkov wrote:
On 18/07/2023 07:37, Bjorn Andersson wrote:
On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote:
Implement DisplayPort support for the Qualcomm RB5 platform.
Note: while
13 matches
Mail list logo
