Re: [Freedreno] [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 7:20 PM, Dmitry Baryshkov wrote: On 03/07/2023 05:01, Abhinav Kumar wrote: On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: There is always a single MDP TOP block. Drop the mdp_count field and stop declaring dpu_mdp_cfg instances as arrays. Tested-by: Marijn Suijten Signed-off-b

[Freedreno] [PATCH v5 19/19] drm/msm/dpu: drop empty features mask INTF_SDM845_MASK

2023-07-03 Thread Dmitry Baryshkov
The INTF_SDM845_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 4 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_

[Freedreno] [PATCH v5 10/19] drm/msm/dpu: inline SSPP_BLK macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 18/19] drm/msm/dpu: drop empty features mask MERGE_3D_SM8150_MASK

2023-07-03 Thread Dmitry Baryshkov
The MERGE_3D_SM8150_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 3 --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_

[Freedreno] [PATCH v5 16/19] drm/msm/dpu: inline WB_BLK macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 17/19] drm/msm/dpu: inline INTF_BLK and INTF_BLK_DSI_TE macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 09/19] drm/msm/dpu: correct indentation for CTL definitions

2023-07-03 Thread Dmitry Baryshkov
Shift dpu_ctl_cfg contents to correct the indentation of CTL blocks. This is done in preparation to expanding the rest of hardware block defines, so that all blocks have similar indentation. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry B

[Freedreno] [PATCH v5 15/19] drm/msm/dpu: inline various PP_BLK_* macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 07/19] drm/msm/dpu: drop zero features from dpu_mdp_cfg data

2023-07-03 Thread Dmitry Baryshkov
Drop useless zero assignments to the dpu_mdp_cfg::features field. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h | 1 - drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_2_s

[Freedreno] [PATCH v5 13/19] drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 9 - ..

[Freedreno] [PATCH v5 06/19] drm/msm/dpu: expand .clk_ctrls definitions

2023-07-03 Thread Dmitry Baryshkov
Use more standard initialisation for .clk_ctrls definitions. Define a single .clk_ctrls field and use array init inside. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 22

[Freedreno] [PATCH v5 08/19] drm/msm/dpu: drop zero features from dpu_ctl_cfg data

2023-07-03 Thread Dmitry Baryshkov
Drop useless zero assignments to the dpu_ctl_cfg::features field. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 3 --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0

[Freedreno] [PATCH v5 12/19] drm/msm/dpu: inline LM_BLK macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 11/19] drm/msm/dpu: inline DSPP_BLK macros

2023-07-03 Thread Dmitry Baryshkov
To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- ...

[Freedreno] [PATCH v5 05/19] drm/msm/dpu: drop enum dpu_mdp and MDP_TOP value

2023-07-03 Thread Dmitry Baryshkov
Since there is always just a single MDP_TOP instance, drop the enum dpu_mdp and corresponding index value. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 2 +- driv

[Freedreno] [PATCH v5 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

2023-07-03 Thread Dmitry Baryshkov
There is always a single MDP TOP block. Drop the mdp_count field and stop declaring dpu_mdp_cfg instances as arrays. Tested-by: Marijn Suijten Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 7 ++-- .../msm/disp/dpu1/catalog/dpu_

[Freedreno] [PATCH v5 02/19] drm/msm/dpu: always use MSM_DP/DSI_CONTROLLER_n

2023-07-03 Thread Dmitry Baryshkov
In several catalog entries we did not use existing MSM_DP_CONTROLLER_n constants. Fill them in. Also use freshly defined MSM_DSI_CONTROLLER_n for DSI interfaces. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

[Freedreno] [PATCH v5 03/19] drm/msm/dpu: simplify peer LM handling

2023-07-03 Thread Dmitry Baryshkov
For each LM there is at max 1 peer LM. Thus there is no need to have a mask for the peer LM enumeration. Change that to have an ID of the peer LM. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 2 +- ..

[Freedreno] [PATCH v5 01/19] drm/msm: enumerate DSI interfaces

2023-07-03 Thread Dmitry Baryshkov
Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration. Reviewed-by: Abhinav Kumar Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/driv

[Freedreno] [PATCH v5 00/19] drm/msm/dpu: another catalog rework

2023-07-03 Thread Dmitry Baryshkov
Having a macro with 10 arguments doesn't seem like a good idea. It makes it inherently harder to compare the actual structure values. Also this leads to adding macros covering varieties of the block. As it was previously discussed, inline all foo_BLK macros in order to ease performing changes to t

Re: [Freedreno] [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

2023-07-03 Thread Dmitry Baryshkov
On 03/07/2023 05:01, Abhinav Kumar wrote: On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: There is always a single MDP TOP block. Drop the mdp_count field and stop declaring dpu_mdp_cfg instances as arrays. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- The change drops mdp_c

Re: [Freedreno] [PATCH 6/8] drm/msm/dpu: use dpu_perf_cfg in DPU core_perf code

2023-07-03 Thread Abhinav Kumar
On 6/20/2023 4:31 AM, Konrad Dybcio wrote: On 20.06.2023 13:18, Dmitry Baryshkov wrote: On 20/06/2023 13:55, Konrad Dybcio wrote: On 20.06.2023 02:08, Dmitry Baryshkov wrote: Simplify dpu_core_perf code by using only dpu_perf_cfg instead of using full-featured catalog data. Signed-off-by:

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 5:28 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 02:16, Abhinav Kumar wrote: On 7/3/2023 4:01 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:55, Abhinav Kumar wrote: On 7/3/2023 3:53 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar wro

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 02:16, Abhinav Kumar wrote: > > > > On 7/3/2023 4:01 PM, Dmitry Baryshkov wrote: > > On Tue, 4 Jul 2023 at 01:55, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 7/3/2023 3:53 PM, Dmitry Baryshkov wrote: > >>> On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar > >>> wrote: >

Re: [Freedreno] [PATCH 8/8] drm/msm/dpu: remove unused fields from struct dpu_core_perf

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: Remove dpu_core_perf::dev and dpu_core_perf::debugfs_root fields, they are not used by the code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 -- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4

Re: [Freedreno] [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 01:59, Mark Brown wrote: > > On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > > > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > > responsible for providing a reference voltage to some on-SoC IPs (like DSI > > or PHYs). It can be

Re: [Freedreno] [PATCH 7/8] drm/msm/dpu: drop dpu_core_perf_destroy()

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 3:59 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:57, Abhinav Kumar wrote: On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: This function does nothing, just clears several data pointers. Drop it now. This will undo what dpu_core_perf_init() did when an error happens.

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 4:01 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:55, Abhinav Kumar wrote: On 7/3/2023 3:53 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar wrote: On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: The stop_req is true only in the dpu_crtc_disa

Re: [Freedreno] [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Konrad Dybcio
On 4.07.2023 00:59, Mark Brown wrote: > On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > >> Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator >> responsible for providing a reference voltage to some on-SoC IPs (like DSI >> or PHYs). It can be turned off whe

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 01:55, Abhinav Kumar wrote: > > > > On 7/3/2023 3:53 PM, Dmitry Baryshkov wrote: > > On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > >>> The stop_req is true only in the dpu_crtc_disable() case, when

Re: [Freedreno] [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Mark Brown
On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series intr

Re: [Freedreno] [PATCH 7/8] drm/msm/dpu: drop dpu_core_perf_destroy()

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 01:57, Abhinav Kumar wrote: > > > > On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > > This function does nothing, just clears several data pointers. Drop it > > now. > > > > This will undo what dpu_core_perf_init() did when an error happens. > > Why can we drop that? Because

Re: [Freedreno] [PATCH 7/8] drm/msm/dpu: drop dpu_core_perf_destroy()

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: This function does nothing, just clears several data pointers. Drop it now. This will undo what dpu_core_perf_init() did when an error happens. Why can we drop that? Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_cor

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 3:53 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar wrote: On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: The stop_req is true only in the dpu_crtc_disable() case, when crtc->enable has already been set to false. This renders the stop_req argument usele

Re: [Freedreno] [PATCH v3 4/4] drm/msm/dsi: Hook up refgen regulator

2023-07-03 Thread Dmitry Baryshkov
On Mon, 3 Jul 2023 at 21:16, Konrad Dybcio wrote: > > Consume the refgen supply on configurations that may use it. > > Signed-off-by: Konrad Dybcio Reviewed--by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ > 1 file changed, 2 insertions(+) -- With best wishes Dmitry

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 01:37, Abhinav Kumar wrote: > > > > On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > > The stop_req is true only in the dpu_crtc_disable() case, when > > crtc->enable has already been set to false. This renders the stop_req > > argument useless. Remove it completely. > > > > W

Re: [Freedreno] [PATCH 5/8] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: The stop_req is true only in the dpu_crtc_disable() case, when crtc->enable has already been set to false. This renders the stop_req argument useless. Remove it completely. What about the enable case? That time dpu_crtc->enabled will be false

Re: [Freedreno] [PATCH 2/8] drm/msm/dpu: drop performance tuning modes

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 01:26, Abhinav Kumar wrote: > > > > On 7/3/2023 3:20 PM, Dmitry Baryshkov wrote: > > On Tue, 4 Jul 2023 at 00:40, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > >>> DPU performance module contains code to change performance stat

Re: [Freedreno] [PATCH 2/8] drm/msm/dpu: drop performance tuning modes

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 3:20 PM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 00:40, Abhinav Kumar wrote: On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: DPU performance module contains code to change performance state calculations. In addition to normal (sum plane and CRTC requirements), it can work

Re: [Freedreno] [PATCH 2/8] drm/msm/dpu: drop performance tuning modes

2023-07-03 Thread Dmitry Baryshkov
On Tue, 4 Jul 2023 at 00:40, Abhinav Kumar wrote: > > > > On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > > DPU performance module contains code to change performance state > > calculations. In addition to normal (sum plane and CRTC requirements), > > it can work in 'minimal' or 'fixed' modes. Bot

Re: [Freedreno] [PATCH 4/8] drm/msm/dpu: rework indentation in dpu_core_perf

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: dpu_core_perf.c contains several multi-line conditions which are hard to comprehent because of the indentation. Rework the identation of these conditions to make it easier to understand them. Signed-off-by: Dmitry Baryshkov --- I think some of

Re: [Freedreno] [PATCH 3/8] drm/msm/dpu: drop dpu_core_perf_params::max_per_pipe_ib

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: The max_per_pipe_ib is a constant across all CRTCs and is read from the catalog. Drop corresponding calculations and read the value directly at icc_set_bw() time. Suggested-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- This will need t

Re: [Freedreno] [PATCH 2/8] drm/msm/dpu: drop performance tuning modes

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: DPU performance module contains code to change performance state calculations. In addition to normal (sum plane and CRTC requirements), it can work in 'minimal' or 'fixed' modes. Both modes are impractical, since they can easily end up with the dis

Re: [Freedreno] [PATCH 1/8] drm/msm/dpu: drop enum dpu_core_perf_data_bus_id

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: Drop the leftover of bus-client -> interconnect conversion, the enum dpu_core_perf_data_bus_id. Fixes: cb88482e2570 ("drm/msm/dpu: clean up references of DPU custom bus scaling") Signed-off-by: Dmitry Baryshkov --- It seems unused, hence Revi

Re: [Freedreno] [PATCH v4 19/19] drm/msm/dpu: drop empty features mask INTF_SDM845_MASK

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: The INTF_SDM845_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 4 drivers/gpu/drm/msm/d

Re: [Freedreno] [PATCH v4 18/19] drm/msm/dpu: drop empty features mask MERGE_3D_SM8150_MASK

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: The MERGE_3D_SM8150_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH v4 17/19] drm/msm/dpu: inline INTF_BLK and INTF_BLK_DSI_TE macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [Freedreno] [PATCH v4 16/19] drm/msm/dpu: inline WB_BLK macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [Freedreno] [PATCH v4 15/19] drm/msm/dpu: inline various PP_BLK_* macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [Freedreno] [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

2023-07-03 Thread Abhinav Kumar
On 7/3/2023 1:58 PM, Dmitry Baryshkov wrote: On Mon, 3 Jul 2023 at 23:29, Abhinav Kumar wrote: On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and vis

Re: [Freedreno] [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

2023-07-03 Thread Dmitry Baryshkov
On Mon, 3 Jul 2023 at 23:29, Abhinav Kumar wrote: > > > > On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: > > To simplify making changes to the hardware block definitions, expand > > corresponding macros. This way making all the changes are more obvious > > and visible in the source files. > > > > T

Re: [Freedreno] [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- the valu

Re: [Freedreno] [PATCH v4 13/19] drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros

2023-07-03 Thread Abhinav Kumar
On 6/27/2023 1:29 AM, Marijn Suijten wrote: On 2023-06-20 00:25:13, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten

Re: [Freedreno] [PATCH v4 12/19] drm/msm/dpu: inline LM_BLK macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Same com

Re: [Freedreno] [PATCH v3 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

2023-07-03 Thread Konrad Dybcio
On 3.07.2023 20:15, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Signed-off-by: Konrad Dyb

[Freedreno] [PATCH v3 3/4] dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply

2023-07-03 Thread Konrad Dybcio
DSI host needs REFGEN to be enabled (if it's present on a given platform). Allow consuming it. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devi

[Freedreno] [PATCH v3 4/4] drm/msm/dsi: Hook up refgen regulator

2023-07-03 Thread Konrad Dybcio
Consume the refgen supply on configurations that may use it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 8a5fb6df7210..1f98ff74ceb0 100644 ---

[Freedreno] [PATCH v3 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-07-03 Thread Konrad Dybcio
Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. Add a driver to support toggling that regulator. Signed-off-by: Konrad Dybcio --- drivers/regulator/Kconfig | 11 +++ drivers/regulator/Makefile

[Freedreno] [PATCH v3 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

2023-07-03 Thread Konrad Dybcio
Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. It's controlled through MMIO and we can toggle it or read its state back. Describe it. Signed-off-by: Konrad Dybcio --- .../regulator/qcom,sdm845-refgen-regulator.ya

[Freedreno] [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Konrad Dybcio
Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator responsible for providing a reference voltage to some on-SoC IPs (like DSI or PHYs). It can be turned off when unused to save power. This series introduces the driver for it and lets the DSI driver consume it. Signed-off-b

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Conor Dooley
On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [Freedreno] [PATCH v4 11/19] drm/msm/dpu: inline DSPP_BLK macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [Freedreno] [PATCH v4 10/19] drm/msm/dpu: inline SSPP_BLK macros

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- I checke

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Mathieu Poirier
On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bin

Re: [Freedreno] [PATCH v4 09/19] drm/msm/dpu: correct indentation for CTL definitions

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: Shift dpu_ctl_cfg contents to correct the indentation of CTL blocks. This is done in preparation to expanding the rest of hardware block defines, so that all blocks have similar indentation. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten

Re: [Freedreno] [PATCH v4 08/19] drm/msm/dpu: drop zero features from dpu_ctl_cfg data

2023-07-03 Thread Abhinav Kumar
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: Drop useless zero assignments to the dpu_ctl_cfg::features field. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Neil Armstrong
On 02/07/2023 20:23, Krzysztof Kozlowski wrote: The DTS code coding style expects spaces around '=' sign. Signed-off-by: Krzysztof Kozlowski --- Rob, Maybe this could go via your tree? Rebased on your for-next: v6.4-rc2-45-gf0ac35049606 --- .../bindings/arm/arm,coresight-cti.yaml|

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Jonathan Cameron
On Sun, 2 Jul 2023 20:23:08 +0200 Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > For the IIO one. Acked-by: Jonathan Cameron Thanks for tidying these up. Jonathan > --- > > Rob, > > Maybe this could go via

Re: [Freedreno] [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-03 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 11:27 PM Jessica Zhang wrote: > > > > On 6/30/2023 7:43 AM, Sebastian Wick wrote: > > On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >> documentation. > >> > >> This enum property will al

Re: [Freedreno] [PATCH v2 08/15] drm/msm/hdmi: move the alt_iface clock to the hpd list

2023-07-03 Thread Konrad Dybcio
On 25.06.2023 13:42, Dmitry Baryshkov wrote: > According to the vendor kernel [1] , the alt_iface clock should be > enabled together with the rest of HPD clocks, to make HPD to work > properly. > > [1] > https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/commit/e07a5487e521e57f76083c0a6e2f995414

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Mike Leach
On Sun, 2 Jul 2023 at 19:23, Krzysztof Kozlowski wrote: > > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bindings/arm/arm,

Re: [Freedreno] [PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property

2023-07-03 Thread Pekka Paalanen
On Fri, 30 Jun 2023 11:26:49 +0300 Pekka Paalanen wrote: > On Thu, 29 Jun 2023 17:25:06 -0700 > Jessica Zhang wrote: > > > Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to > > determine if the plane is solid fill. In addition drop the DPU plane > > color_fill field as we