Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 3:52 PM, Marijn Suijten wrote: On 2023-04-14 14:03:23, Abhinav Kumar wrote: [..] Yes, ofcourse git send-email was used to send the patch, not any other mail client. Yes i am also aware that send-email converts rb to CC. But if you keep working on the local branch, then you woul

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 3:53 PM, Dmitry Baryshkov wrote: On Sat, 15 Apr 2023 at 00:03, Abhinav Kumar wrote: On 4/14/2023 1:58 PM, Dmitry Baryshkov wrote: On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar wrote: On 4/14/2023 10:28 AM, Marijn Suijten wrote: On 2023-04-14 08:41:37, Abhinav Kumar wrote

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 4:11 PM, Marijn Suijten wrote: On 2023-04-14 10:57:45, Abhinav Kumar wrote: On 4/14/2023 10:34 AM, Marijn Suijten wrote: On 2023-04-14 08:48:43, Abhinav Kumar wrote: On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 10:57:45, Abhinav Kumar wrote: > On 4/14/2023 10:34 AM, Marijn Suijten wrote: > > On 2023-04-14 08:48:43, Abhinav Kumar wrote: > >> On 4/14/2023 12:35 AM, Marijn Suijten wrote: > >>> On 2023-04-12 10:33:15, Abhinav Kumar wrote: > >>> [..] > > What happens if a device boots without

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 09:46:17, Kuogee Hsieh wrote: > In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send the wrong patch as the improvements from v2 are missing? > However, for displays which are hot-pluggable, there

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Dmitry Baryshkov
On Sat, 15 Apr 2023 at 00:03, Abhinav Kumar wrote: > > > > On 4/14/2023 1:58 PM, Dmitry Baryshkov wrote: > > On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/14/2023 10:28 AM, Marijn Suijten wrote: > >>> On 2023-04-14 08:41:37, Abhinav Kumar wrote: > > On

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 14:03:23, Abhinav Kumar wrote: [..] > >> Yes, ofcourse git send-email was used to send the patch, not any other > >> mail client. > >> > >> Yes i am also aware that send-email converts rb to CC. > >> > >> But if you keep working on the local branch, then you would have to > >> manuall

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 1:58 PM, Dmitry Baryshkov wrote: On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar wrote: On 4/14/2023 10:28 AM, Marijn Suijten wrote: On 2023-04-14 08:41:37, Abhinav Kumar wrote: On 4/14/2023 12:48 AM, Marijn Suijten wrote: Capitalize DSC in the title, as discussed in v1. On

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Dmitry Baryshkov
On Fri, 14 Apr 2023 at 19:46, Kuogee Hsieh wrote: > > In current code, the dsc active bits are set only if the cfg->dsc is set. > However, for displays which are hot-pluggable, there can be a use-case > of disconnecting a DSC supported sink and connecting a non-DSC sink. > > For those cases we nee

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Dmitry Baryshkov
On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar wrote: > > > > On 4/14/2023 10:28 AM, Marijn Suijten wrote: > > On 2023-04-14 08:41:37, Abhinav Kumar wrote: > >> > >> On 4/14/2023 12:48 AM, Marijn Suijten wrote: > >>> Capitalize DSC in the title, as discussed in v1. > >>> > >>> On 2023-04-13 08:56:41,

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 11:55 AM, Abhinav Kumar wrote: On 4/14/2023 10:28 AM, Marijn Suijten wrote: On 2023-04-14 08:41:37, Abhinav Kumar wrote: On 4/14/2023 12:48 AM, Marijn Suijten wrote: Capitalize DSC in the title, as discussed in v1. On 2023-04-13 08:56:41, Kuogee Hsieh wrote: In current code

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 10:28 AM, Marijn Suijten wrote: On 2023-04-14 08:41:37, Abhinav Kumar wrote: On 4/14/2023 12:48 AM, Marijn Suijten wrote: Capitalize DSC in the title, as discussed in v1. On 2023-04-13 08:56:41, Kuogee Hsieh wrote: In current code, the DSC active bits are written only if cfg-

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 10:34 AM, Marijn Suijten wrote: On 2023-04-14 08:48:43, Abhinav Kumar wrote: On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if a device boots without DSC panel connected? Will CTL_DSC_FLUSH be zero and not (unnecess

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 08:48:43, Abhinav Kumar wrote: > > On 4/14/2023 12:35 AM, Marijn Suijten wrote: > > On 2023-04-12 10:33:15, Abhinav Kumar wrote: > > [..] > >>> What happens if a device boots without DSC panel connected? Will > >>> CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 08:41:37, Abhinav Kumar wrote: > > On 4/14/2023 12:48 AM, Marijn Suijten wrote: > > Capitalize DSC in the title, as discussed in v1. > > > > On 2023-04-13 08:56:41, Kuogee Hsieh wrote: > >> In current code, the DSC active bits are written only if cfg->dsc is set. > >> However, for d

[Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Kuogee Hsieh
In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC active bits during teardown. As discuss at [1]

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 12:35 AM, Marijn Suijten wrote: On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] What happens if a device boots without DSC panel connected? Will CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of the DSC blocks? Or could this flush uninitialized state to the

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Abhinav Kumar
On 4/14/2023 12:48 AM, Marijn Suijten wrote: Capitalize DSC in the title, as discussed in v1. On 2023-04-13 08:56:41, Kuogee Hsieh wrote: In current code, the DSC active bits are written only if cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of discon

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-14 Thread Rob Clark
On Fri, Apr 14, 2023 at 1:57 AM Tvrtko Ursulin wrote: > > > On 13/04/2023 21:05, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: > >> > >> On 13/04/2023 14:27, Daniel Vetter wrote: > >>> On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: >

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-14 Thread Tvrtko Ursulin
On 14/04/2023 10:07, Daniel Vetter wrote: On Fri, 14 Apr 2023 at 10:57, Tvrtko Ursulin wrote: On 13/04/2023 21:05, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: On 13/04/2023 14:27, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtk

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-14 Thread Daniel Vetter
On Fri, 14 Apr 2023 at 10:57, Tvrtko Ursulin wrote: > On 13/04/2023 21:05, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: > >> > >> On 13/04/2023 14:27, Daniel Vetter wrote: > >>> On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > >>>

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-14 Thread Tvrtko Ursulin
On 13/04/2023 21:05, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: On 13/04/2023 14:27, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM

Re: [Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
Capitalize DSC in the title, as discussed in v1. On 2023-04-13 08:56:41, Kuogee Hsieh wrote: > In current code, the DSC active bits are written only if cfg->dsc is set. > However, for displays which are hot-pluggable, there can be a use-case > of disconnecting a DSC supported sink and connecting a

Re: [Freedreno] [PATCH] drm/msm/dpu: always program dsc active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-12 10:33:15, Abhinav Kumar wrote: [..] > > What happens if a device boots without DSC panel connected? Will > > CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of the > > DSC blocks? Or could this flush uninitialized state to the block? > > > > If we bootup without