Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: > > On 13/04/2023 14:27, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > > > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 9:40 AM Tvrtko Ursulin wrote: > > > On 13/04/2023 14:27, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > >> > >> On 12/04/2023 20:18, Daniel Vetter wrote: > >>> On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > On W

Re: [Freedreno] [PATCH v4 08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-04-13 Thread Kandpal, Suraj
Hi, > Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. > Looks Good to me Reviewed-by: Suraj Kandpal > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 438 > +++ > include/drm/display/drm_dsc_helper.h | 2 + > 2 files

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Alex Deucher
On Wed, Apr 12, 2023 at 10:42 AM Tvrtko Ursulin wrote: > > > On 11/04/2023 23:56, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: Do it in core > > > > Signed-off-by: Rob Clark > > R

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 14:27, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: On Wed, Apr 12, 2023 at 10:

[Freedreno] [PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-13 Thread Kuogee Hsieh
In current code, the DSC active bits are written only if cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC active bits during tear down. Changes in V2: 1

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 5:58 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > >> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > >>> > >>> On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: >

Re: [Freedreno] [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 6:07 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 23:42, Rob Clark wrote: > > From: Rob Clark > > There is more do to here to remove my client->id fully (would now be > dead code) so maybe easiest if you drop this patch and I do it after you > land this and it propagates t

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > > > On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > > > > > > > > On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob C

Re: [Freedreno] [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 23:42, Rob Clark wrote: From: Rob Clark There is more do to here to remove my client->id fully (would now be dead code) so maybe easiest if you drop this patch and I do it after you land this and it propagates to our branches? I'd like to avoid pain with conflicts if possibl

Re: [Freedreno] [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 09:46, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [Freedreno] [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin wrote: On 11/04/2023 23:5

Re: [Freedreno] [PATCH v4 3/6] drm/amdgpu: Switch to fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +-

Re: [Freedreno] [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 10:46 schrieb Daniel Vetter: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [Freedreno] [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: > Am 13.04.23 um 00:42 schrieb Rob Clark: > > From: Rob Clark > > > > Handle a bit of the boiler-plate in a single case, and make it easier to > > add some core tracked stats. > > > > v2: Update drm-usage-stats.rst, 64b client-id,

Re: [Freedreno] [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark --- Docum