Re: [Freedreno] [PATCH v3 21/27] drm/msm/dpu: simplify dpu_plane_validate_src()

2023-02-06 Thread Abhinav Kumar
On 2/6/2023 4:27 PM, Dmitry Baryshkov wrote: On 07/02/2023 00:40, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Since the driver uses clipped src coordinates, there is no need to check against the fb coordinates. Remove corresponding checks and inline dpu_plane_validat

Re: [Freedreno] [PATCH v3 21/27] drm/msm/dpu: simplify dpu_plane_validate_src()

2023-02-06 Thread Dmitry Baryshkov
On 07/02/2023 00:40, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Since the driver uses clipped src coordinates, there is no need to check against the fb coordinates. Remove corresponding checks and inline dpu_plane_validate_src(). Signed-off-by: Dmitry Baryshkov Can

Re: [Freedreno] [PATCH v3 22/27] drm/msm/dpu: rework dpu_plane_sspp_atomic_update()

2023-02-06 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the sspp-dependent? separate function dpu_plane_sspp_update_pipe(). This is one of preparational steps to add r_pipe support. Signed-off-by: Dmitry Baryshkov Just a couple o

Re: [Freedreno] [PATCH v3 21/27] drm/msm/dpu: simplify dpu_plane_validate_src()

2023-02-06 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Since the driver uses clipped src coordinates, there is no need to check against the fb coordinates. Remove corresponding checks and inline dpu_plane_validate_src(). Signed-off-by: Dmitry Baryshkov Can you please explain how the clipping in dr

Re: [Freedreno] [PATCH v2 2/8] dt-bindings: power: qcom, rpmpd: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 15:57, Dmitry Baryshkov wrote: > Add define for another power saving state used on SM8350 for the GPU. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > include/dt-bindings/power/qcom-rpmpd.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

Re: [Freedreno] [PATCH v3 20/27] drm/msm/dpu: add dpu_hw_pipe_cfg to dpu_plane_state

2023-02-06 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Now as all accesses to pipe_cfg and pstate have been cleaned, re-add struct dpu_hw_pipe_cfg back to dpu_plane_state, so that dpu_plane_atomic_check() and dpu_plane_atomic_update() do not have a chance to disagree about src/dst rectangles (currently

Re: [Freedreno] [PATCH v3 19/27] drm/msm/dpu: make _dpu_plane_calc_clk accept mode directly

2023-02-06 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework bandwidth/clock calculation functions to use mode directly rather than fetching it through the plane data. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 39 ++-

Re: [Freedreno] [PATCH 06/14] drm/msm/gpu: Use dev_pm_opp_set_rate for non-GMU GPUs

2023-02-06 Thread Konrad Dybcio
On 26.01.2023 16:16, Konrad Dybcio wrote: > Currently we only utilize the OPP table connected to the GPU for > getting (available) frequencies. We do however need to scale the > voltage rail(s) accordingly to ensure that we aren't trying to > run the GPU at 1GHz with a VDD_LOW vote, as that woul

Re: [Freedreno] [PATCH 3/8] dt-bindings: display/msm/gmu: add Adreno 660 support

2023-02-06 Thread Rob Herring
On Mon, 06 Feb 2023 02:27:30 +0200, Dmitry Baryshkov wrote: > Add Adreno A660 to the A635 clause to define all version-specific > properties. There is no need to add it to the top-level clause, since > top-level compatible uses pattern to define compatible strings. > > Signed-off-by: Dmitry Bary

Re: [Freedreno] [PATCH 1/8] dt-bindings: clock: Merge qcom, gpucc-sm8350 into qcom, gpucc.yaml

2023-02-06 Thread Rob Herring
On Mon, 06 Feb 2023 02:27:27 +0200, Dmitry Baryshkov wrote: > The GPU clock controller bindings for the Qualcomm sm8350 platform are > not correct. The driver uses .fw_name instead of using indices to bind > parent clocks, thus demanding the clock-names usage. With the proper > clock-names in pla

[Freedreno] [PATCH v2 7/8] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-06 Thread Dmitry Baryshkov
Add device nodes required to enable GPU on the SM8350 platform. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 178 +++ 1 file changed, 178 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi

[Freedreno] [PATCH v2 8/8] arm64: dts: qcom: sm8350-hdk: enable GPU

2023-02-06 Thread Dmitry Baryshkov
Enable the GPU on the SM8350-HDK device. The ZAP shader is required for the GPU to function properly. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot

[Freedreno] [PATCH v2 6/8] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-06 Thread Dmitry Baryshkov
Finish reordering DT nodes. Move PDC, tsens, AOSS, SRAM, SPMI and TLMM nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 764 +-- 1 file changed, 382 insertions(+), 382 deletions(-) diff --git a/arch/arm64/boot/dts/q

[Freedreno] [PATCH v2 3/8] dt-bindings: display/msm/gmu: add Adreno 660 support

2023-02-06 Thread Dmitry Baryshkov
Add Adreno A660 to the A635 clause to define all version-specific properties. There is no need to add it to the top-level clause, since top-level compatible uses pattern to define compatible strings. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 +

[Freedreno] [PATCH v2 5/8] arm64: dts: qcom: sm8350: move more nodes to correct place

2023-02-06 Thread Dmitry Baryshkov
Continue ordering DT nodes. Move RNG, UFS, system NoC and SLPI nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 314 +-- 1 file changed, 157 insertions(+), 157 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm83

[Freedreno] [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-06 Thread Dmitry Baryshkov
Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper position at the end of /soc/. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 1228 +- 1 file changed,

[Freedreno] [PATCH v2 2/8] dt-bindings: power: qcom, rpmpd: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Dmitry Baryshkov
Add define for another power saving state used on SM8350 for the GPU. Signed-off-by: Dmitry Baryshkov --- include/dt-bindings/power/qcom-rpmpd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h index 4a30d10e6b7d

[Freedreno] [PATCH v2 1/8] dt-bindings: clock: Merge qcom, gpucc-sm8350 into qcom, gpucc.yaml

2023-02-06 Thread Dmitry Baryshkov
The GPU clock controller bindings for the Qualcomm sm8350 platform are not correct. The driver uses .fw_name instead of using indices to bind parent clocks, thus demanding the clock-names usage. With the proper clock-names in place, the bindings becomes equal to the bindings defined by qcom,gpucc.y

[Freedreno] [PATCH v2 0/8] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-06 Thread Dmitry Baryshkov
Add A660 device to the Qualcomm SM8350 platform and enable it for the sm8350-hdk board. Unfortunately while adding the GPU & related devices I noticed that DT nodes on SM8350 are greatly out of the preagreed order, so patches 4-6 reorder DT nodes to follow the agreement. Changes since v1: - Fixed

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 12:51, Konrad Dybcio wrote: On 6.02.2023 01:27, Dmitry Baryshkov wrote: Add device nodes required to enable GPU on the SM8350 platform. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 179 +++ 1 file changed, 179 insertions(

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8350: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 13:23, Konrad Dybcio wrote: On 6.02.2023 12:22, Dmitry Baryshkov wrote: On 06/02/2023 12:44, Konrad Dybcio wrote: On 6.02.2023 01:27, Dmitry Baryshkov wrote: Add another power saving state used on SM8350. Signed-off-by: Dmitry Baryshkov ---   include/dt-bindings/power/qcom

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 14:36, Neil Armstrong wrote: On 06/02/2023 12:20, Dmitry Baryshkov wrote: On 06/02/2023 12:33, Krzysztof Kozlowski wrote: On 06/02/2023 11:17, Neil Armstrong wrote: The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Neil Armstrong
On 06/02/2023 12:20, Dmitry Baryshkov wrote: On 06/02/2023 12:33, Krzysztof Kozlowski wrote: On 06/02/2023 11:17, Neil Armstrong wrote: The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-by: Neil Armstrong ---   Documentation/devi

Re: [Freedreno] [PATCH 4/5] arm64: dst: qcom: sm8450: switch to usb3/dp combo phy

2023-02-06 Thread Neil Armstrong
On 06/02/2023 12:03, Konrad Dybcio wrote: subject: s/dst/dts here and in 5/5 On 6.02.2023 11:17, Neil Armstrong wrote: The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arc

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8350: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 12:22, Dmitry Baryshkov wrote: > On 06/02/2023 12:44, Konrad Dybcio wrote: >> >> >> On 6.02.2023 01:27, Dmitry Baryshkov wrote: >>> Add another power saving state used on SM8350. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>>   include/dt-bindings/power/qcom-rpmpd.h | 1 + >> W

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8350: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 12:44, Konrad Dybcio wrote: On 6.02.2023 01:27, Dmitry Baryshkov wrote: Add another power saving state used on SM8350. Signed-off-by: Dmitry Baryshkov --- include/dt-bindings/power/qcom-rpmpd.h | 1 + Wrong patch? And this patch is correct. sm8350 GPU OPP table uses this va

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8450: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 12:44, Konrad Dybcio wrote: On 6.02.2023 01:27, Dmitry Baryshkov wrote: Add another power saving state used on SM8350. Signed-off-by: Dmitry Baryshkov --- include/dt-bindings/power/qcom-rpmpd.h | 1 + Wrong patch once more? This patch is wrong and was sent by mistake Kon

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Dmitry Baryshkov
On 06/02/2023 12:33, Krzysztof Kozlowski wrote: On 06/02/2023 11:17, Neil Armstrong wrote: The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml

Re: [Freedreno] [PATCH 4/5] arm64: dst: qcom: sm8450: switch to usb3/dp combo phy

2023-02-06 Thread Konrad Dybcio
subject: s/dst/dts here and in 5/5 On 6.02.2023 11:17, Neil Armstrong wrote: > The QMP PHY is a USB3/DP combo phy, switch to the newly > documented bindings and register the clocks to the GCC > and DISPCC controllers. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8450.dts

Re: [Freedreno] [PATCH 5/5] arm64: dst: qcom: sm8450: add dp controller

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 11:17, Neil Armstrong wrote: > Add the Display Port controller subnode to the MDSS node. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 +- > arch/arm64/boot/dts/qcom/sm8450.dtsi| 82 > +++-- > 2 files chang

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 01:27, Dmitry Baryshkov wrote: > Add device nodes required to enable GPU on the SM8350 platform. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 179 +++ > 1 file changed, 179 insertions(+) > > diff --git a/arch/arm64/bo

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8450: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 01:27, Dmitry Baryshkov wrote: > Add another power saving state used on SM8350. > > Signed-off-by: Dmitry Baryshkov > --- > include/dt-bindings/power/qcom-rpmpd.h | 1 + Wrong patch once more? Konrad > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/power/qc

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sm8350: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1

2023-02-06 Thread Konrad Dybcio
On 6.02.2023 01:27, Dmitry Baryshkov wrote: > Add another power saving state used on SM8350. > > Signed-off-by: Dmitry Baryshkov > --- > include/dt-bindings/power/qcom-rpmpd.h | 1 + Wrong patch? Konrad > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/power/qcom-rpmpd.h

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Krzysztof Kozlowski
On 06/02/2023 11:17, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 > 1 file changed, 4 insertion

[Freedreno] [PATCH 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-02-06 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 80 +++- 1 file changed, 78 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/q

[Freedreno] [PATCH 5/5] arm64: dst: qcom: sm8450: add dp controller

2023-02-06 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 +- arch/arm64/boot/dts/qcom/sm8450.dtsi| 82 +++-- 2 files changed, 82 insertions(+), 4 deletions(-) diff --git a/arch/arm64/

[Freedreno] [PATCH 4/5] arm64: dst: qcom: sm8450: switch to usb3/dp combo phy

2023-02-06 Thread Neil Armstrong
The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 38 +--- 1 file changed, 14 insertions(+), 24 deletions(

[Freedreno] [PATCH 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-02-06 Thread Neil Armstrong
The first QMP PHY is an USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 37 +--- 1 file changed, 13 insertions(+), 24 del

[Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-02-06 Thread Neil Armstrong
The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/disp

[Freedreno] [PATCH 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-02-06 Thread Neil Armstrong
; [3]. DT changes tying the DP controller to the USB-C port on the HDK boards will be sent later. Bindings dependencies at [1] [1] https://lore.kernel.org/all/20230206-topic-sm8350-upstream-usb-dp-combo-phy-v1-1-ed849ae6b...@linaro.org/ [2] https://lore.kernel.org/all/20230201041853.1934355-1-quic_b