Re: [Freedreno] [PATCH] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dan Carpenter
Hi Dmitry, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-another-fix-for-the-headless-Adreno-GPU/20221231-103022 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: ht

Re: [Freedreno] [PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Abhinav Kumar
On 1/4/2023 5:47 PM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU working in the headless mode (e.g. iMX platforms). Unable to handle kernel NULL pointer dereference at virtual address when read [] *pgd=74936831, *pte=000

Re: [Freedreno] [PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Rob Clark
On Wed, Jan 4, 2023 at 5:47 PM Dmitry Baryshkov wrote: > > Fix another oops reproducible when rebooting the board with the Adreno > GPU working in the headless mode (e.g. iMX platforms). > > Unable to handle kernel NULL pointer dereference at virtual address > when read > [] *pgd

Re: [Freedreno] [PATCH 2/6] dt-bindings: display/msm: document the display hardware for SM8550

2023-01-04 Thread Rob Herring
On Wed, 04 Jan 2023 10:08:44 +0100, Neil Armstrong wrote: > Document the MDSS and DPU blocks found on the Qualcomm SM8550 > platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + > .../bindings/display/msm/qcom,sm8550-mdss.yaml

Re: [Freedreno] [RFC PATCH v3 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2: -

Re: [Freedreno] [RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is formatted

Re: [Freedreno] [RFC PATCH v3 2/3] drm: Adjust atomic checks for solid fill color

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when soli

Re: [Freedreno] [RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is formatted

[Freedreno] [PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dmitry Baryshkov
Fix another oops reproducible when rebooting the board with the Adreno GPU working in the headless mode (e.g. iMX platforms). Unable to handle kernel NULL pointer dereference at virtual address when read [] *pgd=74936831, *pte=, *ppte= Internal error: Oops: 17 [#1

[Freedreno] [RFC PATCH v3 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-04 Thread Jessica Zhang
Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2: - Fixed dropped 'const' warning - Dropped use

[Freedreno] [RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Jessica Zhang
Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is formatted as such: struct drm_solid_fill { u

[Freedreno] [RFC PATCH v3 2/3] drm: Adjust atomic checks for solid fill color

2023-01-04 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when solid fill is enabled. Changes in V2: - Changed

[Freedreno] [RFC PATCH v3 0/3] Support for Solid Fill Planes

2023-01-04 Thread Jessica Zhang
Introduce and add support for a solid_fill property. When the solid_fill property is set, and the framebuffer is set to NULL, memory fetch will be disabled. In addition, loosen the NULL FB checks within the atomic commit callstack to allow a NULL FB when the solid_fill property is set and add FB c

Re: [Freedreno] [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 20:15, Rob Clark wrote: On Wed, Jan 4, 2023 at 10:09 AM Abhinav Kumar wrote: On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU wokring in the headless mode (e.g. iMX platforms). wokring ---> working Unabl

Re: [Freedreno] [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Rob Clark
On Wed, Jan 4, 2023 at 10:09 AM Abhinav Kumar wrote: > > > > On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: > > Fix another oops reproducible when rebooting the board with the Adreno > > GPU wokring in the headless mode (e.g. iMX platforms). > wokring ---> working > > > > Unable to handle kernel NUL

Re: [Freedreno] [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Abhinav Kumar
On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU wokring in the headless mode (e.g. iMX platforms). wokring ---> working Unable to handle kernel NULL pointer dereference at virtual address when read []

Re: [Freedreno] [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Dmitry Baryshkov
On Wed, 4 Jan 2023 at 12:08, Neil Armstrong wrote: > > On 04/01/2023 10:45, Dmitry Baryshkov wrote: > > On 04/01/2023 11:08, Neil Armstrong wrote: > >> Add definitions for the display hardware used on Qualcomm SM8550 > >> platform. > >> > >> Signed-off-by: Neil Armstrong > >> --- > >> drivers/g

Re: [Freedreno] [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Dmitry Baryshkov
On Wed, 4 Jan 2023 at 12:11, Neil Armstrong wrote: > > On 04/01/2023 10:53, Dmitry Baryshkov wrote: > > On 04/01/2023 11:08, Neil Armstrong wrote: > >> SM8550 use a 4nm DSI PHYs, which share register definitions > >> with 7nm DSI PHYs. Rather than duplicating the driver, handle > >> 4nm variant in

Re: [Freedreno] [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Neil Armstrong
On 04/01/2023 10:53, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong ---   driv

Re: [Freedreno] [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Neil Armstrong
On 04/01/2023 10:45, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong ---   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 +   drivers/gpu/dr

Re: [Freedreno] [PATCH 6/6] drm/msm/dsi: add support for DSI 2.7.0

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 11:08, Neil Armstrong wrote: Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) Reviewed-by: Dmitry Baryshko

Re: [Freedreno] [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 11:08, Neil Armstrong wrote: SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +-

Re: [Freedreno] [PATCH 4/6] drm/msm: mdss: add support for SM8550

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 11:08, Neil Armstrong wrote: Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu

Re: [Freedreno] [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 11:08, Neil Armstrong wrote: Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + dri

Re: [Freedreno] [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 02:29, Rob Herring wrote: On Fri, Dec 23, 2022 at 02:10:14AM +, Bryan O'Donoghue wrote: Add the list of current compats absent the deprecated qcm2290 to the list of dsi compats listed here. Several MDSS yaml files exist which document the dsi sub-node. For each existing SoC MD

[Freedreno] [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

[Freedreno] [PATCH 6/6] drm/msm/dsi: add support for DSI 2.7.0

2023-01-04 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_

[Freedreno] [PATCH 4/6] drm/msm: mdss: add support for SM8550

2023-01-04 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 144c8dd82be1..54483fe30ffd 100644 --- a/drivers/gpu/drm/

[Freedreno] [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h|

[Freedreno] [PATCH 2/6] dt-bindings: display/msm: document the display hardware for SM8550

2023-01-04 Thread Neil Armstrong
Document the MDSS and DPU blocks found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 2 files changed, 465 insertions(+) diff -

[Freedreno] [PATCH 1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-04 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

[Freedreno] [PATCH 0/6] drm/msm: add support for SM8450

2023-01-04 Thread Neil Armstrong
This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is based on the SM8450 display support serie at [1]. In order to work, the following patchsets are required: - PM8550 LDO fix at [2] - DISPCC driver at [3] + the DT changes. [1] https://lore.kernel.org/all/20

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-04 Thread Neil Armstrong
On 04/01/2023 08:29, Tomi Valkeinen wrote: On 28/12/2022 23:58, Dmitry Baryshkov wrote: On 02/11/2022 20:06, Dmitry Baryshkov wrote:  From all the drivers using drm_bridge_connector only iMX/dcss and OMAP DRM driver do a proper work of calling drm_bridge_connector_en/disable_hpd() in right plac