Re: [Freedreno] [PATCH] drm/msm/hdmi: remove unnecessary NULL check

2022-11-16 Thread Abhinav Kumar
On 11/15/2022 5:03 AM, Dan Carpenter wrote: This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") and now the "hdmi" pointer can't be NULL. Checking causes a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() w

[Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 10nm PHY

2022-11-16 Thread Konrad Dybcio
On some SoCs (hello SM6350) vdds-supply is not wired to any smd-rpm or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, which is voted for in the DSI ctrl node. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 1 - 1 file changed, 1

Re: [Freedreno] [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 16, 2022 8:37 PM >To: Kalyan Thota ; Kalyan Thota (QUIC) >; dri-de...@lists.freedesktop.org; linux-arm- >m...@vger.kernel.org; freedreno@lists.freedesktop.org; >devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel

Re: [Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 18:35, Abhinav Kumar wrote: On 11/16/2022 7:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and D

Re: [Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 7:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD

Re: [Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builti

Re: [Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1:

Re: [Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - ad

Re: [Freedreno] [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 17:29, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Saturday, November 12, 2022 4:13 AM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedreno@lists.freedesktop.org; devicet...@vger.kernel.org Cc: linux

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Add qcom, sm8350-dpu binding

2022-11-16 Thread Rob Herring
On Tue, 15 Nov 2022 14:30:54 +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for DPU device > tree bindings > > Signed-off-by: Robert Foss > --- > .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120 +++

[Freedreno] [PATCH v2 3/3] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register for color when crtc is created (Dmitry) Chan

[Freedreno] [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Kalyan Thota
Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper functions to know encoder type - u

[Freedreno] [PATCH v2 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-16 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through encoder list (Dmitry) Changes in v2: - mak

[Freedreno] [PATCH v2 0/3] add color management support for the crtc

2022-11-16 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog Kalyan Thota (3): drm/msm/disp/dpu1: pin 1 crtc to 1 encoder drm/msm/disp/dpu1: add helper to know if display is pluggable drm/msm/disp/dpu1: add color management support for the

Re: [Freedreno] [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Saturday, November 12, 2022 4:13 AM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedreno@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

Re: [Freedreno] [v1] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Saturday, November 12, 2022 3:51 AM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedreno@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

Re: [Freedreno] [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-16 Thread Dmitry Baryshkov
On 15/11/2022 21:43, Kuogee Hsieh wrote: On 11/9/2022 11:43 PM, Dmitry Baryshkov wrote: On 10/11/2022 02:47, Kuogee Hsieh wrote: On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someo

Re: [Freedreno] [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask

2022-11-16 Thread Abhinav Kumar
On 11/7/2022 2:37 AM, Konrad Dybcio wrote: From: Konrad Dybcio SDM845 only has INTF0-3 and has no business caring about the INTF4 irq. Suggested-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio It is true that SDM845 doesnt have INTF4. I was a bit concerne

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 1:43 AM, Dmitry Baryshkov wrote: On 16/11/2022 12:29, Abhinav Kumar wrote: On 11/16/2022 1:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 11:30, Abhinav Kumar wrote: On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote: On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 12:29, Abhinav Kumar wrote: On 11/16/2022 1:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 11:30, Abhinav Kumar wrote: On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote: On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 1:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 11:30, Abhinav Kumar wrote: On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote: On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 11:30, Abhinav Kumar wrote: On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote: On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / i

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote: On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these regis

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 10:50, Abhinav Kumar wrote: On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Tested-by: Vinod Koul Review