Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-10 Thread Krzysztof Kozlowski
On 10/11/2022 22:45, Dmitry Baryshkov wrote: >> >>> + - reg >>> + - reg-names >>> + - power-domains >>> + - clocks >>> + - interrupts >>> + - interrupt-controller >>> + - iommus >>> + - ranges >> >> Keep the same order as in list of top-level properties. > > But the order is the same. Yes

Re: [Freedreno] [PATCH v3 4/8] drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450

2022-11-10 Thread Dmitry Baryshkov
On 04/11/2022 16:54, Konrad Dybcio wrote: On 04/11/2022 14:03, Dmitry Baryshkov wrote: SM8350 and SM8450 use 5nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 5nm variants inside the common 5+7nm driver. Co-developed-by: Robert Foss T

Re: [Freedreno] [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-11-10 Thread Dmitry Baryshkov
On 08/11/2022 14:05, Krzysztof Kozlowski wrote: On 24/10/2022 18:42, Dmitry Baryshkov wrote: Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-mdss schema to allow interconnect nodes, which will be added later, once msm8998 gains interconnect support

Re: [Freedreno] [PATCH v3 7/8] drm/msm/dpu: add support for SM8450

2022-11-10 Thread Konrad Dybcio
On 10/11/2022 21:28, Dmitry Baryshkov wrote: On 04/11/2022 17:12, Konrad Dybcio wrote: On 04/11/2022 14:03, Dmitry Baryshkov wrote: Add definitions for the display hardware used on Qualcomm SM8450 platform. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --

Re: [Freedreno] [PATCH v3 7/8] drm/msm/dpu: add support for SM8450

2022-11-10 Thread Dmitry Baryshkov
On 04/11/2022 17:12, Konrad Dybcio wrote: On 04/11/2022 14:03, Dmitry Baryshkov wrote: Add definitions for the display hardware used on Qualcomm SM8450 platform. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad   .../

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-10 Thread Konrad Dybcio
On 10/11/2022 21:19, Dmitry Baryshkov wrote: On 04/11/2022 16:58, Konrad Dybcio wrote: On 04/11/2022 14:03, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-10 Thread Dmitry Baryshkov
On 04/11/2022 16:58, Konrad Dybcio wrote: On 04/11/2022 14:03, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Must have been fun to debug..

Re: [Freedreno] [PATCH 4/5] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2022-11-10 Thread Liviu Dudau
On Thu, Nov 10, 2022 at 05:44:44PM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") > Signed-off-by: Gaosheng Cui Acked

Re: [Freedreno] (subset) [PATCH 5/5] drm/vc4: kms: Fix IS_ERR() vs NULL check for vc4_kms

2022-11-10 Thread Maxime Ripard
On Thu, 10 Nov 2022 17:44:45 +0800, Gaosheng Cui wrote: > The drm_atomic_get_new_private_obj_state() function returns NULL > on error path, drm_atomic_get_old_private_obj_state() function > returns NULL on error path, too, they does not return error pointers. > > By the way, vc4_hvs_get_new/old_gl

[Freedreno] [PATCH 3/5] drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in msm_icc_get()

2022-11-10 Thread Gaosheng Cui
The of_icc_get() function returns NULL or error pointers on error path, so we should use IS_ERR_OR_NULL() to check the return value. Fixes: 5ccdcecaf8f7 ("drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/msm/msm_io_utils.c | 2 +-

[Freedreno] [PATCH 5/5] drm/vc4: kms: Fix IS_ERR() vs NULL check for vc4_kms

2022-11-10 Thread Gaosheng Cui
The drm_atomic_get_new_private_obj_state() function returns NULL on error path, drm_atomic_get_old_private_obj_state() function returns NULL on error path, too, they does not return error pointers. By the way, vc4_hvs_get_new/old_global_state() should return ERR_PTR(-EINVAL), otherwise there will

[Freedreno] [PATCH 1/5] drm/panel: Fix IS_ERR() vs NULL check in nt35950_probe()

2022-11-10 Thread Gaosheng Cui
The mipi_dsi_device_register_full() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 2 +- 1 fi

[Freedreno] [PATCH 4/5] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2022-11-10 Thread Gaosheng Cui
The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- 1 file

[Freedreno] [PATCH 2/5] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

2022-11-10 Thread Gaosheng Cui
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Freedreno] [PATCH 0/5] Fix IS_ERR() vs NULL check for drm

2022-11-10 Thread Gaosheng Cui
This series contains a few fixup patches, to fix IS_ERR() vs NULL check for drm, and avoid a potential null-ptr-defer issue, too. Thanks! Gaosheng Cui (5): drm/panel: Fix IS_ERR() vs NULL check in nt35950_probe() drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb() drm/msm: Fix IS_ERR_