Re: [Freedreno] [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-24 Thread Krzysztof Kozlowski
On 23/08/2022 17:56, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v3] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-24 Thread Doug Anderson
Hi, On Wed, Aug 24, 2022 at 1:16 PM Kuogee Hsieh wrote: > > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. >

Re: [Freedreno] [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-08-24 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do not override the mdp5's drvdata. Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") Signed-off-by: Dmitry Baryshkov Is th

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-24 Thread Caleb Connolly
On 22/08/2022 20:11, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 38

Re: [Freedreno] [PATCH v2 4/7] regulator: core: Allow specifying an initial load w/ the bulk API

2022-08-24 Thread Doug Anderson
Hi, On Mon, Aug 22, 2022 at 11:23 PM Yongqin Liu wrote: > > Hi, Douglas > > Just an update on the fix you pointed out previously here: > > > [1] > > > https://lore.kernel.org/r/20220809142738.1.I91625242f137c707bb345c51c80c5ecee02eeff3@changeid > > With it I could boot the hikey960 build to the

[Freedreno] [PATCH] drm/msm: De-open-code some CP_EVENT_WRITE

2022-08-24 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c b/drivers/

Re: [Freedreno] [PATCH v3 5/5] arm64: dts: qcom: sc7280: Add Reset support for gpu

2022-08-24 Thread Akhil P Oommen
On 8/19/2022 11:47 AM, Krzysztof Kozlowski wrote: On 18/08/2022 23:18, Akhil P Oommen wrote: Add support for Reset using GPUCC driver for GPU. This helps to ensure that GPU state is reset by making sure that CX head switch is collapsed. Signed-off-by: Akhil P Oommen --- (no changes since v1)

Re: [Freedreno] [PATCH 5/5] drm/msm: Skip tlbinv on unmap from non-current pgtables

2022-08-24 Thread Rob Clark
On Wed, Aug 24, 2022 at 10:46 AM Akhil P Oommen wrote: > > On 8/21/2022 11:49 PM, Rob Clark wrote: > > From: Rob Clark > > > > We can rely on the tlbinv done by CP_SMMU_TABLE_UPDATE in this case. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++ > >

[Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-24 Thread Kuogee Hsieh
DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately followed by close DRM device while down strea

[Freedreno] [PATCH v2 1/5] dt-bindings: clk: qcom: Support gpu cx gdsc reset

2022-08-24 Thread Akhil P Oommen
Add necessary definitions in gpucc bindings to ensure gpu cx gdsc collapse through 'reset' framework for SC7280. Signed-off-by: Akhil P Oommen Acked-by: Krzysztof Kozlowski --- (no changes since v1) include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[Freedreno] [PATCH v2 2/5] clk: qcom: Allow custom reset ops

2022-08-24 Thread Akhil P Oommen
Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc. Signed-off-by: Akhil P Oommen --- Changes in v2: - Return error when a particular custom reset op is not implemented.

Re: [Freedreno] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-08-24 Thread Rob Clark
On Wed, Aug 17, 2022 at 2:57 AM Christian König wrote: > > > > Am 16.08.22 um 19:29 schrieb Rob Clark: > > On Tue, Aug 16, 2022 at 9:51 AM Christian König > > wrote: > >> Am 16.08.22 um 16:26 schrieb Rob Clark: > >>> On Tue, Aug 16, 2022 at 1:27 AM Christian König > >>> wrote: > Am 15.08.22

[Freedreno] [PATCH v2 5/5] dt-bindings: display/msm: dpu-sdm845: add missing DPU opp-table

2022-08-24 Thread Krzysztof Kozlowski
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses opp-table, so reference it which allows restricting DPU schema to fixed list of properties. Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU bindings") Signed-off-by: Krzysztof Kozlowski --- Cc: Dmitry

Re: [Freedreno] [PATCH v2] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-24 10:22:31) > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. > > Changes in v2:

Re: [Freedreno] [PATCH] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-24 09:59:16) > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. > > Fixes: 937f941

Re: [Freedreno] [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-08-24 Thread Dmitry Baryshkov
On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar wrote: > > > > On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: > > The rest of the code expects that master's device drvdata is the > > struct msm_drm_private instance. Do not override the mdp5's drvdata. > > > > Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dp

Re: [Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-24 Thread Dmitry Baryshkov
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote: > > > > On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote: > > On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar > > wrote: > >> On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: > >>> On 22/08/2022 20:32, Abhinav Kumar wrote: > > > On 8/22/202