Re: [Freedreno] [PATCH v3 2/3] drm/msm/hdmi: make hdmi_phy_8996 OF clk provider

2022-08-23 Thread Abhinav Kumar
On 7/4/2022 9:11 AM, Dmitry Baryshkov wrote: On MSM8996 the HDMI PHY provides the PLL clock to the MMCC. As we are preparing to convert the MSM8996 to use DT clocks properties (rather than global clock names), register the OF clock provider. While we are at it, also change the driver to use c

Re: [Freedreno] [PATCH 3/3] drm/msm/hdmi: move resource allocation to probe function

2022-08-23 Thread Abhinav Kumar
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. While we are at it, use platform_get_irq() t

Re: [Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-23 Thread Abhinav Kumar
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote: On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote: On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: On 22/08/2022 20:32, Abhinav Kumar wrote: On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry O

Re: [Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-23 Thread Dmitry Baryshkov
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote: > On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: > > On 22/08/2022 20:32, Abhinav Kumar wrote: > >> > >> > >> On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: > >>> On 22/08/2022 19:38, Abhinav Kumar wrote: > Hi Dmitry > > On 8/22/2022

Re: [Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-23 Thread Abhinav Kumar
Sorry missed one response, On 8/23/2022 3:07 PM, Abhinav Kumar wrote: On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: On 22/08/2022 20:32, Abhinav Kumar wrote: On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry B

Re: [Freedreno] [PATCH] drm/msm/dpu: drop unused variable from dpu_kms_mdp_snapshot()

2022-08-23 Thread Abhinav Kumar
On 8/22/2022 10:22 AM, Dmitry Baryshkov wrote: Follow up the merge of address fields and drop the variable that became unused after the commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map"). Fixes: 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off

Re: [Freedreno] [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-23 Thread Abhinav Kumar
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote: On 22/08/2022 20:32, Abhinav Kumar wrote: On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_t

Re: [Freedreno] [PATCH v2] drm/msm/iommu: optimize map/unmap

2022-08-23 Thread Rob Clark
On Tue, Aug 23, 2022 at 2:37 PM Akhil P Oommen wrote: > > On 8/23/2022 10:07 PM, Rob Clark wrote: > > From: Rob Clark > > > > Using map_pages/unmap_pages cuts down on the # of pgtable walks needed > > in the process of finding where to insert/remove an entry. The end > > result is ~5-10x faster

Re: [Freedreno] [PATCH] drm/msm/dsi: drop the hpd worker

2022-08-23 Thread Abhinav Kumar
On 8/22/2022 10:44 AM, Dmitry Baryshkov wrote: It makes no sense to have the HPD worker in the MSM DSI driver anymore. It is only queued from the dsi_host_attach/detach() callbacks, where it plays no useful role. Either way the panel or next bridge will be present and will report it's status d

Re: [Freedreno] [PATCH v2] drm/msm/dp: Silence inconsistent indent warning

2022-08-23 Thread Abhinav Kumar
On 8/23/2022 2:23 PM, Stephen Boyd wrote: Build robots complain smatch warnings: drivers/gpu/drm/msm/dp/dp_link.c:969 dp_link_process_link_status_update() warn: inconsistent indenting Fix it along with a trailing space from the same commit. Cc: Kuogee Hsieh Fixes: ea530388e64b ("drm/m

Re: [Freedreno] [PATCH v2] drm/msm/iommu: optimize map/unmap

2022-08-23 Thread Akhil P Oommen
On 8/23/2022 10:07 PM, Rob Clark wrote: From: Rob Clark Using map_pages/unmap_pages cuts down on the # of pgtable walks needed in the process of finding where to insert/remove an entry. The end result is ~5-10x faster than mapping a single page at a time. v2: Rename iommu_pgsize(), drop obsol

Re: [Freedreno] [PATCH v4 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-23 Thread Akhil P Oommen
On 8/23/2022 4:41 PM, Krzysztof Kozlowski wrote: On 19/08/2022 19:40, Akhil P Oommen wrote: Documentation/devicetree/bindings/display/msm/gpu.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bind

Re: [Freedreno] [RFC PATCH] drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices

2022-08-23 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-08-05 04:56:30) > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c > b/drivers/gpu/drm/msm/msm_io_utils.c > index 7b504617833a..d02cd29ce829 100644 > --- a/drivers/gpu/drm/msm/msm_io_utils.c > +++ b/drivers/gpu/drm/msm/msm_io_utils.c > @@ -124,3 +126,23 @@ void msm_hr

[Freedreno] [PATCH v2] drm/msm/dp: Silence inconsistent indent warning

2022-08-23 Thread Stephen Boyd
Build robots complain smatch warnings: drivers/gpu/drm/msm/dp/dp_link.c:969 dp_link_process_link_status_update() warn: inconsistent indenting Fix it along with a trailing space from the same commit. Cc: Kuogee Hsieh Fixes: ea530388e64b ("drm/msm/dp: skip checking LINK_STATUS_UPDATED bit") Re

Re: [Freedreno] [PATCH] drm/msm/dp: Silence inconsistent indent warning

2022-08-23 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-08-23 10:47:02) > link->request.test_lane_count; > - link->dp_link.link_params.rate = link->request.test_link_rate; > + link->dp_link.link_params.rate = > + drm_dp_bw_code_to_link_rate(link->request.test_link_rate); > > return 0; > > Si

Re: [Freedreno] [PATCH v2 4/7] regulator: core: Allow specifying an initial load w/ the bulk API

2022-08-23 Thread Yongqin Liu
Hi, Douglas On Tue, 23 Aug 2022 at 22:50, Doug Anderson wrote: > > Hi, > > On Mon, Aug 22, 2022 at 11:23 PM Yongqin Liu wrote: > > > > Hi, Douglas > > > > Just an update on the fix you pointed out previously here: > > > > [1] > > > > https://lore.kernel.org/r/20220809142738.1.I91625242f137c707b

Re: [Freedreno] [PATCH] disp/dpu1: fix repeated words in comments

2022-08-23 Thread Abhinav Kumar
Please fix the subject line . It should be drm/msm/dpu: fix repeated words in comments Also, you can add Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") On 8/23/2022 4:51 AM, Jilin Yuan wrote: Delete the redundant word 'is'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/msm/disp

Re: [Freedreno] [PATCH] drm/msm/dp: Silence inconsistent indent warning

2022-08-23 Thread Abhinav Kumar
Hi Stephen On 8/22/2022 7:43 PM, Stephen Boyd wrote: Build robots complain smatch warnings: drivers/gpu/drm/msm/dp/dp_link.c:969 dp_link_process_link_status_update() warn: inconsistent indenting Fix it. Cc: Kuogee Hsieh Fixes: ea530388e64b ("drm/msm/dp: skip checking LINK_STATUS_UPDATED

Re: [Freedreno] [PATCH 2/3] drm/msm/hdmi: drop constant resource names from platform config

2022-08-23 Thread Abhinav Kumar
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote: All MSM HDMI devices use "core_physical" and "qfprom_physical" names for register areas. Drop them from the platform config. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/hdmi/hdmi.c | 9 +++-- driv

Re: [Freedreno] [PATCH 1/3] drm/msm/hdmi: use devres helper for runtime PM management

2022-08-23 Thread Abhinav Kumar
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote: Use devm_pm_runtime_enable() to enable runtime PM. This way its effect will be reverted on device unbind/destruction. Fixes: 6ed9ed484d04 ("drm/msm/hdmi: Set up runtime PM for HDMI") Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH v2] drm/msm/iommu: optimize map/unmap

2022-08-23 Thread Sai Prakash Ranjan
On 8/23/2022 10:07 PM, Rob Clark wrote: From: Rob Clark Using map_pages/unmap_pages cuts down on the # of pgtable walks needed in the process of finding where to insert/remove an entry. The end result is ~5-10x faster than mapping a single page at a time. v2: Rename iommu_pgsize(), drop obsol

[Freedreno] [PATCH v2] drm/msm/iommu: optimize map/unmap

2022-08-23 Thread Rob Clark
From: Rob Clark Using map_pages/unmap_pages cuts down on the # of pgtable walks needed in the process of finding where to insert/remove an entry. The end result is ~5-10x faster than mapping a single page at a time. v2: Rename iommu_pgsize(), drop obsolete comments, fix error handling in ms

[Freedreno] [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-23 Thread Rob Herring
In order to ensure only documented properties are present, node schemas must have unevaluatedProperties or additionalProperties set to false (typically). Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/display/arm,komeda.yaml| 1 + Documentation/devicetree/bindings/displ

[Freedreno] [PATCH] disp/dpu1: fix repeated words in comments

2022-08-23 Thread Jilin Yuan
Delete the redundant word 'is'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index bce47647d891..59ca7d70a652 100644 --

[Freedreno] [PATCH] msm/adreno: fix repeated words in comments

2022-08-23 Thread Jilin Yuan
Delete the redundant word 'power'. Delete the redundant word 'in'. Delete the redundant word 'for'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/

[Freedreno] [PATCH] drm/msm: fix repeated words in comments

2022-08-23 Thread Jilin Yuan
Delete the redundant word 'one'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/msm/msm_gem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index c75d3b879a53..e300c70e8904 100644 --- a/drivers/gpu/drm/msm/msm_ge

Re: [Freedreno] [PATCH] drm/msm/iommu: optimize map/unmap

2022-08-23 Thread Sai Prakash Ranjan
Hi Rob, On 8/23/2022 12:17 AM, Rob Clark wrote: From: Rob Clark Using map_pages/unmap_pages cuts down on the # of pgtable walks needed in the process of finding where to insert/remove an entry. The end result is ~5-10x faster than mapping a single page at a time. Signed-off-by: Rob Clark --

Re: [Freedreno] [PATCH v4 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-23 Thread Krzysztof Kozlowski
On 19/08/2022 19:40, Akhil P Oommen wrote: > Documentation/devicetree/bindings/display/msm/gpu.yaml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml > b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index 3397bc3..4

Re: [Freedreno] [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss schema to mdss.yaml

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 22:04, Dmitry Baryshkov wrote: >>> required: >>> - compatible >>> - reg >>> @@ -177,7 +204,19 @@ patternProperties: >>> # TODO: add reference once the mdp5 is converted >>> >>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$": >>> -$ref: dpu-sdm845.yaml >>> +

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-23 Thread Konrad Dybcio
On 22.08.2022 21:11, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8250.dts

Re: [Freedreno] [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 20:58, Dmitry Baryshkov wrote: > On 06/07/2022 18:52, Krzysztof Kozlowski wrote: >> On 06/07/2022 16:52, Dmitry Baryshkov wrote: >>> Make display/msm/gmu.yaml describe all existing GMU variants rather than >>> just the 630.2 (SDM845) version of it. >>> >>> Signed-off-by: Dmitry Barysh

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-23 Thread Krzysztof Kozlowski
On 22/08/2022 22:11, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof