On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote:
> On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> > On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > > The existing msm8916.dtsi does not depend on nor require power-domains.
> > > Drop from the list of required.
> >
> > That's no
On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
The existing msm8916.dtsi does not depend on nor require power-domains.
Drop from the list of required.
That's not good reason. The bindings are about hardware so the question
is whether being a part o
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed this one.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
> bindings")
> Signed-off-by: Bryan O'Donoghue
> -
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
> bindings")
> Signed-off-by: Bryan O'Donoghue
> -
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml dt-binding descriptions we appear to
> have missed some of the previous detail on the number and names of
> permissible clocks.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
> bindings")
On 30/06/2022 19:30, Bryan O'Donoghue wrote:
> On 30/06/2022 18:16, Dmitry Baryshkov wrote:
>>
>> All three descriptions are the same. This looks like a c&p issue
>
> Those are what the previous values were.
>
No, original TXT had different descriptions:
-- vdd-supply: phandle to vdd regulator
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml we didn't include descriptions for the
> existing regulator supplies.
>
> - vdd
> - vdda
> - vddio
>
> Add those descriptions into the yaml now as they were prior to the
> conversion.
>
> Fixes: 4dbe55c97741 ("dt-b
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require power-domains.
> Drop from the list of required.
That's not good reason. The bindings are about hardware so the question
is whether being a part of power domain or toggling power domain on/off
i
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require operating points.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
> bindings")
> Signed-off-by: Bryan O'Donoghue
> ---
Acked-by: Krzysztof Kozlowski
Best regards,
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundan
On 30/06/2022 18:16, Dmitry Baryshkov wrote:
All three descriptions are the same. This looks like a c&p issue
Those are what the previous values were.
I'll come up with something less robotic though.
On 30 June 2022 15:08:43 GMT+03:00, Bryan O'Donoghue
wrote:
>When converting from .txt to .yaml dt-binding descriptions we appear to
>have missed some of the previous detail on the number and names of
>permissible clocks.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue
wrote:
>Add in missing clock and clock-names declarations to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed these.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
>bindings")
>Signed-off-by: Bryan O
On 30 June 2022 15:08:42 GMT+03:00, Bryan O'Donoghue
wrote:
>When converting from .txt to .yaml we didn't include descriptions for the
>existing regulator supplies.
>
>- vdd
>- vdda
>- vddio
>
>Add those descriptions into the yaml now as they were prior to the
>conversion.
>
>Fixes: 4dbe55c977
On 30 June 2022 15:08:45 GMT+03:00, Bryan O'Donoghue
wrote:
>Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed this one.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
>bindings")
>Signed-off-by: Bryan O
On 30 June 2022 15:08:41 GMT+03:00, Bryan O'Donoghue
wrote:
>The existing msm8916.dtsi does not depend on nor require power-domains.
>Drop from the list of required.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
>bindings")
>Signed-off-by: Bryan O'Donoghue
Review
On 30 June 2022 15:08:40 GMT+03:00, Bryan O'Donoghue
wrote:
>The existing msm8916.dtsi does not depend on nor require operating points.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI
>bindings")
>Signed-off-by: Bryan O'Donoghue
Reviewed-by: Dmitry Baryshkov
>---
On 30 June 2022 15:08:39 GMT+03:00, Bryan O'Donoghue
wrote:
>The driver doesn't care about the name of the phy in DTS. msm8916 has since
>2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
>There's no reason to have a constraint on the name here, simply to have a
>name. Remo
On 5/28/2022 10:22 PM, Joe Perches wrote:
On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote:
Leading spaces are not something checkpatch likes, and it says so when
they are present. Use tabs consistently to indent function body and
unwrap a 83-char-long line, as 100 is cool nowadays.
unass
The existing msm8916.dtsi does not depend on nor require power-domains.
Drop from the list of required.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 f
The driver doesn't care about the name of the phy in DTS. msm8916 has since
2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
There's no reason to have a constraint on the name here, simply to have a
name. Remove the redundant const in favour of maxItems: 1.
Fixes: 4dbe55c97741
Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
When converting from .txt to .yaml we missed this one.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue
---
.../devicetree/bindings/display/msm/dsi-phy-28nm.yaml
This series fixes up a number of dtbs checks which are being flagged adding
in the msm8939 dtsi.
When converting from .txt to .yaml a number of the parameters for the older
msm8916 silicon were not transmitted into the yaml.
Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms o
Add in missing clock and clock-names declarations to the 28nm DSI PHY.
When converting from .txt to .yaml we missed these.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue
---
.../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++
When converting from .txt to .yaml we didn't include descriptions for the
existing regulator supplies.
- vdd
- vdda
- vddio
Add those descriptions into the yaml now as they were prior to the
conversion.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-b
The existing msm8916.dtsi does not depend on nor require operating points.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 file changed, 1 deletion(-)
d
When converting from .txt to .yaml dt-binding descriptions we appear to
have missed some of the previous detail on the number and names of
permissible clocks.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue
---
.../display/msm/dsi-
On 5/28/2022 9:33 PM, Konrad Dybcio wrote:
There are various SKUs of A619, ranging from 565 MHz to 850 MHz, depending
on the bin. Add support for distinguishing them, so that proper frequency
ranges can be applied, depending on the HW.
Signed-off-by: Konrad Dybcio
---
drivers/gpu/drm/msm/adre
On 5/28/2022 9:33 PM, Konrad Dybcio wrote:
This BUG_ON will never be reached, and there is a comment 20 above
explaining why.
Signed-off-by: Konrad Dybcio
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
b/d
On 5/28/2022 9:33 PM, Konrad Dybcio wrote:
Add support for the Adreno 619 GPU, as found in Snapdragon 690 (SM6350),
480 (SM4350) and 750G (SM7225).
Signed-off-by: Konrad Dybcio
---
Changes since v2:
- Fix some values in a619_build_bw_table (I think I miscopied things last
time around..)
- Add a
30 matches
Mail list logo
