Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Dmitry Baryshkov
On 30 June 2022 04:57:35 GMT+03:00, Rob Clark wrote: >On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: >> >> Hi, >> >> On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov >> wrote: >> > >> > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh >> > wrote: >> > >Some userspace presumes that the

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Abhinav Kumar
On 6/29/2022 6:57 PM, Rob Clark wrote: On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main displ

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Rob Clark
On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: > > Hi, > > On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov > wrote: > > > > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh > > wrote: > > >Some userspace presumes that the first connected connector is the main > > >display, where it's sup

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Doug Anderson
Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: > > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh > wrote: > >Some userspace presumes that the first connected connector is the main > >display, where it's supposed to display e.g. the login screen. For > >laptops, this should be th

[Freedreno] [PATCH v3 07/11] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c

[Freedreno] [PATCH v3 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls

2022-06-29 Thread Marijn Suijten
Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI PHY clocks") introduced the devm_ prefix to clk_hw registration calls, without updating the indentation of the arguments on the following lines. Similarly e55b3fc8 ("drm/msm/dsi: drop PLL accessor functions") moved from pl

[Freedreno] [PATCH v3 11/11] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 70

[Freedreno] [PATCH v3 08/11] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 50

[Freedreno] [PATCH v3 10/11] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 79

[Freedreno] [PATCH v3 09/11] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 40

[Freedreno] [PATCH v3 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-29 Thread Marijn Suijten
Add the devres and non-devres variant of clk_hw_register_fixed_factor_parent_hw() for registering a fixed factor clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- drivers/clk/clk-fixed-factor.c | 45 ++ include/linux/clk-pr

[Freedreno] [PATCH v3 06/11] drm/msm/dsi/phy: Replace hardcoded char-array length with sizeof()

2022-06-29 Thread Marijn Suijten
Now that the last DSI PHY PLL driver (dsi_phy_28nm_8960) has been converted to use a simple stack-local char-array instead of a devm_kzalloc heap allocation we can safely call sizeof() on every string variable (that's now a sized array instead of a pointer) passed into snprintf instead of hardcodin

[Freedreno] [PATCH v3 02/11] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

2022-06-29 Thread Marijn Suijten
Add the devres variant of clk_hw_register_mux_hws() for registering a mux clock with clk_hw parent pointers instead of parent names. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- include/linux/clk-provider.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/li

[Freedreno] [PATCH v3 05/11] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-06-29 Thread Marijn Suijten
The clock names formatted into the hw_clk's init structure are only used for the duration of the registration function where they are kstrdup'ed, making it unnecessary to keep the allocations alive for the duration of the device (through devm). Just like the other DSI PHY PLL clock trees, use a st

[Freedreno] [PATCH v3 01/11] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw()

2022-06-29 Thread Marijn Suijten
Add the devres variant of clk_hw_register_divider_parent_hw() for registering a divider clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- include/linux/clk-provider.h | 19 +++ 1 file changed, 19 insertions(+

[Freedreno] [PATCH v3 00/11] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. This series starts out by adding extra constructors for divider, mux and fixed-factor clocks that have parent_hw(s

[Freedreno] [PATCH 2/2] drm/msm/gpu: Add GEM debug label to devcore

2022-06-29 Thread Rob Clark
From: Rob Clark When trying to understand an iova fault devcore, once you figure out which buffer we accessed beyond the end of, it is useful to see the buffer's debug label. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + drivers/gpu/drm/msm/msm_gpu.c | 4

[Freedreno] [PATCH 1/2] drm/msm/gpu: Capture all BO addr+size in devcore

2022-06-29 Thread Rob Clark
From: Rob Clark It is useful to know what buffers userspace thinks are associated with the submit, even if we don't care to capture their content. This brings things more inline with $debugfs/rd cmdstream dumping. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 36 ---

[Freedreno] [PATCH 0/2] drm/msm: A couple GPU devcore enhancements

2022-06-29 Thread Rob Clark
From: Rob Clark A couple things useful for debugging iova faults: 1. caputre all buffer addresses and sizes even if we don't capture their contents. 2. capture the GEM buffer debug labels Rob Clark (2): drm/msm/gpu: Capture all BO addr+size in devcore drm/msm/gpu: Add GEM debug label to

Re: [Freedreno] [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

2022-06-29 Thread Rob Clark
On Tue, Jun 28, 2022 at 10:32 PM Akhil P Oommen wrote: > > On 6/29/2022 9:59 AM, Bjorn Andersson wrote: > > On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote: > > > >> Add a new sku to the fuse map of 7c3 gpu. > >> > >> Signed-off-by: Akhil P Oommen > > Is this series still needed/wanted? I've b

Re: [Freedreno] [v3 3/5] drm/bridge: add psr support during panel bridge enable & disable sequence

2022-06-29 Thread Sankeerth Billakanti (QUIC)
Hi Dmitry, >On 21/06/2022 13:53, Vinod Polimera wrote: >> This change avoids panel prepare/unprepare based on self-refresh >> state. >> >> Signed-off-by: Sankeerth Billakanti >> Signed-off-by: Kalyan Thota >> Signed-off-by: Vinod Polimera >> --- >> drivers/gpu/drm/bridge/panel.c | 102 >++

Re: [Freedreno] [v3 1/5] drm/msm/dp: Add basic PSR support for eDP

2022-06-29 Thread Sankeerth Billakanti (QUIC)
Hi Dmitry, >On 21/06/2022 13:53, Vinod Polimera wrote: >> Add support for basic panel self refresh (PSR) feature for eDP. >> Add a new interface to set PSR state in the sink from DPU. >> Program the eDP controller to issue PSR enter and exit SDP to the >> sink. >> >> Signed-off-by: Sankeerth Billa