This API isn't really more than a couple lines now that we don't store
the pixel_rate to the struct member. Inline it into the caller.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 44
1 file changed, 17 insertions(+), 27 de
This struct member is stored to in the function that calls the function
which uses it. That's possible with a function argument instead of
storing to a struct member. Pass the pixel_rate as an argument instead
to simplify the code. Note that dp_ctrl_link_maintenance() was storing
the pixel_rate but
Let's move these functions around to avoid having to forward declare
dp_ctrl_on_stream_phy_test_report(). Also remove
dp_ctrl_reinitialize_mainlink() forward declaration because we're doing
that sort of task.
Reviewed-by: Kuogee Hsieh
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Stephen Boyd
--
These patches do a little cleanup on the v9 patch[1] from Kuogee.
Changes from v1:
* Reduce code even more in second patch
* Pick up tags on first patch
Stephen Boyd (3):
drm/msm/dp: Reorganize code to avoid forward declaration
drm/msm/dp: Remove pixel_rate from struct dp_ctrl
drm/msm/dp:
Hi Vinod,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-exynos/exynos-drm-next drm-tip/drm-tip
tegra-drm/drm/tegra/for-next linus/master v5.19-rc3 next-20220622]
[cannot apply to drm-intel/for-linux-next airlied
Quoting Kuogee Hsieh (2022-06-21 10:01:29)
> This patch add regulator_set_load() before enable regulator at
> eDP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> Reviewed-by: Douglas Anderson
> Reviewed-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
On 6/22/2022 1:06 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-22 12:55:31)
During msm initialize phase, dp_display_unbind() will be called to undo
initializations had been done by dp_display_bind() previously if there is
error happen at msm_drm_bind. Under this kind of circumstance,
Quoting Kuogee Hsieh (2022-06-22 12:55:31)
> During msm initialize phase, dp_display_unbind() will be called to undo
> initializations had been done by dp_display_bind() previously if there is
> error happen at msm_drm_bind. Under this kind of circumstance, drm_device
> may not be populated complet
During msm initialize phase, dp_display_unbind() will be called to undo
initializations had been done by dp_display_bind() previously if there is
error happen at msm_drm_bind. Under this kind of circumstance, drm_device
may not be populated completed which causes system crash at drm_dev_dbg().
This
Quoting Kuogee Hsieh (2022-06-22 09:54:05)
> During msm initialize phase, dp_display_unbind() will be called to undo
> initializations had been done by dp_display_bind() previously if there is
> error happen at msm_drm_bind. Under this kind of circumstance, drm_device
> may not be populated complet
On 22/06/2022 19:54, Kuogee Hsieh wrote:
During msm initialize phase, dp_display_unbind() will be called to undo
initializations had been done by dp_display_bind() previously if there is
error happen at msm_drm_bind. Under this kind of circumstance, drm_device
may not be populated completed which
On 22/06/2022 19:55, Kuogee Hsieh wrote:
Use quic id instead of codeaurora id in maintainers list
for display devicetree bindings.
Signed-off-by: Kuogee Hsieh
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 +-
This patch has been already accepted. Why did you resend
On 21/06/2022 20:01, Kuogee Hsieh wrote:
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git
tree
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy: qcom-edp:
On 22/06/2022 18:22, Kuogee Hsieh wrote:
On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote:
On 22/06/2022 05:59, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-06-17 16:07:58)
On 17/06/2022 23:47, Stephen Boyd wrote:
This struct member is stored to in the function that calls the
function
wh
On 22/06/2022 19:55, Kuogee Hsieh wrote:
Use quic id instead of codeaurora id in maintainers list
for display devicetree bindings.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Dmitry Baryshkov
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 +-
1 file changed, 1 ins
On 22/06/2022 20:18, Jessica Zhang wrote:
Add support for writing CRC values for the interface block to
the debugfs by calling the necessary MISR setup/collect methods.
Changes since V1:
- Set values_cnt to only include phys with backing hw_intf
- Loop over all drm_encs connected to crtc
Change
On 22/06/2022 20:18, Jessica Zhang wrote:
Move layer mixer-specific section of dpu_crtc_get_crc() into a separate
helper method. This way, we can make it easier to get CRCs from other HW
blocks by adding other get_crc helper methods.
Changes since V1:
- Move common bitmasks to dpu_hw_util.h
- Mo
On 6/21/2022 7:38 PM, Stephen Boyd wrote:
The 'vsync_cnt' is used to count the number of frames for a crtc.
Unfortunately, we increment the count after waking up userspace via
dpu_crtc_vblank_callback() calling drm_crtc_handle_vblank().
drm_crtc_handle_vblank() wakes up userspace processes tha
On 22/06/2022 20:33, Rob Clark wrote:
On Wed, Jun 22, 2022 at 10:24 AM Abhinav Kumar
wrote:
On 6/21/2022 7:38 PM, Stephen Boyd wrote:
The 'vsync_cnt' is used to count the number of frames for a crtc.
Unfortunately, we increment the count after waking up userspace via
dpu_crtc_vblank_callbac
On Wed, Jun 22, 2022 at 10:24 AM Abhinav Kumar
wrote:
>
>
>
> On 6/21/2022 7:38 PM, Stephen Boyd wrote:
> > The 'vsync_cnt' is used to count the number of frames for a crtc.
> > Unfortunately, we increment the count after waking up userspace via
> > dpu_crtc_vblank_callback() calling drm_crtc_hand
On 6/21/2022 10:49 AM, Dmitry Baryshkov wrote:
On Tue, 21 Jun 2022 at 20:44, Abhinav Kumar wrote:
Copying freedreno
The patch needs to be sent to freedreno@. Otherwise it doesn't exist
in patchwork.
Ack
Hi Sunliming
Can you please re-send this and copy freedreno email list along with
On 6/21/2022 7:38 PM, Stephen Boyd wrote:
The 'vsync_cnt' is used to count the number of frames for a crtc.
Unfortunately, we increment the count after waking up userspace via
dpu_crtc_vblank_callback() calling drm_crtc_handle_vblank().
drm_crtc_handle_vblank() wakes up userspace processes tha
Add support for writing CRC values for the interface block to
the debugfs by calling the necessary MISR setup/collect methods.
Changes since V1:
- Set values_cnt to only include phys with backing hw_intf
- Loop over all drm_encs connected to crtc
Changes since V2:
- Remove vblank.h inclusion
- Ch
Move layer mixer-specific section of dpu_crtc_get_crc() into a separate
helper method. This way, we can make it easier to get CRCs from other HW
blocks by adding other get_crc helper methods.
Changes since V1:
- Move common bitmasks to dpu_hw_util.h
- Move common CRC methods to dpu_hw_util.c
- Upd
Move layer mixer specific MISR methods to generalized helper methods.
This will make it easier to add CRC support for other blocks in the
future.
Changes since V2:
- Reordered parameters so that offsets are after hw_blk_reg_map
- Fixed mismatched whitespace in bitmask definitions
Signed-off-by: J
Refactor existing CRC code for layer mixer and add CRC support for interface
blocks
Changes since V1:
- Create helper methods for collect_misr and setup_misr in dpu_hw_util.c
- Move common bitmasks into dpu_hw_util.h
- Update copyrights
- Create a dynamically allocated crcs array in dpu_crtc_stat
Add support for setting MISR registers within the interface
Changes since V1:
- Replaced dpu_hw_intf collect_misr and setup_misr implementations with
calls to dpu_hw_utils helper methods
Signed-off-by: Jessica Zhang
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.
Use quic id instead of codeaurora id in maintainers list
for display devicetree bindings.
Signed-off-by: Kuogee Hsieh
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display
During msm initialize phase, dp_display_unbind() will be called to undo
initializations had been done by dp_display_bind() previously if there is
error happen at msm_drm_bind. Under this kind of circumstance, drm_device
may not be populated completed which causes system crash at drm_dev_dbg().
This
On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote:
On 22/06/2022 05:59, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-06-17 16:07:58)
On 17/06/2022 23:47, Stephen Boyd wrote:
This struct member is stored to in the function that calls the
function
which uses it. That's possible with a funct
On 6/22/2022 12:26 AM, Dmitry Baryshkov wrote:
On 16/06/2022 20:09, Kuogee Hsieh wrote:
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel c
On 16/06/2022 20:09, Kuogee Hsieh wrote:
Display resolution change is implemented through drm modeset. Older
modeset (resolution) has to be disabled first before newer modeset
(resolution) can be enabled. Display disable will turn off both
pixel clock and main link clock so that main link have to
On 22/06/2022 05:59, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-06-17 16:07:58)
On 17/06/2022 23:47, Stephen Boyd wrote:
This struct member is stored to in the function that calls the function
which uses it. That's possible with a function argument instead of
storing to a struct member.
33 matches
Mail list logo
