On 08/06/2022 23:59, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-06-08 05:07:17)
@@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct
device *master, void *data)
hdmi_cfg->mmio_name = "core_physical";
hdmi_cfg->qfprom_mmio_name = "qfprom_physica
On Thu, 9 Jun 2022 at 02:37, Abhinav Kumar wrote:
>
>
>
> On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote:
> > On 09/06/2022 01:42, Abhinav Kumar wrote:
> >>
> >>
> >> On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote:
> >>> On 09/06/2022 01:35, Abhinav Kumar wrote:
>
>
> On 6/8/2022 3:30 PM,
On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote:
On 09/06/2022 01:42, Abhinav Kumar wrote:
On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote:
On 09/06/2022 01:35, Abhinav Kumar wrote:
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote:
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar
wrote:
On 6/2/2022
On Thu, 9 Jun 2022 at 00:02, Stephen Boyd wrote:
>
> Quoting Dmitry Baryshkov (2022-06-08 05:07:18)
> > DB820c makes use of core-vcc-supply and core-vdda-supply, however the
> > driver code doesn't support these regulators. Enable them for HDMI on
> > 8996 platform.
>
> The 'vdda-supply' name make
On 09/06/2022 01:42, Abhinav Kumar wrote:
On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote:
On 09/06/2022 01:35, Abhinav Kumar wrote:
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote:
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar
wrote:
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
On Thu, 2 Jun 20
On 08/06/2022 14:37, Krzysztof Kozlowski wrote:
On 08/06/2022 14:07, Dmitry Baryshkov wrote:
Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
Changes to schema:
HDMI:
- fixed reg-names numbering to match 0..3 instead 0,1,3,4
- dropped qcom,tx-ddc-* from example, they were n
On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote:
On 09/06/2022 01:35, Abhinav Kumar wrote:
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote:
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar
wrote:
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar
wrote:
On
On 09/06/2022 01:35, Abhinav Kumar wrote:
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote:
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar
wrote:
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar
wrote:
On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote:
On Wed
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote:
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote:
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote:
On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wro
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote:
>
>
>
> On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
> > On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote:
> >>> On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar
> >>> wrote:
>
Quoting Miaoqian Lin (2022-06-07 04:08:38)
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert drivers to us
Quoting Dmitry Baryshkov (2022-06-08 05:07:23)
> Declare that 8x60 HDMI PHY uses the core-vdda regulator and slave_iface
> clock (this is the same config as is used by the 8960).
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:22)
> MSM8660 requires the same set of clocks and regulators as MSM8960. Reuse
> MSM8960's config for the MSM8660 (8x60).
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:21)
> Since there is no more difference between the HDMI platform data
> between MSM8974/APQ8084/MSM8994/MSM8996, merge these configs into a
> single entry.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:20)
> The MSM HDMI driver has support for hpd_regs on 8x74/8084: supply
> regulators that are to be enabled for HPD to work. Currently these
> regulators contain the hpd_gdsc, which was replaced by the power-domains
> support and hpd-5v/hpd-5v-en, which ar
Quoting Dmitry Baryshkov (2022-06-08 05:07:18)
> DB820c makes use of core-vcc-supply and core-vdda-supply, however the
> driver code doesn't support these regulators. Enable them for HDMI on
> 8996 platform.
The 'vdda-supply' name makes me think this is another scenario where the
phy isn't powerin
Quoting Dmitry Baryshkov (2022-06-08 05:07:19)
> Several platform configs use empty 'none' regulator arrays. They are not
> necessary, as the code will use corresponding _cnt field and skip the
> array completely. Drop them now.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:17)
> @@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct
> device *master, void *data)
> hdmi_cfg->mmio_name = "core_physical";
> hdmi_cfg->qfprom_mmio_name = "qfprom_physical";
>
> - for (i = 0; i < HDMI_M
Quoting Dmitry Baryshkov (2022-06-08 05:07:16)
> With the last (and only) in-kernel user of hdmi-mux regulator, drop it
> from the HDMI driver.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:15)
> The HDMI circuitry on the IFC6410 is not powered by the 3v3. Drop the
> hdmi-mux-supply property.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-08 05:07:14)
> hdmi-mux-supply is not used by the SoC's HDMI block, it is thought to
> power up the external logic. Thus it should not be a part of HDMI
> bindings, but it should be declared at some other device in the DT (like
> HDMI mux, bridge, etc). Mark it as
Quoting Dmitry Baryshkov (2022-06-08 05:07:13)
> Mark obsolete GPIO properties as deprecated. They are not used by
> existing device trees. While we are at it, also drop them from the
> schema example.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Stephen Boyd
On Wed, Jun 8, 2022 at 12:36 PM Akhil P Oommen wrote:
>
> On 6/8/2022 3:00 AM, Rob Clark wrote:
> > On Tue, Sep 28, 2021 at 7:52 AM Akhil P Oommen
> > wrote:
> >> On 9/27/2021 8:59 PM, Rob Clark wrote:
> >>> From: Rob Clark
> >>>
> >>> I've seen a few crashes like:
> >>>
> >>> Internal er
On 6/8/2022 3:00 AM, Rob Clark wrote:
On Tue, Sep 28, 2021 at 7:52 AM Akhil P Oommen wrote:
On 9/27/2021 8:59 PM, Rob Clark wrote:
From: Rob Clark
I've seen a few crashes like:
Internal error: synchronous external abort: 9610 [#1] PREEMPT SMP
Modules linked in: snd_seq_dummy
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote:
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote:
On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wrote:
On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wro
From: Rob Clark
I've seen a few crashes like:
CPU: 0 PID: 216 Comm: A618-worker Tainted: GW 5.4.196 #7
Hardware name: Google Wormdingler rev1+ INX panel board (DT)
pstate: 20c9 (nzCv daif +PAN +UAO)
pc : msm_readl+0x14/0x34
lr : a6xx_gpu_busy+0x40/0x80
Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on robh/for-next linus/master v5.19-rc1 next-20220608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to
On Sat, May 21, 2022 at 11:17:51AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote:
> > This adds a devm managed version of drm_bridge_add(). Like other
> > "devm" function listed in drm_bridge.h, this function takes an
> > explicit "dev" to u
On 08/06/2022 14:07, Dmitry Baryshkov wrote:
> hdmi-mux-supply is not used by the SoC's HDMI block, it is thought to
> power up the external logic. Thus it should not be a part of HDMI
> bindings, but it should be declared at some other device in the DT (like
> HDMI mux, bridge, etc). Mark it as de
On 08/06/2022 14:07, Dmitry Baryshkov wrote:
> Mark obsolete GPIO properties as deprecated. They are not used by
> existing device trees. While we are at it, also drop them from the
> schema example.
>
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krz
On 08/06/2022 14:07, Dmitry Baryshkov wrote:
> Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
>
> Changes to schema:
> HDMI:
> - fixed reg-names numbering to match 0..3 instead 0,1,3,4
> - dropped qcom,tx-ddc-* from example, they were not documented
>
> PHY:
> - moved into p
Declare that 8x60 HDMI PHY uses the core-vdda regulator and slave_iface
clock (this is the same config as is used by the 8960).
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/msm/hdmi/
MSM8660 requires the same set of clocks and regulators as MSM8960. Reuse
MSM8960's config for the MSM8660 (8x60).
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/g
The MSM HDMI driver has support for hpd_regs on 8x74/8084: supply
regulators that are to be enabled for HPD to work. Currently these
regulators contain the hpd_gdsc, which was replaced by the power-domains
support and hpd-5v/hpd-5v-en, which are not used by the chip itself.
They power up the ESD br
DB820c makes use of core-vcc-supply and core-vdda-supply, however the
driver code doesn't support these regulators. Enable them for HDMI on
8996 platform.
Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c
Since there is no more difference between the HDMI platform data
between MSM8974/APQ8084/MSM8994/MSM8996, merge these configs into a
single entry.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-
Several platform configs use empty 'none' regulator arrays. They are not
necessary, as the code will use corresponding _cnt field and skip the
array completely. Drop them now.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 5 -
1 file changed, 5 deletions(-)
diff --gi
The HDMI driver has code to configure extra GPIOs, which predates
pinctrl support. Nowadays all platforms should use pinctrl instead.
Neither of upstreamed Qualcomm pltforms uses these properties, so it's
safe to drop them.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c
The HDMI circuitry on the IFC6410 is not powered by the 3v3. Drop the
hdmi-mux-supply property.
Signed-off-by: Dmitry Baryshkov
---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
b/arch/arm/boot/dts/qcom-a
With the last (and only) in-kernel user of hdmi-mux regulator, drop it
from the HDMI driver.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
i
hdmi-mux-supply is not used by the SoC's HDMI block, it is thought to
power up the external logic. Thus it should not be a part of HDMI
bindings, but it should be declared at some other device in the DT (like
HDMI mux, bridge, etc). Mark it as deprecated.
Signed-off-by: Dmitry Baryshkov
---
Docu
Mark obsolete GPIO properties as deprecated. They are not used by
existing device trees. While we are at it, also drop them from the
schema example.
Signed-off-by: Dmitry Baryshkov
---
Documentation/devicetree/bindings/display/msm/hdmi.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/
Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
Changes to schema:
HDMI:
- fixed reg-names numbering to match 0..3 instead 0,1,3,4
- dropped qcom,tx-ddc-* from example, they were not documented
PHY:
- moved into phy/ directory
- split into QMP and non-QMP PHY schemas
Co-dev
As agreed with David, this is a continuation of his work started at [1].
I didn't pick up his R-b tag for the first patch, since patch has been
heavily modified.
Changes since v1:
- Dropped quotes in $id/$schema
- Sorted out compat strings alphabetically
- Removed obvious descriptions
- Removed un
On 08/06/2022 11:58, Krzysztof Kozlowski wrote:
On 07/06/2022 20:58, Dmitry Baryshkov wrote:
Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
Changes to schema:
HDMI:
- fixed reg-names numbering to match 0..3 instead 0,1,3,4
PHY:
- moved into phy/ directory
- split into
On 08/06/2022 12:05, Krzysztof Kozlowski wrote:
On 07/06/2022 20:58, Dmitry Baryshkov wrote:
Mark obsolete GPIO properties as deprecated. They are not used by
existing device trees. While we are at it, also drop them from the
schema example.
Signed-off-by: Dmitry Baryshkov
---
.../devicetree
On 07/06/2022 20:58, Dmitry Baryshkov wrote:
> Mark obsolete GPIO properties as deprecated. They are not used by
> existing device trees. While we are at it, also drop them from the
> schema example.
>
> Signed-off-by: Dmitry Baryshkov
> ---
> .../devicetree/bindings/display/msm/qcom,hdmi.yaml
On 07/06/2022 20:58, Dmitry Baryshkov wrote:
> Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
>
> Changes to schema:
> HDMI:
> - fixed reg-names numbering to match 0..3 instead 0,1,3,4
>
> PHY:
> - moved into phy/ directory
> - split into QMP and non-QMP PHY schemas
>
> Co-
On 07/06/2022 17:08, Rob Clark wrote:
On Tue, Jun 7, 2022 at 9:02 AM Rob Clark wrote:
On Tue, Jun 7, 2022 at 1:56 AM Tvrtko Ursulin
wrote:
On 06/06/2022 20:54, Rob Clark wrote:
From: Rob Clark
Similar to AMD commit
874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the
in
49 matches
Mail list logo
