Re: [Freedreno] [PATCH v1 1/7] dt-bindings: display/msm: hdmi: split and convert to yaml

Thank you for bringing it back to life! Reviewed-by: David Heidelberg On 07/06/2022 20:58, Dmitry Baryshkov wrote: Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. Changes to schema: HDMI: - fixed reg-names numbering to match 0..3 instead 0,1,3,4 PHY: - moved into phy/ d

Re: [Freedreno] [PATCH] drm/msm: Switch ordering of runpm put vs devfreq_idle

On Tue, Sep 28, 2021 at 7:52 AM Akhil P Oommen wrote: > > On 9/27/2021 8:59 PM, Rob Clark wrote: > > From: Rob Clark > > > > I've seen a few crashes like: > > > > Internal error: synchronous external abort: 9610 [#1] PREEMPT SMP > > Modules linked in: snd_seq_dummy snd_seq snd_seq_d

[Freedreno] [PATCH v1 7/7] drm/msm/hdmi: merge platform config for 8974/8084/8994/8996

Since there is no more difference between the HDMI platform data between MSM8974/APQ8084/MSM8994/MSM8996, merge these configs into a single entry. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-

[Freedreno] [PATCH v1 6/7] drm/msm/hdmi: drop hpd_regs usage on 8x74/8084

The MSM HDMI driver has support for hpd_regs on 8x74/8084: supply regulators that are to be enabled for HPD to work. Currently these regulators contain the hpd_gdsc, which was replaced by the power-domains support and hpd-5v/hpd-5v-en, which are not used by the chip itself. They power up the ESD br

[Freedreno] [PATCH v1 5/7] drm/msm/hdmi: drop empty 'none' regulator lists

Several platform configs use empty 'none' regulator arrays. They are not necessary, as the code will use corresponding _cnt field and skip the array completely. Drop them now. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 5 - 1 file changed, 5 deletions(-) diff --gi

[Freedreno] [PATCH v1 4/7] drm/msm/hdmi: enable core-vcc/core-vdda-supply for 8996 platform

DB820c makes use of core-vcc-supply and core-vdda-supply, however the driver code doesn't support these regulators. Enable them for HDMI on 8996 platform. Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c

[Freedreno] [PATCH v1 2/7] dt-bindings: display/msm: hdmi: mark old GPIO properties as deprecated

Mark obsolete GPIO properties as deprecated. They are not used by existing device trees. While we are at it, also drop them from the schema example. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/qcom,hdmi.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 dele

[Freedreno] [PATCH v1 3/7] drm/msm/hdmi: drop unused GPIO support

The HDMI driver has code to configure extra GPIOs, which predates pinctrl support. Nowadays all platforms should use pinctrl instead. Neither of upstreamed Qualcomm pltforms uses these properties, so it's safe to drop them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c

[Freedreno] [PATCH v1 1/7] dt-bindings: display/msm: hdmi: split and convert to yaml

Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. Changes to schema: HDMI: - fixed reg-names numbering to match 0..3 instead 0,1,3,4 PHY: - moved into phy/ directory - split into QMP and non-QMP PHY schemas Co-developed-by: David Heidelberg Signed-off-by: Dmitry Baryshkov --

[Freedreno] [PATCH v1 0/7] drm/msm/hdmi: YAML-ify schema and cleanup some platform properties

As agreed with David, this is a continuation of his work started at [1]. Changes since his patches: HDMI schema: - Dropped generic pinctrl properties - Dropped data-lanes property, which is not supported by the HDMI driver - Switched to unevaluatedProperties - Moved clocks/regulators/supplies to c

Re: [Freedreno] [PATCH v2 1/2] drm: Add DRM_GEM_FOPS

Hi Am 07.06.22 um 16:58 schrieb Rob Clark: On Mon, Jun 6, 2022 at 11:56 PM Thomas Zimmermann wrote: Hi Am 06.06.22 um 21:54 schrieb Rob Clark: From: Rob Clark The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to provide additional file ops, like show_fdinfo(). Signed-o

Re: [Freedreno] [PATCH v2 2/2] drm/msm: Expose client engine utilization via fdinfo

On Tue, Jun 7, 2022 at 9:02 AM Rob Clark wrote: > > On Tue, Jun 7, 2022 at 1:56 AM Tvrtko Ursulin > wrote: > > > > > > On 06/06/2022 20:54, Rob Clark wrote: > > > From: Rob Clark > > > > > > Similar to AMD commit > > > 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the > > > inf

Re: [Freedreno] [PATCH v2 2/2] drm/msm: Expose client engine utilization via fdinfo

On Tue, Jun 7, 2022 at 1:56 AM Tvrtko Ursulin wrote: > > > On 06/06/2022 20:54, Rob Clark wrote: > > From: Rob Clark > > > > Similar to AMD commit > > 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the > > infrastructure added in previous patches, we add basic client info > > and

Re: [Freedreno] [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf

On Tue, 7 Jun 2022 at 14:08, Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device node pointer with > refcount incremented, we should use of_node_put() on it > when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 86418f90a4c1 ("drm: convert driv

Re: [Freedreno] [PATCH v2 1/2] drm: Add DRM_GEM_FOPS

On Mon, Jun 6, 2022 at 11:56 PM Thomas Zimmermann wrote: > > Hi > > Am 06.06.22 um 21:54 schrieb Rob Clark: > > From: Rob Clark > > > > The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to > > provide additional file ops, like show_fdinfo(). > > > > Signed-off-by: Rob Clark >

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

On 27/05/2022 05:25, Rob Clark wrote: On Thu, May 26, 2022 at 4:38 AM Tvrtko Ursulin wrote: On 26/05/2022 04:37, Rob Clark wrote: On Wed, May 25, 2022 at 9:22 AM Tvrtko Ursulin wrote: On 25/05/2022 14:41, Rob Clark wrote: On Wed, May 25, 2022 at 2:46 AM Tvrtko Ursulin wrote: On 24/05/

[Freedreno] [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf

of_graph_get_remote_node() returns remote device node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node") Signed-off-by: Miaoqian L

Re: [Freedreno] [PATCH v2 2/2] drm/msm: Expose client engine utilization via fdinfo

On 06/06/2022 20:54, Rob Clark wrote: From: Rob Clark Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for msm. Example output: # cat /proc/`pgrep g