Re: [Freedreno] [PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Randy Dunlap
On 5/23/22 15:23, Dmitry Baryshkov wrote: > Hi, > > On Mon, 23 May 2022 at 23:43, Randy Dunlap wrote: >> >> Fix a Kconfig warning for DRM_MSM by making it depend on OF, >> since 'select' does not follow any dependency chaings. >> >> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BU

Re: [Freedreno] [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

2022-05-23 Thread Doug Anderson
Hi, On Fri, May 20, 2022 at 5:01 PM Doug Anderson wrote: > > Hi, > > On Mon, May 16, 2022 at 3:28 AM Thomas Zimmermann wrote: > > > > Hi Douglas, > > > > I understand that you're trying to tell userspace that the modelist has > > been made up, but it's not something that should be done via fragi

Re: [Freedreno] [PATCH 0/9] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
Hi, On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > As stated in [1] I promised to tackle and send this series. > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-23 Thread Rob Clark
On Mon, May 23, 2022 at 7:45 AM Tvrtko Ursulin wrote: > > > Hi Rob, > > On 28/07/2021 02:06, Rob Clark wrote: > > From: Rob Clark > > > > The drm/scheduler provides additional prioritization on top of that > > provided by however many number of ringbuffers (each with their own > > priority level)

Re: [Freedreno] [PATCH 9/9] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:39, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitr

Re: [Freedreno] [PATCH 8/9] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitr

Re: [Freedreno] [PATCH 7/9] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten Reviewed-by: Dmitr

Re: [Freedreno] [PATCH 6/9] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > The clock names formatted into the hw_clk's init structure are only used > for the duration of the registration function where they are kstrdup'ed, > making it unnecessary to keep the allocations alive for the duration of > the device (throug

Re: [Freedreno] [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 01:44, Dmitry Baryshkov wrote: > > On Tue, 24 May 2022 at 00:38, Marijn Suijten > wrote: > > > > parent_hw pointers are easier to manage and cheaper to use than > > repeatedly formatting the parent name and subsequently leaving the clk > > framework to perform lookups based

Re: [Freedreno] [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. Can you please add a followup patch (or a preface one

Re: [Freedreno] [PATCH 4/9] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 00:38, Marijn Suijten wrote: > > parent_hw pointers are easier to manage and cheaper to use than > repeatedly formatting the parent name and subsequently leaving the clk > framework to perform lookups based on that name. > > Signed-off-by: Marijn Suijten > --- > drivers

Re: [Freedreno] [PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Dmitry Baryshkov
Hi, On Mon, 23 May 2022 at 23:43, Randy Dunlap wrote: > > Fix a Kconfig warning for DRM_MSM by making it depend on OF, > since 'select' does not follow any dependency chaings. > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS I think it was agreed that DRM_DP_AUX_BUS should depe

Re: [Freedreno] [PATCH] drm/msm/dsi: pll_7nm: remove unsupported dividers for DSI pixel clock

2022-05-23 Thread Marijn Suijten
On 2022-05-03 01:02:42, Dmitry Baryshkov wrote: > On 03/05/2022 00:42, Marijn Suijten wrote: > > On 2022-05-02 13:47:51, Stephen Boyd wrote: > >> Quoting Dmitry Baryshkov (2022-05-01 12:56:20) > >>> Remove dividers that are not recommended for DSI DPHY mode when setting > >> > >> Is "DPHY" intentio

[Freedreno] [PATCH 9/9] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 92 +++ 1 file

[Freedreno] [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- .../gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c| 18 +++--- 1 file

[Freedreno] [PATCH 7/9] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 36 ++ 1 file

[Freedreno] [PATCH 8/9] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 92 ++ 1 file

[Freedreno] [PATCH 6/9] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-05-23 Thread Marijn Suijten
The clock names formatted into the hw_clk's init structure are only used for the duration of the registration function where they are kstrdup'ed, making it unnecessary to keep the allocations alive for the duration of the device (through devm). Just like the other DSI PHY PLL clock trees, use a st

[Freedreno] [PATCH 3/9] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-05-23 Thread Marijn Suijten
Add the devres and non-devres variant of clk_hw_register_fixed_factor_parent_hw() for registering a fixed factor clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- drivers/clk/clk-fixed-factor.c | 57 -- include/linux/clk-pr

[Freedreno] [PATCH 4/9] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 52 +- 1 file

[Freedreno] [PATCH 2/9] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

2022-05-23 Thread Marijn Suijten
Add the devres variant of clk_hw_register_mux_hws() for registering a mux clock with clk_hw parent pointers instead of parent names. Signed-off-by: Marijn Suijten --- include/linux/clk-provider.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/clk-provider.h b/include/li

[Freedreno] [PATCH 1/9] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw()

2022-05-23 Thread Marijn Suijten
Add the devres variant of clk_hw_register_divider_parent_hw() for registering a divider clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- include/linux/clk-provider.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/c

[Freedreno] [PATCH 0/9] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-05-23 Thread Marijn Suijten
As stated in [1] I promised to tackle and send this series. parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. This series starts out by adding extra constructors f

[Freedreno] [PATCH -next] drm/msm: DRM_DP_AUX_BUS depends on OF

2022-05-23 Thread Randy Dunlap
Fix a Kconfig warning for DRM_MSM by making it depend on OF, since 'select' does not follow any dependency chaings. WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && OF [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=

Re: [Freedreno] [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

2022-05-23 Thread Doug Anderson
Hi, On Sat, May 21, 2022 at 2:17 AM Maxime Ripard wrote: > > Hi, > > On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote: > > This adds a devm managed version of drm_bridge_add(). Like other > > "devm" function listed in drm_bridge.h, this function takes an > > explicit "dev" to use

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-23 Thread Tvrtko Ursulin
Hi Rob, On 28/07/2021 02:06, Rob Clark wrote: From: Rob Clark The drm/scheduler provides additional prioritization on top of that provided by however many number of ringbuffers (each with their own priority level) is supported on a given generation. Expose the additional levels of priority