Re: [Freedreno] [PATCH 3/3] drm/msm: return the average load over the polling period

2022-04-15 Thread Chia-I Wu
On Fri, Apr 15, 2022 at 5:33 PM Chia-I Wu wrote: > > simple_ondemand interacts poorly with clamp_to_idle. It only looks at > the load since the last get_dev_status call, while it should really look > at the load over polling_ms. When clamp_to_idle true, it almost always > picks the lowest freque

[Freedreno] [PATCH 3/3] drm/msm: return the average load over the polling period

2022-04-15 Thread Chia-I Wu
simple_ondemand interacts poorly with clamp_to_idle. It only looks at the load since the last get_dev_status call, while it should really look at the load over polling_ms. When clamp_to_idle true, it almost always picks the lowest frequency on active because the gpu is idle between msm_devfreq_id

[Freedreno] [PATCH 2/3] drm/msm: simplify gpu_busy callback

2022-04-15 Thread Chia-I Wu
Move tracking and busy time calculation to msm_devfreq_get_dev_status. Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 19 ++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 + drivers/gpu/drm/msm/msm_gpu.h | 9 +++- drivers/g

[Freedreno] [PATCH 1/3] drm/msm: remove explicit devfreq status reset

2022-04-15 Thread Chia-I Wu
It is redundant since commit 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") because dev_pm_qos_update_request triggers get_dev_status. Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu

Re: [Freedreno] [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-15 Thread Kuogee Hsieh
On 4/14/2022 4:34 PM, Dmitry Baryshkov wrote: On 15/04/2022 01:06, Kuogee Hsieh wrote: On 4/8/2022 4:59 PM, Dmitry Baryshkov wrote: On Fri, 8 Apr 2022 at 23:30, Kuogee Hsieh wrote: On 4/8/2022 5:27 AM, Dmitry Baryshkov wrote: On 07/04/2022 00:28, Kuogee Hsieh wrote: dp_hpd_plug_handle()

[Freedreno] [PATCH v9] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Changes in v3: -- disable all HDP i

Re: [Freedreno] [PATCH v8] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Dmitry Baryshkov
On Sat, 16 Apr 2022 at 02:36, Kuogee Hsieh wrote: > > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Changes in v2: > -- start event

[Freedreno] [PATCH v8] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Changes in v3: -- disable all HDP i

Re: [Freedreno] [PATCH v7] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
On 4/15/2022 4:27 PM, Dmitry Baryshkov wrote: On Sat, 16 Apr 2022 at 02:10, Kuogee Hsieh wrote: On 4/15/2022 3:48 PM, Dmitry Baryshkov wrote: On Sat, 16 Apr 2022 at 01:34, Kuogee Hsieh wrote: Current DP driver implementation, event thread is kept running after DP display is unbind. This p

Re: [Freedreno] [PATCH v7] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Dmitry Baryshkov
On Sat, 16 Apr 2022 at 02:10, Kuogee Hsieh wrote: > > > On 4/15/2022 3:48 PM, Dmitry Baryshkov wrote: > > On Sat, 16 Apr 2022 at 01:34, Kuogee Hsieh wrote: > >> Current DP driver implementation, event thread is kept running > >> after DP display is unbind. This patch fix this problem by disabling

Re: [Freedreno] [PATCH 06/12] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-15 Thread Marijn Suijten
Hi Abhinav, On 2022-04-15 12:25:55, Abhinav Kumar wrote: > Hi Marijn > > Looking at msm-next tip, this code has already been refactored in > > https://gitlab.freedesktop.org/drm/msm/-/commit/ef58e0ad34365e2c8274b74e6e745b8c180ff0d3 > > So, I will just rebase my changes on msm-next tip and it sh

Re: [Freedreno] [PATCH v7] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
On 4/15/2022 3:48 PM, Dmitry Baryshkov wrote: On Sat, 16 Apr 2022 at 01:34, Kuogee Hsieh wrote: Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unb

Re: [Freedreno] [PATCH v7] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Dmitry Baryshkov
On Sat, 16 Apr 2022 at 01:34, Kuogee Hsieh wrote: > > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Changes in v2: > -- start event

[Freedreno] [PATCH v7] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Changes in v3: -- disable all HDP i

Re: [Freedreno] [PATCH v6] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-15 08:41:16) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 01453db..92c9819 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -230,6 +231,14 @@ void dp_display_signa

Re: [Freedreno] [PATCH] drm/msm: remove unused hotplug and edid macros from msm_drv.h

2022-04-15 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-04-15 12:09:42) > Remove unused MSM_DISPLAY_CAP_HOT_PLUG and MSM_DISPLAY_CAP_EDID > macros from msm_drv.h. > > Even if we need these, there are drm equivalent ones present. > > Reported-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boy

Re: [Freedreno] [PATCH 06/12] drm/msm/dpu: make changes to dpu_encoder to support virtual encoder

2022-04-15 Thread Abhinav Kumar
Hi Marijn Looking at msm-next tip, this code has already been refactored in https://gitlab.freedesktop.org/drm/msm/-/commit/ef58e0ad34365e2c8274b74e6e745b8c180ff0d3 So, I will just rebase my changes on msm-next tip and it should address below comments as well. Thanks Abhinav On 4/14/2022 3

[Freedreno] [PATCH] drm/msm: remove unused hotplug and edid macros from msm_drv.h

2022-04-15 Thread Abhinav Kumar
Remove unused MSM_DISPLAY_CAP_HOT_PLUG and MSM_DISPLAY_CAP_EDID macros from msm_drv.h. Even if we need these, there are drm equivalent ones present. Reported-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_drv.h | 4 1 file changed, 4 deletions(-) diff --git

[Freedreno] [PATCH v6] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Changes in v3: -- disable all HDP i