Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi, On Thu, Apr 7, 2022 at 4:46 PM Dmitry Baryshkov wrote: > > > The way I'm arguing it should work is that: > > > > 1. A whole bunch of the DP init code should move to the DP driver's > > probe function. This includes parsing the DT, acquiring clocks, > > getting a handle to our PHY, and IO mapp

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi, On Thu, Apr 7, 2022 at 4:36 PM Dmitry Baryshkov wrote: > > The ps8640 driver looks 'working by coincidence'. It calls > dp_aux_populate, then immediately after the function returns it checks > for the panel. If panel-edp is built as a module, the probe might fail > easily. > The anx7625 drive

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

On Fri, 8 Apr 2022 at 02:35, Doug Anderson wrote: > > Hi, > > On Thu, Apr 7, 2022 at 3:03 PM Abhinav Kumar > wrote: > > > > Hi Doug > > > > Thanks for the response, some comments below. > > > > Abhinav > > On 4/7/2022 1:47 PM, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Apr 7, 2022 at 1:1

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

On Thu, 7 Apr 2022 at 23:11, Abhinav Kumar wrote: > > Hi Doug and Dmitry > > Sorry, but I caught up on this email just now. > > Some comments below. > > Thanks > > Abhinav > On 4/7/2022 10:07 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) > > w

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi, On Thu, Apr 7, 2022 at 3:03 PM Abhinav Kumar wrote: > > Hi Doug > > Thanks for the response, some comments below. > > Abhinav > On 4/7/2022 1:47 PM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar > > wrote: > >> > >> Hi Doug and Dmitry > >> > >> Sorry, but

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi Doug Thanks for the response, some comments below. Abhinav On 4/7/2022 1:47 PM, Doug Anderson wrote: Hi, On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote: Hi Doug and Dmitry Sorry, but I caught up on this email just now. Some comments below. Thanks Abhinav On 4/7/2022 10:07 AM, Dou

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi, On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote: > > Hi Doug and Dmitry > > Sorry, but I caught up on this email just now. > > Some comments below. > > Thanks > > Abhinav > On 4/7/2022 10:07 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC)

[Freedreno] [PATCH] drm/msm: Fix range size vs end confusion

From: Rob Clark The fourth param is size, rather than range_end. Note that we could increase the address space size if we had a way to prevent buffers from spanning a 4G split, mostly just to avoid fw bugs with 64b math. Fixes: 84c31ee16f90 ("drm/msm/a6xx: Add support for per-instance pagetable

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi Doug and Dmitry Sorry, but I caught up on this email just now. Some comments below. Thanks Abhinav On 4/7/2022 10:07 AM, Doug Anderson wrote: Hi, On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) wrote: Hi Dmitry and Doug, Hi, On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshko

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi, On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC) wrote: > > Hi Dmitry and Doug, > > > Hi, > > > > On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov > > wrote: > > > > > > On 05/04/2022 20:02, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Bary

[Freedreno] [PATCH] drm/msm/dp: add fail safe mode outside of event_mutex context

There is possible circular locking dependency detected on event_mutex. To break this possible circular locking, this patch move setting fail safe mode out of event_mutex scope. Fixes: d4aca422539c ("drm/msm/dp: always add fail-safe mode into connector mode list") Signed-off-by: Kuogee Hsieh ---

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

Hi Dmitry and Doug, > Hi, > > On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov > wrote: > > > > On 05/04/2022 20:02, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov > > > wrote: > > >>> 3. For DP and eDP HPD means something a little different. > > >>>

Re: [Freedreno] [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

Hi Dmitry, > > > > > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > > > > > wrote: > > > > > > > > > > > > The panel-edp driver modes needs to be validated differently > > > > > > from DP because the link capabilities are not available for EDP by > that time. > > > > > > > > > > > > Signed-

Re: [Freedreno] [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

> > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > > wrote: > > > > > > > > Some eDP sinks or platform boards will not support hpd. > > > > This patch adds support for those cases. > > > > > > You could say more, like: > > > > > > If we're not using HPD then _both_ the panel node and t

Re: [Freedreno] [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

Hi Dmitry, > > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > > wrote: > > > > > > > > Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP > > > event. > > > > > > Tell me more and put it in the commit message! Why did it used to be > > > necessary and why is it no longer

Re: [Freedreno] [PATCH v3 10/10] drm/msm: Add a way for userspace to allocate GPU iova

On 4/7/22 00:46, Rob Clark wrote: > From: Rob Clark > > The motivation at this point is mainly native userspace mesa driver in a > VM guest. The one remaining synchronous "hotpath" is buffer allocation, > because guest needs to wait to know the bo's iova before it can start > emitting cmdstream/