Re: [Freedreno] [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 21:21, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC) > > wrote: > > > > > > Hi Dmitry, > > > > > > > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > > > > wrote: > > > > > > > > > > The panel-edp driv

Re: [Freedreno] [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 21:32, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > wrote: > > > > > > Some eDP sinks or platform boards will not support hpd. > > > This patch adds support for those cases. > > > > You could say more, like: >

Re: [Freedreno] [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 16:53, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > wrote: > > > > > > Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP > > event. > > > > Tell me more and put it in the commit message! Why did

Re: [Freedreno] [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-04 Thread Doug Anderson
Hi, On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov wrote: > > On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > > > Hi, > > > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > > wrote: > > > > > > On 01/04/2022 02:22, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Wed, Mar 30, 2022

Re: [Freedreno] [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-04 Thread Rob Clark
On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote: > > Hi Abhinav, > > Thank you for the patch. > > On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote: > > For some vendor driver implementations, display hardware can > > be shared between the encoder used for writeback and the physi

Re: [Freedreno] [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > wrote: > > > > Some eDP sinks or platform boards will not support hpd. > > This patch adds support for those cases. > > You could say more, like: > > If we're not using HPD then _both_ the panel node and the eDP controller > node

Re: [Freedreno] [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC) > wrote: > > > > Hi Dmitry, > > > > > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > > > wrote: > > > > > > > > The panel-edp driver modes needs to be validated differently from > > > > DP because the link capabilities

Re: [Freedreno] [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-04-04 Thread Sankeerth Billakanti (QUIC)
> On Thu, 31 Mar 2022 at 14:05, Sankeerth Billakanti > wrote: > > > > Hi Dmitry, > > > > > On 31/03/2022 08:53, Sankeerth Billakanti (QUIC) wrote: > > > > Hi Dmitry, > > > > > > > >> On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti > > > >> wrote: > > > >>> > > > >>> The interrupt register will

Re: [Freedreno] [PATCH v2 4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

2022-04-04 Thread Kuogee Hsieh
On 3/30/2022 3:30 PM, Dmitry Baryshkov wrote: Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather than generic MODE_BAD in case the mode clock is higher than DP_MAX_PIXEL_CLK_KHZ (675 MHz). Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Kuogee Hsieh drivers/gpu/drm/ms

[Freedreno] [PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-04 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Dmitry Baryshkov Signed-off-by: Vi

[Freedreno] [PATCH v6 13/14] drm/msm: Update generated headers

2022-04-04 Thread Vinod Koul
Update headers from mesa commit: commit 28ae397be111c37c6ced397e12d453a7695701bd Author: Vinod Koul Date: Fri Apr 1 16:53:04 2022 +0530 freedreno/registers: update dsi registers to support dsc Display Stream compression (DSC) compresses the display stream in host which

[Freedreno] [PATCH v6 12/14] drm/msm/dsi: add mode valid callback for dsi_mgr

2022-04-04 Thread Vinod Koul
Add a mode valid callback for dsi_mgr for checking mode being valid in case of DSC. For DSC the height and width needs to be multiple of slice, so we check that here Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi.h |

[Freedreno] [PATCH v6 11/14] drm/msm/disp/dpu1: Add DSC support in RM

2022-04-04 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 56 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h

[Freedreno] [PATCH v6 10/14] drm/msm/disp/dpu1: Add support for DSC in topology

2022-04-04 Thread Vinod Koul
For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions up to 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compared to single LM, DSC at full width. The

[Freedreno] [PATCH v6 09/14] drm/msm: Add missing num_dspp field documentation

2022-04-04 Thread Vinod Koul
Somehow documentation for num_dspp was missed, so add that Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/msm_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h inde

[Freedreno] [PATCH v6 08/14] drm/msm/dpu: don't use merge_3d if DSC merge topology is used

2022-04-04 Thread Vinod Koul
From: Dmitry Baryshkov DPU supports different topologies for the case when multiple INTFs are being driven by the single phys_enc. The driver defaults to using 3DMux in such cases. Don't use it if DSC merge is used instead. Suggested-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Signed-off

[Freedreno] [PATCH v6 07/14] drm/msm/disp/dpu1: Add support for DSC in encoder

2022-04-04 Thread Vinod Koul
We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul ---

[Freedreno] [PATCH v6 06/14] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2022-04-04 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 11 ++- drivers/gpu/drm/msm/disp/dpu1/d

[Freedreno] [PATCH v6 05/14] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2022-04-04 Thread Vinod Koul
This adds SDM845 DSC blocks into hw_catalog Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog

[Freedreno] [PATCH v6 04/14] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2022-04-04 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_

[Freedreno] [PATCH v6 03/14] drm/msm/disp/dpu1: Add support for DSC

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++ drivers/gpu/drm/

[Freedreno] [PATCH v6 02/14] drm/msm/dsi: Pass DSC params to drm_panel

2022-04-04 Thread Vinod Koul
When DSC is enabled, we need to get the DSC parameters from the panel driver, so add a dsc parameter in panel to fetch and pass DSC configuration for DSI panels to DPU encoder, which will enable and then configure DSC hardware blocks accordingly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhin

[Freedreno] [PATCH v6 01/14] drm/msm/dsi: add support for dsc data

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu

[Freedreno] [PATCH v6 00/14] drm/msm: Add Display Stream Compression Support

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include DSC data and hardware block enabling for DPU1 then supp

Re: [Freedreno] [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > wrote: > > > > Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP > event. > > Tell me more and put it in the commit message! Why did it used to be > necessary and why is it no longer necessary? Inquiring minds want t

Re: [Freedreno] [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > wrote: > > > > @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev) > > dp_catalog_ctrl_hpd_config(dp->catalog); > > > > > > + if (dp->dp_display.connector_type == > DRM_MODE_CONNECTOR_DisplayPort) > > +

Re: [Freedreno] [PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > wrote: > > > > The source device should ensure the sink is ready before proceeding to > > read the sink capability or performing any aux transactions. The sink > > s/performing/perform > > > will indicate its readiness by asserti