Re: [Freedreno] [PATCH v3 3/5] drm/msm: split the main platform driver

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Currently the msm platform driver is a multiplex handling several cases: - headless GPU-only driver, - MDP4 with flat device nodes, - MDP5/DPU MDSS with all the nodes being children of MDSS node. This results in not-so-perfect code, checking the ha

Re: [Freedreno] [PATCH v3 2/5] drm/msm: remove extra indirection for msm_mdss

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Since now there is just one mdss subdriver, drop all the indirection, make msm_mdss struct completely opaque (and defined inside msm_mdss.c) and call mdss functions directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- driv

Re: [Freedreno] [PATCH v3 1/5] drm/msm: unify MDSS drivers

2022-03-04 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MDP5 and DPU1 both provide the driver handling the MDSS region, which handles the irq domain and (incase of DPU1) adds some init for the UBWC controller. Unify those two pieces of code into a common driver. Signed-off-by: Dmitry Baryshkov Reviewe

Re: [Freedreno] [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-04 Thread Dmitry Baryshkov
On Sat, 5 Mar 2022 at 00:49, Doug Anderson wrote: > On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov > wrote: > > > > On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote: > > > > > > Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > > > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera > > > > wrote: >

Re: [Freedreno] [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-04 Thread Rob Clark
On Thu, Mar 3, 2022 at 7:21 PM Dmitry Baryshkov wrote: > > MSM DRM driver already allows one to compile out the DP or DSI support. > Add support for disabling other features like MDP4/MDP5/DPU drivers or > direct HDMI output support. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshko

Re: [Freedreno] [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Rob Clark
On Fri, Mar 4, 2022 at 1:47 PM Dmitry Baryshkov wrote: > > On Fri, 4 Mar 2022 at 23:23, Rob Clark wrote: > > > > From: Rob Clark > > > > Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry Baryshkov > However see the comment

Re: [Freedreno] [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-04 Thread Doug Anderson
Hi, On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov wrote: > > On Fri, 4 Mar 2022 at 02:56, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > > > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera > > > wrote: > > > > > > > > Kernel clock driver assumes that initial rate is

Re: [Freedreno] [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Dmitry Baryshkov
On Fri, 4 Mar 2022 at 23:23, Rob Clark wrote: > > From: Rob Clark > > Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov However see the comment below. > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + > 1 file cha

[Freedreno] [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-04 Thread Rob Clark
From: Rob Clark Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 02b479

[Freedreno] [PATCH] drm/msm: Fix dirtyfb refcounting

2022-03-04 Thread Rob Clark
From: Rob Clark refcount_t complains about 0->1 transitions, which isn't *quite* what we wanted. So use dirtyfb==1 to mean that the fb is not connected to any output that requires dirtyfb flushing, so that we can keep the underflow and overflow checking. Fixes: 9e4dde28e9cd ("drm/msm: Avoid dir

Re: [Freedreno] [PATCH v1 07/10] drm/msm/adreno: Retry on gpu resume failure

2022-03-04 Thread Akhil P Oommen
On 3/3/2022 2:51 PM, AngeloGioacchino Del Regno wrote: Il 02/03/22 18:27, Akhil P Oommen ha scritto: Retry infinitely on resume failure because there is nothing much we can do if GPU is not ON. Also, this helps us to avoid checking for the return value of pm_runtime_get() to see if GPU is ON. S