Re: [Freedreno] [PATCH] drm/msm: Avoid dirtyfb stalls on video mode displays

2022-02-23 Thread kernel test robot
Hi Rob, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.17-rc5 next-20220223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Kuogee Hsieh
On 2/23/2022 1:33 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-02-23 10:27:26) On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: On 23/02/2022 20:21, Kuogee Hsieh wrote: In the panel device node. Can you please share it too? &soc {     edp_power_supply: edp_power {

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-23 10:27:26) > > On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: > > On 23/02/2022 20:21, Kuogee Hsieh wrote: > > > > In the panel device node. > > > > Can you please share it too? > > > &soc { >     edp_power_supply: edp_power { >     compatible = "re

Re: [Freedreno] [PATCH 2/5] drm/msm/adreno: Generate name from chipid for 7c3

2022-02-23 Thread Akhil P Oommen
On 2/23/2022 6:28 AM, Rob Clark wrote: On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen wrote: Use a gpu name which is sprintf'ed from the chipid for 7c3 gpu instead of hardcoding one. This helps to avoid code churn in case of a gpu rename. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/m

[Freedreno] [PATCH] drm/msm: Avoid dirtyfb stalls on video mode displays (v2)

2022-02-23 Thread Rob Clark
From: Rob Clark Someone on IRC once asked an innocent enough sounding question: Why with xf86-video-modesetting is es2gears limited at 120fps. So I broke out the perfetto tracing mesa MR and took a look. It turns out the problem was drm_atomic_helper_dirtyfb(), which would end up waiting for v

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Dmitry Baryshkov
On Wed, 23 Feb 2022 at 21:27, Kuogee Hsieh wrote: > > > On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: > > On 23/02/2022 20:21, Kuogee Hsieh wrote: > >> > >> On 2/18/2022 6:22 PM, Dmitry Baryshkov wrote: > >>> On Sat, 19 Feb 2022 at 03:55, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Kuogee Hsieh
On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote: On 23/02/2022 20:21, Kuogee Hsieh wrote: On 2/18/2022 6:22 PM, Dmitry Baryshkov wrote: On Sat, 19 Feb 2022 at 03:55, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-18 14:32:53) On 19/02/2022 00:31, Kuogee Hsieh wrote: On 2/11/2022 2:4

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Dmitry Baryshkov
On 23/02/2022 20:21, Kuogee Hsieh wrote: On 2/18/2022 6:22 PM, Dmitry Baryshkov wrote: On Sat, 19 Feb 2022 at 03:55, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-18 14:32:53) On 19/02/2022 00:31, Kuogee Hsieh wrote: On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: There is little poi

Re: [Freedreno] [RFC PATCH v2 2/5] drm/msm/dp: support attaching bridges to the DP encoder

2022-02-23 Thread Kuogee Hsieh
On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: Currently DP driver will allocate panel bridge for eDP panels. This supports only the following topology: - eDP encoder ⇒ eDP panel (wrapped using panel-bridge) Simplify this code to just check if there is any next bridge in the chain (be it a pan

Re: [Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-02-23 Thread Kuogee Hsieh
On 2/18/2022 6:22 PM, Dmitry Baryshkov wrote: On Sat, 19 Feb 2022 at 03:55, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-18 14:32:53) On 19/02/2022 00:31, Kuogee Hsieh wrote: On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: There is little point in having both connector and root brid

Re: [Freedreno] [PATCH] drm/msm: Avoid dirtyfb stalls on video mode displays

2022-02-23 Thread Rob Clark
On Wed, Feb 23, 2022 at 2:00 AM Dmitry Baryshkov wrote: > > On 19/02/2022 22:39, Rob Clark wrote: > > From: Rob Clark > > > > Someone on IRC once asked an innocent enough sounding question: Why > > with xf86-video-modesetting is es2gears limited at 120fps. > > > > So I broke out the perfetto tra

Re: [Freedreno] [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-02-23 Thread Rob Clark
On Tue, Feb 22, 2022 at 7:11 PM Dmitry Baryshkov wrote: > > On 19/02/2022 21:33, Rob Clark wrote: > > From: Rob Clark > > > > Avoid going down devfreq paths on devices where devfreq is not > > initialized. > > > > Reported-by: Linux Kernel Functional Testing > > Reported-by: Anders Roxell > > S

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Bind pingpong block to intf on active ctls in cmd encoder

2022-02-23 Thread Dmitry Baryshkov
On Wed, 23 Feb 2022 at 14:40, Marijn Suijten wrote: > > As per the specification of DPU_CTL_ACTIVE_CFG the configuration of > active blocks should be proactively specified, and the pingpong block is > no different. > > The downstream display driver [1] confirms this by also calling > bind_pingpong

[Freedreno] [PATCH v2] drm/msm/dpu: Bind pingpong block to intf on active ctls in cmd encoder

2022-02-23 Thread Marijn Suijten
As per the specification of DPU_CTL_ACTIVE_CFG the configuration of active blocks should be proactively specified, and the pingpong block is no different. The downstream display driver [1] confirms this by also calling bind_pingpong_blk on CTL_ACTIVE_CFG. Note that this else-if is always entered,

Re: [Freedreno] [PATCH] drm/msm: Avoid dirtyfb stalls on video mode displays

2022-02-23 Thread Dmitry Baryshkov
On 19/02/2022 22:39, Rob Clark wrote: From: Rob Clark Someone on IRC once asked an innocent enough sounding question: Why with xf86-video-modesetting is es2gears limited at 120fps. So I broke out the perfetto tracing mesa MR and took a look. It turns out the problem was drm_atomic_helper_dir