[Freedreno] [PATCH 4/4] drm/msm/dpu: drop INTF_EDP from interface type conditions

2022-02-21 Thread Dmitry Baryshkov
To remove possible confusion between (old) INTF_EDP and newer INTF_DP, stop using INTF_EDP in DPU's code. Until the 8x74/8x84 SoCs are supported by DPU driver, there is no point in using INTF_EDP. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 3 +-- d

[Freedreno] [PATCH 3/4] drm/msm/dpu: drop obsolete INTF_EDP comment

2022-02-21 Thread Dmitry Baryshkov
DPU driver never supported INTF_EDP, so let's drop the obsolete comment. If at some point 8x74/8x84's INTF_EDP is ported to DPU driver, corresponding handling will have to be ported too. Until that time, the comment serves no purpose. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/

[Freedreno] [PATCH 2/4] drm/msm/dpu: drop INTF_TYPE_MAX symbol

2022-02-21 Thread Dmitry Baryshkov
This enum value does not correspond to any of actual interface types, it's not used by the driver, and the value of INTF_WB is greater than INTF_TYPE_MAX. Thus this symbol serves no purpose and can be removed. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 1 -

[Freedreno] [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference

2022-02-21 Thread Dmitry Baryshkov
Based on the discussions on the mailing list, document enum dpu_intf_type and it's controversial fields: INTF_DP and INTF_EDP. INTF_EDP is used for older eDP interface found on msm8x74/msm8x84 INTF_DP is used for both eDP and DP interfaces handled by the msm/dp driver. The DPU driver does not make

[Freedreno] [PATCH 0/4] drm/msm/dpu: clearly document INTF_DP vs INTF_EDP difference

2022-02-21 Thread Dmitry Baryshkov
Recent dicussion on the mailing list [1], [2] outlined a need to document which intf type is used for DP and which one is used for eDP interfaces. This series implements my proposal [3]: - Keep INTF_EDP reserved for 8x74/8x84 - Use INTF_DP for all contemporary DP and eDP ports - Documet this in d

[Freedreno] [PATCH] drm/msm/dpu: wire up MSM8998's DSPP blocks

2022-02-21 Thread Dmitry Baryshkov
The commit adding msm8998 support didn't added msm8998's DSPP blocks configuration, but did not use them in msm8998_cfg_init(). Wire them up to be used for display post processing. Reported-by: kernel test robot Fixes: 94391a14fc27 ("drm/msm/dpu1: Add MSM8998 to hw catalog") Cc: AngeloGioacchino

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-21 Thread Dmitry Baryshkov
On Mon, 21 Feb 2022 at 17:52, Vinod Polimera wrote: > > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti

Re: [Freedreno] [PATCH v2 2/4] drm/bridge: use atomic enable/disable for bridge callbacks

2022-02-21 Thread Dmitry Baryshkov
On Mon, 21 Feb 2022 at 17:52, Vinod Polimera wrote: > > Use atomic enable/disable for bridge callbacks to access certain > states like self-refresh. > > This change avoids panel prepare/unprepare based on self-refresh > state. Please split this into two patches: - change to atomic_* callbacks - i

Re: [Freedreno] [RFC PATCH] drm/msm/dpu1: Add a common DPU1 compatible

2022-02-21 Thread Dmitry Baryshkov
Hi, On Tue, 22 Feb 2022 at 04:26, Konrad Dybcio wrote: > > There is *almost no reason* to keep separate compatibles for different > SoCs utilizing the DPU1 driver, as it checks the HW version at runtime. > > Introduce a common compatible, while not removing the old ones to keep > old DT compatibi

Re: [Freedreno] [PATCH v2 3/4] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-02-21 Thread Dmitry Baryshkov
On Mon, 21 Feb 2022 at 17:52, Vinod Polimera wrote: > > Use atomic variants for encoder callback functions such that > certain states like self-refresh can be accessed as part of > enable/disable sequence. > > Signed-off-by: Kalyan Thota > Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Barys

[Freedreno] 2022 X.Org Board of Directors Elections Nomination period is NOW

2022-02-21 Thread Lyude Paul
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2022 election are now open and will remain open until 23:59 UTC on 06 March 2022. The Board consists of direc

[Freedreno] [RFC PATCH] drm/msm/dpu1: Add a common DPU1 compatible

2022-02-21 Thread Konrad Dybcio
There is *almost no reason* to keep separate compatibles for different SoCs utilizing the DPU1 driver, as it checks the HW version at runtime. Introduce a common compatible, while not removing the old ones to keep old DT compatibility. Signed-off-by: Konrad Dybcio --- Bar some very very very unl

[Freedreno] [PATCH 2/3] drm/msm/a6xx: Add speedbin support for A619 GPU

2022-02-21 Thread Konrad Dybcio
There are various SKUs of A619, ranging from 565 MHz to 850 MHz, depending on the bin. Add support for distinguishing them, so that proper frequency ranges can be applied, depending on the HW. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 18 ++ 1 file

[Freedreno] [PATCH 1/3] drm/msm/adreno: Add A619 support

2022-02-21 Thread Konrad Dybcio
Add support for the Adreno 619 GPU, as found in Snapdragon 690 (SM6350), 480 (SM4350) and 750G (SM7225). Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 ++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 70 +- drivers/gpu/drm/msm/adreno/a6xx_

[Freedreno] [PATCH 3/3] drm/msm/adreno: Fix up formatting

2022-02-21 Thread Konrad Dybcio
Leading spaces are not something checkpatch likes, and it says so when they are present. Use tabs consistently to indent function body and unwrap a 83-char-long line, as 100 is cool nowadays. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 17 - 1 file

[Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-21 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Changes in v2: - Use dp bridge to set psr entry/exit instead of

[Freedreno] [PATCH v2 4/4] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-02-21 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Changes in V2: - Move dp functions to bridge code. - As per Dmitry review suggestions. Signed-off-by: Kalyan Thota Si

[Freedreno] [PATCH v2 3/4] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-02-21 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Changes in v2: - As per review suggestion by Dmitry. --- drivers/gpu/drm/msm/disp/dpu1/dpu

[Freedreno] [PATCH v2 2/4] drm/bridge: use atomic enable/disable for bridge callbacks

2022-02-21 Thread Vinod Polimera
Use atomic enable/disable for bridge callbacks to access certain states like self-refresh. This change avoids panel prepare/unprepare based on self-refresh state. Signed-off-by: Sankeerth Billakanti Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Changes in V2: - As per review sugge

[Freedreno] [PATCH v2 0/4] Add PSR support for eDP

2022-02-21 Thread Vinod Polimera
*** BLURB HERE *** Vinod Polimera (4): drm/msm/dp: Add basic PSR support for eDP drm/bridge: use atomic enable/disable for bridge callbacks drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

[Freedreno] [PATCH 5/5] arm64: dts: qcom: sc7280: Support gpu speedbin

2022-02-21 Thread Akhil P Oommen
Add speedbin fuse and additional OPPs for gpu to support sc7280 SKUs. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom

[Freedreno] [PATCH 4/5] drm/msm/adreno: Expose speedbin to userspace

2022-02-21 Thread Akhil P Oommen
Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace identify the sku. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 +-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21 + drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 +++ 3 fil

[Freedreno] [PATCH 3/5] drm/msm/a6xx: Add support for 7c3 SKUs

2022-02-21 Thread Akhil P Oommen
Add support for 7c3 SKU detection using speedbin fuse. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 17cfad64..f308

[Freedreno] [PATCH 2/5] drm/msm/adreno: Generate name from chipid for 7c3

2022-02-21 Thread Akhil P Oommen
Use a gpu name which is sprintf'ed from the chipid for 7c3 gpu instead of hardcoding one. This helps to avoid code churn in case of a gpu rename. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 - drivers/gpu/drm/msm/adreno/adreno_gpu.c| 14 --

[Freedreno] [PATCH 1/5] drm/msm: Use generic name for gpu resources

2022-02-21 Thread Akhil P Oommen
Use generic name for resources like irq and kthread instead of hardware specific name to make it easier to grep. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/dr

[Freedreno] [PATCH 0/5] Support 7c3 gpu SKUs

2022-02-21 Thread Akhil P Oommen
This series supercedes [1]. Major change in this series is that it is now optional to include a gpu name in the gpu-list. This helps to avoid the confusion when we have different SKUs with different gpu names. And also I am pretty happy that the overall changes are smaller now. [1] https://patchwo

[Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-21 Thread Vinod Polimera
Panels with higher refresh rate will need mdp clk above 300Mhz. Select max frequency for mdp clock during bootup, dpu driver will scale down the clock as per usecase when first update from the framework is received. Signed-off-by: Vinod Polimera --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-

Re: [Freedreno] [REPOST PATCH v4 02/13] drm/msm/dsi: Pass DSC params to drm_panel

2022-02-21 Thread Dmitry Baryshkov
On 10/02/2022 13:34, Vinod Koul wrote: When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Also, fetch and pass DSC configuration for DSI panels to DPU encoder, which will enable and configure DSC hardwar

[Freedreno] [PATCH v2 12/22] drm/msm/mdp5: Remove redundant zpos initialisation

2022-02-21 Thread Maxime Ripard
The mdp KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in mdp5_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so t

Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

2022-02-21 Thread Maxime Ripard
On Mon, Feb 21, 2022 at 08:33:39AM +0100, José Expósito wrote: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Signed-off-by: José Expósito Reviewed-by: Maxime Ripard Maxime s