Re: [Freedreno] [v3 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-18 Thread Rob Herring
On Wed, 19 Jan 2022 02:08:38 +0530, Rajeev Nandan wrote: > In most cases, the default values of DSI PHY tuning registers should be > sufficient as they are fully optimized. However, in some cases where > extreme board parasitics cause the eye shape to degrade, the override > bits can be used to imp

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dpu: simplify clocks handling

2022-01-18 Thread Jessica Zhang
On 11/25/2021 6:35 PM, Dmitry Baryshkov wrote: DPU driver contains code to parse clock items from device tree into special data struct and then enable/disable/set rate for the clocks using that data struct. However the DPU driver itself uses only parsing and enabling/disabling part (the rate sett

Re: [Freedreno] [PATCH v2 4/7] drm/msm/dpu: allow just single IRQ callback

2022-01-18 Thread abhinavk
one> On 2021-08-17 20:30, abhin...@codeaurora.org wrote: On 2021-06-17 15:20, Dmitry Baryshkov wrote: DPU interrupts code allows multiple callbacks per interrut. In reality /interrupt none of the interrupts is shared between blocks (and will probably never be). Drop support for registering m

Re: [Freedreno] [PATCH v18 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-18 10:47:25) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divides the driver life cyc

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-01-18 Thread Abhinav Kumar
On 1/18/2022 12:01 PM, Dmitry Baryshkov wrote: On Tue, 18 Jan 2022 at 22:41, Abhinav Kumar wrote: On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directl

[Freedreno] [v3 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-18 Thread Rajeev Nandan
Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan --- Changes in v2: - New. - Split into generic code and 10nm-specifi

[Freedreno] [v3 3/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-18 Thread Rajeev Nandan
The clock and data lanes of the DSI PHY have a calibration circuitry feature. As per the MSM DSI PHY tuning guidelines, the drive strength tuning can be done by adjusting rescode offset for hstop/hsbot, and the drive level tuning can be done by adjusting the LDO output level for the HSTX drive. Si

[Freedreno] [v3 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-18 Thread Rajeev Nandan
In most cases, the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases where extreme board parasitics cause the eye shape to degrade, the override bits can be used to improve the signal quality. The general guidelines for DSI PHY tuni

[Freedreno] [v3 0/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-18 Thread Rajeev Nandan
This series is to add DSI PHY tuning support in Qualcomm Snapdragon SoCs with 10nm DSI PHY e.g. SC7180 In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye sh

Re: [Freedreno] [PATCH 1/2] drm/msm/dsi: move DSI host powerup to modeset time

2022-01-18 Thread Dmitry Baryshkov
On Tue, 18 Jan 2022 at 22:29, Abhinav Kumar wrote: > > > > On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: > > The DSI subsystem does not fully fall into the pre-enable/enable system > > of callbacks, since typically DSI device bridge drivers expect to be > > able to communicate with DSI devices at

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-01-18 Thread Dmitry Baryshkov
On Tue, 18 Jan 2022 at 22:41, Abhinav Kumar wrote: > > > > On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: > > Currently the DSI driver has two separate paths: one if the next device > > in a chain is a bridge and another one if the panel is connected > > directly to the DSI host. Simplify the code

Re: [Freedreno] [PATCH v2] drm/msm: reduce usage of round_pixclk callback

2022-01-18 Thread Abhinav Kumar
On 1/5/2022 11:06 PM, Dmitry Baryshkov wrote: The round_pixclk() callback returns different rate only on MDP4 in HDMI (DTV) case. Stop using this callback in other cases to simplify mode_valid callbacks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- Changes since v1: -

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-01-18 Thread Abhinav Kumar
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig) and

Re: [Freedreno] [PATCH 1/2] drm/msm/dsi: move DSI host powerup to modeset time

2022-01-18 Thread Abhinav Kumar
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: The DSI subsystem does not fully fall into the pre-enable/enable system of callbacks, since typically DSI device bridge drivers expect to be able to communicate with DSI devices at the pre-enable() callback. The reason is that for some DSI hosts en

[Freedreno] [PATCH v18 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-18 Thread Kuogee Hsieh
Each DP link training contains link training 1 followed by link training 2. There is maximum of 5 retries of DP link training before declared link training failed. It is required to stop link training at end of link training 2 if it is failed so that next link training 1 can start freshly. This pa

[Freedreno] [PATCH v18 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-18 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes in V3: --

[Freedreno] [PATCH v18 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-18 Thread Kuogee Hsieh
DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose and expect DP source return correct checksum. During drm edid read, correct edid checksum is calculated and stored at connector::real_edid_checksum. The problem is struct dp_panel::connector never be assigned, instead the connect

[Freedreno] [PATCH v18 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-18 Thread Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divides the driver life cycle of operation into four states, resume (including

[Freedreno] [PATCH v18 0/4] group dp driver related patches into one series

2022-01-18 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training after