[Freedreno] [PATCH v10 5/5] drm/msm/dp: stop link training after link training 2 failed

2022-01-10 Thread Kuogee Hsieh
Each DP link training contains link training 1 followed by link training 2. There is maximum of 5 retries of DP link training before declared link training failed. It is required to stop link training at end of link training 2 if it is failed so that next link training 1 can start freshly. This pa

[Freedreno] [PATCH v10 4/5] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-10 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes in V3: --

[Freedreno] [PATCH v10 2/5] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-10 Thread Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divides the driver life cycle of operation into four states, resume (including

[Freedreno] [PATCH v10 3/5] drm/msm/dp: populate connector of struct dp_panel

2022-01-10 Thread Kuogee Hsieh
DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose and expect DP source return correct checksum. During drm edid read, correct edid checksum is calculated and stored at connector::real_edid_checksum. The problem is struct dp_panel::connector never be assigned, instead the connect

[Freedreno] [PATCH v10 1/5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2022-01-10 Thread Kuogee Hsieh
Add checking aux read/write status at both dp_link_parse_sink_count() and dp_link_parse_sink_status_filed() to avoid long timeout delay if dp aux read/write failed at timeout due to cable unplugged. Also make sure dp controller had been initialized before start dpcd read and write. Changes in V4:

[Freedreno] [PATCH v10 0/5] group dp driver related patches into one series

2022-01-10 Thread Kuogee Hsieh
Group below 5 dp driver related patches into one series. Kuogee Hsieh (5): drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add

Re: [Freedreno] [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

2022-01-10 Thread Rob Herring
On Mon, 27 Dec 2021 20:59:34 -0800, Bjorn Andersson wrote: > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > add support for this in the DisplayPort driver. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/display/msm/dp-controller.yaml| 1 + > dr

Re: [Freedreno] [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Rob Herring
On Mon, Jan 10, 2022 at 05:06:03PM +0300, Dmitry Baryshkov wrote: > On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > > > In most cases, the default values of DSI PHY tuning registers should be > > sufficient as they are fully optimized. However, in some cases where > > extreme board parasiti

Re: [Freedreno] [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Rob Herring
On Mon, 10 Jan 2022 18:25:35 +0530, Rajeev Nandan wrote: > In most cases, the default values of DSI PHY tuning registers should be > sufficient as they are fully optimized. However, in some cases where > extreme board parasitics cause the eye shape to degrade, the override > bits can be used to imp

Re: [Freedreno] [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-10 Thread Dmitry Baryshkov
On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > Add support for MSM DSI PHY tuning configuration. Current design is > to support drive strength and drive level/amplitude tuning for > 10nm PHY version, but this can be extended to other PHY versions. > > Signed-off-by: Rajeev Nandan > --- >

Re: [Freedreno] [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Dmitry Baryshkov
On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > In most cases, the default values of DSI PHY tuning registers should be > sufficient as they are fully optimized. However, in some cases where > extreme board parasitics cause the eye shape to degrade, the override > bits can be used to improv

[Freedreno] [v2 0/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-10 Thread Rajeev Nandan
This series is to add DSI PHY tuning support in Qualcomm Snapdragon SoCs with 10nm DSI PHY e.g. SC7180 In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye sh

[Freedreno] [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-10 Thread Rajeev Nandan
Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan --- Changes in v2: - New. - Split into generic code and 10nm-specifi

[Freedreno] [v2 3/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-10 Thread Rajeev Nandan
The clock and data lanes of the DSI PHY have a calibration circuitry feature. As per the MSM DSI PHY tuning guidelines, the drive strength tuning can be done by adjusting rescode offset for hstop/hsbot, and the drive level tuning can be done by adjusting the LDO output level for the HSTX drive. Si

[Freedreno] [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Rajeev Nandan
In most cases, the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases where extreme board parasitics cause the eye shape to degrade, the override bits can be used to improve the signal quality. The general guidelines for DSI PHY tuni

Re: [Freedreno] [PATCH v5 03/32] component: Move struct aggregate_device out to header file

2022-01-10 Thread Jani Nikula
On Fri, 07 Jan 2022, Stephen Boyd wrote: > Quoting Jani Nikula (2022-01-07 05:07:59) >> On Thu, 06 Jan 2022, Stephen Boyd wrote: >> > This allows aggregate driver writers to use the device passed to their >> > probe/remove/shutdown functions properly instead of treating it as an >> > opaque point