Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-30 Thread Dmitry Baryshkov
On Fri, 31 Dec 2021 at 07:48, Dmitry Baryshkov wrote: > > HI, > > On Wed, 29 Dec 2021 at 07:12, Bjorn Andersson > wrote: > > > > On Thu 25 Nov 20:35 CST 2021, Dmitry Baryshkov wrote: > > > > > In order to simplify DP code, drop hand-coded loops over clock arrays, > > > replacing them with clk_bul

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-30 Thread Dmitry Baryshkov
HI, On Wed, 29 Dec 2021 at 07:12, Bjorn Andersson wrote: > > On Thu 25 Nov 20:35 CST 2021, Dmitry Baryshkov wrote: > > > In order to simplify DP code, drop hand-coded loops over clock arrays, > > replacing them with clk_bulk_* functions. > > > > I've yet to debug this, but applying the two patche

[Freedreno] [PATCH] drm/msm/dsi: Fix missing put_device() call in dsi_get_phy

2021-12-30 Thread Miaoqian Lin
If of_find_device_by_node() succeeds, dsi_get_phy() doesn't a corresponding put_device(). Thus add put_device() to fix the exception handling. Fixes: ec31abf ("drm/msm/dsi: Separate PHY to another platform device") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/msm/dsi/dsi.c | 7 ++- 1 file

[Freedreno] [v1 2/2] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2021-12-30 Thread Rajeev Nandan
In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye shape to degrade), the override bits can be used to improve the signal quality. As per the MSM DSI PHY (1

[Freedreno] [v1 1/2] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2021-12-30 Thread Rajeev Nandan
Add 10nm dsi phy tuning properties for phy drive strength and phy drive level adjustemnt. Signed-off-by: Rajeev Nandan --- .../devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/

[Freedreno] [v1 0/2] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2021-12-30 Thread Rajeev Nandan
This series is to add DSI PHY tuning support in Qualcomm Snapdragon SoCs with 10nm DSI PHY e.g. SC7180 In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye sh

Re: [Freedreno] [v1 2/2] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2021-12-30 Thread Dmitry Baryshkov
On Thu, 30 Dec 2021 at 12:25, Rajeev Nandan wrote: > > In most cases the default values of DSI PHY tuning registers > should be sufficient as they are fully optimized. However, in > some cases (for example, where extreme board parasitics cause > the eye shape to degrade), the override bits can be

Re: [Freedreno] [v1 1/2] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2021-12-30 Thread Dmitry Baryshkov
On Thu, 30 Dec 2021 at 12:25, Rajeev Nandan wrote: > > Add 10nm dsi phy tuning properties for phy drive strength and > phy drive level adjustemnt. > > Signed-off-by: Rajeev Nandan > --- > .../devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 19 > +++ > 1 file changed, 19 inse

Re: [Freedreno] [v1 1/2] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2021-12-30 Thread Dmitry Baryshkov
On Thu, 30 Dec 2021 at 12:25, Rajeev Nandan wrote: > > Add 10nm dsi phy tuning properties for phy drive strength and > phy drive level adjustemnt. > > Signed-off-by: Rajeev Nandan > --- > .../devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 19 > +++ > 1 file changed, 19 inse