Re: [Freedreno] [PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-09 Thread Dmitry Baryshkov
On 10/12/2021 01:27, Abhinav Kumar wrote: On 12/9/2021 2:18 PM, Abhinav Kumar wrote: On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to dpu_hw_sspp.c, where it belongs. Signed-off-by: Dmitry Baryshko

Re: [Freedreno] [PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-09 Thread Abhinav Kumar
On 12/9/2021 2:18 PM, Abhinav Kumar wrote: On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to dpu_hw_sspp.c, where it belongs. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu

Re: [Freedreno] [PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to dpu_hw_sspp.c, where it belongs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 67 + drivers/gp

Re: [Freedreno] [PATCH v1 7/8] drm/msm/dpu: simplify DPU's regset32 code

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: Squash dpu_debugfs_setup_regset32() into dpu_debugfs_create_regset32(). it makes little sense to have separate function to just setup the structure. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v7 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-09 Thread Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divides the driver life cycle of operation into four states, resume (including

[Freedreno] [PATCH v7 1/2] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-09 Thread Kuogee Hsieh
Add checking aux read/write status at both dp_link_parse_sink_count() and dp_link_parse_sink_status_filed() to avoid long timeout delay if dp aux read/write failed at timeout due to cable unplugged. Also make sure dp controller had been initialized before start dpcd read and write. Changes in V4:

Re: [Freedreno] [PATCH v1 6/8] drm/msm/dpu: stop manually removing debugfs files for the DPU CRTC

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: DRM code handles removing all debugfs recursively. Drop CRTC-specific code to perform that. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH v1 5/8] drm/msm/dpu: stop manually removing debugfs files for the DPU plane

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: DRM code handles removing all debugfs recursively. Drop plane-specific code to perform that. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 28 --- 1 file chang

Re: [Freedreno] [PATCH v1 4/8] drm/msm/dpu: drop plane's default_scaling debugfs file

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: Proper support for the 'default_scaling' debugfs file was removed during DPU driver pre-merge cleanup. Remove leftover file. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 -

Re: [Freedreno] [PATCH v1 3/8] drm/msm/dpu: make danger_status/safe_status readable

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: Change \t to \n in the print format to stop putting all SSPP status in a single line. Splitting it to one SSPP per line is much more readable. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_k

Re: [Freedreno] [PATCH v1 2/8] drm/msm/dpu: fix safe status debugfs file

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: Make safe_status debugfs fs file actually return safe status rather than danger status data. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1

Re: [Freedreno] [PATCH v1 1/8] drm/msm/dpu: move disable_danger out of plane subdir

2021-12-09 Thread Abhinav Kumar
On 12/1/2021 2:26 PM, Dmitry Baryshkov wrote: The disable_danger debugfs file is not related to a single plane. Instead it is used by all registered planes. Move it from plane subtree to the global subtree next to danger_status and safe_status files, so that the new file supplements them. the

[Freedreno] [PATCH] drm/msm/a6xx: Skip crashdumper state if GPU needs_hw_init

2021-12-09 Thread Rob Clark
From: Rob Clark I am seeing some crash logs which imply that we are trying to use crashdumper hw to read back GPU state when the GPU isn't initialized. This doesn't go well (for example, GPU could be in 32b address mode and ignoring the upper bits of buffer that it is trying to dump state to). I

[Freedreno] [PATCH v7] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-09 Thread Kuogee Hsieh
From: Kuogee Hsieh The previous patch from Fixes (aff188feb5e1) added functions to support V4 phy. But it did not update voltage and pre-emphasis tables accordingly. This patch add v4 voltage and pre-emphasis swing tables to complete v4 phy implementation. Both voltage and pre-emphasis swing leve

Re: [Freedreno] [PATCH 1/2] drm/ bridge: tc358762: move bridge init to enable callback

2021-12-09 Thread Laurent Pinchart
Hi Dmitry, (CC'ing Tomi) On Thu, Dec 09, 2021 at 07:53:43PM +0300, Dmitry Baryshkov wrote: > On Fri, 26 Nov 2021 at 14:56, Dave Stevenson wrote: > > On Fri, 26 Nov 2021 at 00:32, Dmitry Baryshkov wrote: > > > > > > During the pre_enable time the previous bridge (e.g. DSI host) might be > > > not

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-12-09 Thread AngeloGioacchino Del Regno
Il 02/10/21 00:33, Dmitry Baryshkov ha scritto: On 11/09/2021 19:39, AngeloGioacchino Del Regno wrote: In function dpu_encoder_phys_cmd_wait_for_commit_done we are always checking if the relative CTL is started by waiting for an interrupt to fire: it is fine to do that, but then sometimes we cal

Re: [Freedreno] [PATCH 1/2] drm/ bridge: tc358762: move bridge init to enable callback

2021-12-09 Thread Dmitry Baryshkov
Hi Dave, On Fri, 26 Nov 2021 at 14:56, Dave Stevenson wrote: > > Hi Dmitry > > On Fri, 26 Nov 2021 at 00:32, Dmitry Baryshkov > wrote: > > > > During the pre_enable time the previous bridge (e.g. DSI host) might be > > not initialized yet. Move the regulator enablement and bridge init to > > te

Re: [Freedreno] [PATCH v6] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-09 Thread Vinod Koul
On 08-12-21, 13:22, Kuogee Hsieh wrote: > From: Kuogee Hsieh > > "add support for sm8250-usb3-dp phy" patch added functions to support V4 ^^ why this leading quote here? > phy. But it did not update voltage and pre-emphasis tables accordingly. > This patch add v4 voltage and pre-emphasis swing

Re: [Freedreno] [PATCH] drm/msm/dp: Move debugfs files into subdirectory

2021-12-09 Thread abhinavk
On 2021-10-18 11:36, Bjorn Andersson wrote: On Mon 18 Oct 11:07 PDT 2021, abhin...@codeaurora.org wrote: Hi Bjorn On 2021-10-17 09:42, Bjorn Andersson wrote: > On Fri 15 Oct 16:53 PDT 2021, abhin...@codeaurora.org wrote: > > > On 2021-10-15 16:17, Bjorn Andersson wrote: > > > In the cleanup pa

Re: [Freedreno] [PATCH v6] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-08 12:36:24) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divided the driver life cyc

Re: [Freedreno] [PATCH v4 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-12-09 Thread Stephen Boyd
Quoting Sean Paul (2021-11-04 20:04:31) > From: Sean Paul > > This patch adds HDCP 1.x support to msm DP connectors using the new HDCP $ git grep "This patch" -- Documentation/process/ > helpers. > > Cc: Stephen Boyd > Cc: Abhinav Kumar > Signed-off-by: Sean Paul > Link: > https://patchwork

Re: [Freedreno] [PATCH v5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-08 09:41:02) > Add checking aux read/write status at both dp_link_parse_sink_count() > and dp_link_parse_sink_status_filed() to avoid long timeout delay if > dp aux read/write failed at timeout due to cable unplugged. > > Changes in V4: > -- split this patch as stand a