Re: [Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver

2021-11-19 Thread Abhinav Kumar
Hi Joe Thanks for the feedback. On 11/19/2021 7:34 PM, Joe Perches wrote: On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote: Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar []

[Freedreno] [PATCH v2] MAINTAINERS: update designated reviewer entry for MSM DRM driver

2021-11-19 Thread Abhinav Kumar
Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b33791..c27d8f7 100644 --- a/MAINTAIN

Re: [Freedreno] [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency

2021-11-19 Thread Krzysztof Wilczyński
Hi Jakub, [...] > drivers/pci/controller/dwc/pci-exynos.c | 1 + > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + Happy to give Acked-by: Krzysztof Wilczyński for the the PCI drivers. Thank you! Krzysztof

[Freedreno] [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency

2021-11-19 Thread Jakub Kicinski
cgroup.h (therefore swap.h, therefore half of the universe) includes bpf.h which in turn includes module.h and slab.h. Since we're about to get rid of that dependency we need to clean things up. Signed-off-by: Jakub Kicinski --- CC: ax...@kernel.dk CC: maarten.lankho...@linux.intel.com CC: mrip..

Re: [Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver

2021-11-19 Thread Joe Perches
On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote: > Adding myself as a designated reviewer to assist with the > code reviews for the changes coming into MSM DRM. > > Acked-by: Rob Clark > Signed-off-by: Abhinav Kumar [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -5938,6 +5938,7 @@ M:

Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints

2021-11-19 Thread Doug Anderson
Hi, On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote: > > +void msm_devfreq_boost(struct msm_gpu *gpu, unsigned factor) > +{ > + struct msm_gpu_devfreq *df = &gpu->devfreq; > + unsigned long freq; > + > + freq = get_freq(gpu); > + freq *= factor; > + freq /= HZ_PER_KH

Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time

2021-11-19 Thread Doug Anderson
Hi, On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote: > > From: Rob Clark > > This was supposed to be a relative timer, not absolute. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson

[Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver

2021-11-19 Thread Abhinav Kumar
Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b33791..503112d 100644 --- a/MAINTAIN

[Freedreno] mailmap: add and update email addresses

2021-11-19 Thread Abhinav Kumar
Add and also update the email addresses to prepare for the transition to the new ones. Signed-off-by: Abhinav Kumar --- .mailmap | 8 1 file changed, 8 insertions(+) diff --git a/.mailmap b/.mailmap index 6e84911..92f4cd7 100644 --- a/.mailmap +++ b/.mailmap @@ -10,10 +10,12 @@ # Plea

Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time

2021-11-19 Thread Rob Clark
On Fri, Nov 19, 2021 at 2:46 PM Rob Clark wrote: > > From: Rob Clark > > This was supposed to be a relative timer, not absolute. > Fixes: 658f4c829688 ("drm/msm/devfreq: Add 1ms delay before clamping freq") > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- > 1 f

[Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints

2021-11-19 Thread Rob Clark
From: Rob Clark Re-work the boost and idle clamping to use PM QoS requests instead, so they get aggreggated with other requests (such as cooling device). This does have the minor side-effect that devfreq sysfs min_freq/ max_freq files now reflect the boost and idle clamping, as they show (despit

[Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time

2021-11-19 Thread Rob Clark
From: Rob Clark This was supposed to be a relative timer, not absolute. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c index 43

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-19 Thread Kuogee Hsieh
On 11/18/2021 5:20 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-11-09 13:38:13) From: Kuogee Hsieh Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and lim

Re: [Freedreno] [PATCH igt v3 0/4] msm: Add tests for gpu fault handling

2021-11-19 Thread Rob Clark
On Fri, Nov 19, 2021 at 3:56 AM Petri Latvala wrote: > > On Mon, Nov 15, 2021 at 04:30:38PM -0800, Rob Clark wrote: > > From: Rob Clark > > > > The first patch adds a easy way to write debugfs files (needed to > > disable hw fault detection, so we can test the sw timeout fallback). > > The second

Re: [Freedreno] [PATCH igt v3 0/4] msm: Add tests for gpu fault handling

2021-11-19 Thread Petri Latvala
On Mon, Nov 15, 2021 at 04:30:38PM -0800, Rob Clark wrote: > From: Rob Clark > > The first patch adds a easy way to write debugfs files (needed to > disable hw fault detection, so we can test the sw timeout fallback). > The second adds some helpers for cmdstream building. And the third > adds th