Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-09 13:38:13) > From: Kuogee Hsieh > > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch div

Re: [Freedreno] [PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane

2021-11-18 Thread Rob Clark
On Fri, Oct 22, 2021 at 4:35 AM Dmitry Baryshkov wrote: > > Hi, > > On Fri, 22 Oct 2021 at 02:53, wrote: > > > > On 2021-09-30 07:00, Dmitry Baryshkov wrote: > > > In preparations of virtualizing the dpu_plane rip out debugfs support > > > from dpu_plane (as it is mostly used to expose plane's pi

Re: [Freedreno] [PATCH 4/4] drm/msm/a6xx: Capture gmu log in devcoredump

2021-11-18 Thread kernel test robot
Hi Akhil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next v5.16-rc1 next-2028] [If your patch is applied to the wrong git tree, kindly drop us a

[Freedreno] [PATCH 4/4] drm/msm/a6xx: Capture gmu log in devcoredump

2021-11-18 Thread Akhil P Oommen
Capture gmu log in coredump to enhance debugging. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 41 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 ++ 3 files changed, 44 inser

[Freedreno] [PATCH 3/4] drm/msm/a6xx: Fix uinitialized use of gpu_scid

2021-11-18 Thread Akhil P Oommen
Avoid a possible uninitialized use of gpu_scid variable to fix the below smatch warning: drivers/gpu/drm/msm/adreno/a6xx_gpu.c:1480 a6xx_llc_activate() error: uninitialized symbol 'gpu_scid'. Reported-by: Dan Carpenter Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adren

[Freedreno] [PATCH 2/4] drm/msm: Fix null ptr access msm_ioctl_gem_submit()

2021-11-18 Thread Akhil P Oommen
Fix the below null pointer dereference in msm_ioctl_gem_submit(): 26545.260705: Call trace: 26545.263223:kref_put+0x1c/0x60 26545.266452:msm_ioctl_gem_submit+0x254/0x744 26545.270937:drm_ioctl_kernel+0xa8/0x124 26545.274976:drm_ioctl+0x21c/0x33c 26545.278478:drm_compat_

[Freedreno] [PATCH 1/4] drm/msm: Increase gpu boost interval

2021-11-18 Thread Akhil P Oommen
Currently, we boost gpu freq after 25ms of inactivity. This regresses some of the 30 fps usecases where the workload on gpu (at 33ms internval) is very small which it can finish at the lowest OPP before the deadline. Lets increase this inactivity threshold to 50ms (same as the current devfreq inter