[Freedreno] [PATCH] drm/msm: Fix mmap to include VM_IO and VM_DONTDUMP

2021-11-10 Thread Douglas Anderson
In commit 510410bfc034 ("drm/msm: Implement mmap as GEM object function") we switched to a new/cleaner method of doing things. That's good, but we missed a little bit. Before that commit, we used to _first_ run through the drm_gem_mmap_obj() case where `obj->funcs->mmap()` was NULL. That meant tha

Re: [Freedreno] [PATCH igt v2 3/3] msm: Add recovery tests

2021-11-10 Thread Rob Clark
On Wed, Nov 10, 2021 at 10:37 AM Rob Clark wrote: > > From: Rob Clark > > Add tests to exercise: > > 1. sw hangcheck timeout > 2. gpu fault (hang) recovery > 3. iova fault recovery > > Signed-off-by: Rob Clark > --- > lib/igt_msm.h| 3 + > tests/meson.build| 1 + > tests/msm_rec

[Freedreno] [PATCH igt v2 3/3] msm: Add recovery tests

2021-11-10 Thread Rob Clark
From: Rob Clark Add tests to exercise: 1. sw hangcheck timeout 2. gpu fault (hang) recovery 3. iova fault recovery Signed-off-by: Rob Clark --- lib/igt_msm.h| 3 + tests/meson.build| 1 + tests/msm_recovery.c | 172 +++ 3 files changed,

[Freedreno] [PATCH igt v2 1/3] lib/igt_debugfs: Add helper for writing debugfs files

2021-11-10 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- v2: Fix headerdoc comments lib/igt_debugfs.c | 17 + lib/igt_debugfs.h | 13 + 2 files changed, 30 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index a5bb95ca..dd6f2995 100644 --- a/lib/igt_debugfs.c

[Freedreno] [PATCH igt v2 2/3] msm: Add helper for cmdstream building and submission

2021-11-10 Thread Rob Clark
From: Rob Clark A pretty minimal subset compared to what a full gallium driver would need, but OTOH for igt tests we should only need to emit fairly basic command stream. Signed-off-by: Rob Clark --- lib/igt_msm.c | 102 ++ lib/igt_msm.h | 48 ++

[Freedreno] [PATCH igt v2 0/3] msm: Add tests for gpu fault handling

2021-11-10 Thread Rob Clark
From: Rob Clark The first patch adds a easy way to write debugfs files (needed to disable hw fault detection, so we can test the sw timeout fallback). The second adds some helpers for cmdstream building. And the third adds the new tests. v2: Fix headerdoc comments in first patch Rob Clark (3):

[Freedreno] [PATCH 3/3] drm/msm: some features need to be forced to rely on COMMON_CLK

2021-11-10 Thread Jackie Liu
From: Jackie Liu In fact, this will not cause any problems, but when COMPILE_TEST is enabled, COMMON_CLK may not be selected, The CI system will report some compilation errors. even if that is not issue, but we better fix him. [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.o

[Freedreno] [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK

2021-11-10 Thread Jackie Liu
From: Jackie Liu HDMI 8996 PHY/PLL support need common clk. avoid like: [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3e0): undefined reference to `msm_hdmi_phy_8996_cfg' Fixes: e17afdceb4f2 ("drm/msm/hdmi: HDMI 8996 PHY/PLL support") Reported-by: kernelbot Signed-

[Freedreno] [PATCH 2/3] drm/msm/dp: displayPort driver need algorithm rational

2021-11-10 Thread Jackie Liu
From: Jackie Liu Let's select RATIONAL with dp driver. avoid like: [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dp/dp_catalog.o: in function `dp_catalog_ctrl_config_msa': dp_catalog.c:(.text+0x57e): undefined reference to `rational_best_approximation' Fixes: c943b4948b58 ("drm/msm/dp: add di

Re: [Freedreno] [PATCH v4 07/13] drm/msm: Track "seqno" fences by idr

2021-11-10 Thread Rob Clark
On Wed, Nov 10, 2021 at 7:28 AM Akhil P Oommen wrote: > > On 7/28/2021 6:36 AM, Rob Clark wrote: > > From: Rob Clark > > > > Previously the (non-fd) fence returned from submit ioctl was a raw > > seqno, which is scoped to the ring. But from UABI standpoint, the > > ioctls related to seqno fences

Re: [Freedreno] [PATCH v4 07/13] drm/msm: Track "seqno" fences by idr

2021-11-10 Thread Akhil P Oommen
On 7/28/2021 6:36 AM, Rob Clark wrote: From: Rob Clark Previously the (non-fd) fence returned from submit ioctl was a raw seqno, which is scoped to the ring. But from UABI standpoint, the ioctls related to seqno fences all specify a submitqueue. We can take advantage of that to replace the se

[Freedreno] [PATCH linux-next] drm/msm/dp: remove unneeded variable

2021-11-10 Thread cgel . zte
From: Changcheng Deng Fix the following coccicheck review: ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable Remove unneeded variable used to store return value. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- drivers/gpu/drm/msm/dp/dp_debug.c | 3 +-- 1 file changed, 1 inser

Re: [Freedreno] [igt-dev] [PATCH igt 1/3] lib/igt_debugfs: Add helper for writing debugfs files

2021-11-10 Thread Petri Latvala
On Tue, Nov 09, 2021 at 10:09:03AM -0800, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > lib/igt_debugfs.c | 16 > lib/igt_debugfs.h | 12 > 2 files changed, 28 insertions(+) > > diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c > index a

[Freedreno] [PATCH v4] drm/msm: use compatible lists to find mdp node

2021-11-10 Thread Krishna Manikandan
In the current implementation, substring comparison using device node name is used to find mdp node during driver probe. Use compatible string list instead of node name to get mdp node from the parent mdss node. Signed-off-by: Krishna Manikandan Reviewed-by: Stephen Boyd Changes in v2: - Use