Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Bjorn Andersson
On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > > > wrote: [..] > > > > I am a bit confused. We don't define a power domain for gpu in dt, > >

Re: [Freedreno] [PATCH] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL

2021-09-07 Thread abhinavk
On 2021-09-06 13:25, Marijn Suijten wrote: div_u64_rem provides the result of the divison and additonally the remainder; don't use this function to solely calculate the remainder while calculating the division again with div_u64. A similar improvement was applied earlier to the 10nm pll in 5c191

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-09-07 Thread khsieh
On 2021-08-30 09:58, Lyude Paul wrote: On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: On 2021-08-25 09:26, Lyude Paul wrote: > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > like it > just hasn't trickled down to linus's branch quite yet. Hi Stephen B,

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-07 Thread Jeffrey Hugo
On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno wrote: > > Bringup functionality for MSM8998 in the DPU, driver which is mostly > the same as SDM845 (just a few variations). > > Signed-off-by: AngeloGioacchino Del Regno > I don't seem to see a cover letter for this series. Eh, there

Re: [Freedreno] [PATCH 3/3] dt-bindings: display: msm: Add binding for msm8998 dpu

2021-09-07 Thread Rob Herring
On Wed, Sep 01, 2021 at 08:11:38PM +0200, AngeloGioacchino Del Regno wrote: > Add yaml binding for msm8998 dpu1 support. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/display/msm/dpu-msm8998.yaml | 220 ++ > 1 file changed, 220 insertions(+) > create

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Bjorn Andersson
On Mon 09 Aug 14:08 PDT 2021, Rob Clark wrote: > On Mon, Aug 9, 2021 at 1:35 PM Caleb Connolly > wrote: > > > > > > > > On 09/08/2021 18:58, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen > > > wrote: > > >> > > >> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > >>> > > >

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Rob Clark
On Tue, Sep 7, 2021 at 1:25 AM Amit Pundir wrote: > > On Tue, 7 Sept 2021 at 07:11, Rob Clark wrote: > > > > One thing I thought of, which would be worth ruling out, is whether > > this issue only occurs with freq changes immediately after resuming > > the GPU, vs freq changes in general. Could

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Amit Pundir
On Tue, 7 Sept 2021 at 07:11, Rob Clark wrote: > > One thing I thought of, which would be worth ruling out, is whether > this issue only occurs with freq changes immediately after resuming > the GPU, vs freq changes in general. Could you try the below patch. > And if it "fixes" the issue, then tr

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Amit Pundir
On Tue, 7 Sept 2021 at 02:53, Rob Clark wrote: > > On Mon, Sep 6, 2021 at 1:50 PM Rob Clark wrote: > > > > > > ok, I guess it is at least not a board specific thing (ie. won't need > > to introduce some dt binding).. > > > > It would be nice to know what the maximum we can safely increase freq >