Re: [Freedreno] [PATCH igt v3 3/3] msm: Add submit ioctl tests

2021-08-30 Thread Petri Latvala
On Mon, Aug 30, 2021 at 09:22:32AM -0700, Rob Clark wrote: > From: Rob Clark > > Add an initial set of tests for the submit ioctl. > > v2: Add NULL inits, igt_describe() > > Signed-off-by: Rob Clark > --- > tests/meson.build | 1 + > tests/msm_submit.c | 194 +++

Re: [Freedreno] [PATCH igt v3 2/3] msm: Add helper library

2021-08-30 Thread Petri Latvala
On Mon, Aug 30, 2021 at 09:22:31AM -0700, Rob Clark wrote: > From: Rob Clark > > Handle some of the boilerplate for tests. > > v2: fix comment, drop unnecessary drm_open_driver_render() error > handling, docs fixes, drop igt_msm_pipe_get_param() (for now), > handle NULL in destructors >

Re: [Freedreno] [PATCH v2] drm/msm: Change dpu_crtc_get_vblank_counter to use vsync count.

2021-08-30 Thread abhinavk
On 2021-08-30 11:13, Mark Yacoub wrote: From: Mark Yacoub [why] vsync_cnt atomic counter increments for every hw vsync. On the other hand, frame count is a register that increments when the frame gets actually pushed out. We cannnot read this register whenever the timing engine is off, but vbla

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add Display Port node

2021-08-30 Thread Bjorn Andersson
On Mon 30 Aug 11:04 CDT 2021, Kuogee Hsieh wrote: > Changes in v2: > -- break this patch into 3 patches > It's only the DRM tree that want the changelog above '---', please move it down. Also, why isn't this "patch n/3" if there's three patches? > Signed-off-by: Kuogee Hsieh > --- > arch/arm

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add Display Port node

2021-08-30 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-30 09:04:49) > Changes in v2: > -- break this patch into 3 patches Are there two more somewhere? > > Signed-off-by: Kuogee Hsieh > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 88 > +++- > 1 file changed, 87 insertions(+), 1 deletio

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Marijn Suijten
On 2021-08-30 15:53:10, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-08-30 15:45:42) > > Hi Stephen, > > > > On 2021-08-30 15:16:13, Stephen Boyd wrote: > > > Quoting Marijn Suijten (2021-08-30 11:24:44) > > > > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > > > > glo

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread Stephen Boyd
Quoting Lyude Paul (2021-08-30 09:58:01) > On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: > > On 2021-08-25 09:26, Lyude Paul wrote: > > > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > > > like it > > > just hasn't trickled down to linus's branch quite ye

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Stephen Boyd
Quoting Marijn Suijten (2021-08-30 15:45:42) > Hi Stephen, > > On 2021-08-30 15:16:13, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 11:24:44) > > > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > > > global name, most of which don't exist or have been renamed.

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Marijn Suijten
Hi Stephen, On 2021-08-30 15:16:13, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-08-30 11:24:44) > > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > > global name, most of which don't exist or have been renamed. These > > clock drivers seem to function fine without th

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Stephen Boyd
Quoting Marijn Suijten (2021-08-30 11:24:44) > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > global name, most of which don't exist or have been renamed. These > clock drivers seem to function fine without that except the 14nm driver > for the sdm6xx [1]. > > At the same

[Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-08-30 Thread Marijn Suijten
The DSI PHY/PLL was relying on a global "xo" clock to be found, but the real clock is named "xo_board" in the DT. The standard nowadays is to never use global clock names anymore but require the firmware (DT) to provide every clock binding explicitly with .fw_name. The DSI PLLs have since been co

[Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Marijn Suijten
All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't exist or have been renamed. These clock drivers seem to function fine without that except the 14nm driver for the sdm6xx [1]. At the same time all DTs provide a "ref" clock as per the requirement

[Freedreno] [PATCH v2 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-08-30 Thread Marijn Suijten
All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't exist or have been renamed. These clock drivers seem to function fine without that except the 14nm driver for the sdm6xx [1]. At the same time all DTs provide a "ref" clock as per the requirement

[Freedreno] [PATCH v2] drm/msm: Change dpu_crtc_get_vblank_counter to use vsync count.

2021-08-30 Thread Mark Yacoub
From: Mark Yacoub [why] vsync_cnt atomic counter increments for every hw vsync. On the other hand, frame count is a register that increments when the frame gets actually pushed out. We cannnot read this register whenever the timing engine is off, but vblank counter should still return a valid num

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread Lyude Paul
On Mon, 2021-08-30 at 08:56 -0700, khs...@codeaurora.org wrote: > On 2021-08-25 09:26, Lyude Paul wrote: > > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems > > like it > > just hasn't trickled down to linus's branch quite yet. > > Hi Stephen B, > > Would you mind back por

[Freedreno] [PATCH igt v3 3/3] msm: Add submit ioctl tests

2021-08-30 Thread Rob Clark
From: Rob Clark Add an initial set of tests for the submit ioctl. v2: Add NULL inits, igt_describe() Signed-off-by: Rob Clark --- tests/meson.build | 1 + tests/msm_submit.c | 194 + 2 files changed, 195 insertions(+) create mode 100644 tests/ms

[Freedreno] [PATCH igt v3 2/3] msm: Add helper library

2021-08-30 Thread Rob Clark
From: Rob Clark Handle some of the boilerplate for tests. v2: fix comment, drop unnecessary drm_open_driver_render() error handling, docs fixes, drop igt_msm_pipe_get_param() (for now), handle NULL in destructors Signed-off-by: Rob Clark --- .../igt-gpu-tools/igt-gpu-tools-docs.xml

[Freedreno] [PATCH igt v3 1/3] drmtest: Add DRIVER_MSM support

2021-08-30 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Petri Latvala --- lib/drmtest.c | 3 +++ lib/drmtest.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index e1f9b115..29cb3f4c 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -179,6 +179,7 @@ static co

[Freedreno] [PATCH igt v3 0/3] Initial igt tests for drm/msm ioctls

2021-08-30 Thread Rob Clark
From: Rob Clark Add an initial set of tests for the gpu SUBMIT ioctl. There is plenty more we can add, but need to start somewhere. Rob Clark (3): drmtest: Add DRIVER_MSM support msm: Add helper library msm: Add submit ioctl tests .../igt-gpu-tools/igt-gpu-tools-docs.xml | 1 + l

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add Display Port node

2021-08-30 Thread Kuogee Hsieh
Changes in v2: -- break this patch into 3 patches Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 88 +++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-30 Thread Doug Anderson
Hi, On Sat, Aug 28, 2021 at 7:40 AM Bjorn Andersson wrote: > > On Fri 27 Aug 15:52 CDT 2021, Doug Anderson wrote: > > > Hi, > > > > On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson > > wrote: > > > > > > +static int dp_parser_find_panel(struct dp_parser *parser) > > > +{ > > > + struct devi

Re: [Freedreno] [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-08-30 Thread khsieh
On 2021-08-25 09:26, Lyude Paul wrote: The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems like it just hasn't trickled down to linus's branch quite yet. Hi Stephen B, Would you mind back porting this patch to V5.10 branch? It will have lots of helps for us to support displ

Re: [Freedreno] [PATCH 2/3] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-08-30 Thread Marijn Suijten
Hi Dmitry, On Mon, Aug 30, 2021 at 04:17:32AM +0300, Dmitry Baryshkov wrote: > On Mon, 30 Aug 2021 at 00:53, Marijn Suijten > wrote: > > > > Hi Dmitry, > > > > On 8/29/21 10:39 PM, Dmitry Baryshkov wrote: > > > Hi, > > > > > > On Sun, 29 Aug 2021 at 23:30, Marijn Suijten > > > wrote: > > >> > >

Re: [Freedreno] [PATCH v5 16/20] drm/msm: Don't break exclusive fence ordering

2021-08-30 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 09:16:25AM -0700, Rob Clark wrote: > On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > > > There's only one exclusive slot, and we must not break the ordering. > > > > Adding a new exclusive fence drops all previous fences from the > > dma_resv. To avoid violating the

Re: [Freedreno] [PATCH v5 12/20] drm/msm: Use scheduler dependency handling

2021-08-30 Thread Daniel Vetter
On Thu, Aug 05, 2021 at 12:46:57PM +0200, Daniel Vetter wrote: > drm_sched_job_init is already at the right place, so this boils down > to deleting code. > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: Sean Paul > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-arm-...@vger.kernel