Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-07-28 Thread Sai Prakash Ranjan
Hi Georgi, On 2021-07-28 19:30, Georgi Djakov wrote: On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went the memory type setting required f

[Freedreno] [PATCH] drm/msm: remove a repeated including of

2021-07-28 Thread Guo Zhengkui
Remove a repeated "#include " in line 19 of the original file. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot.h b/drivers/gpu/drm/msm/disp/msm_disp_snapshot.h index c92a95

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Rob Clark
On Wed, Jul 28, 2021 at 7:18 PM Caleb Connolly wrote: > > > > On 29/07/2021 02:02, Rob Clark wrote: > > Jordan, any idea if more frequent frequency changes would for some > > reason make a630 grumpy? I was expecting it should be somewhat > > similar to a618 (same GMU fw, etc). The main result of

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Caleb Connolly
On 29/07/2021 02:02, Rob Clark wrote: Jordan, any idea if more frequent frequency changes would for some reason make a630 grumpy? I was expecting it should be somewhat similar to a618 (same GMU fw, etc). The main result of that patch should be clamping to min freq when gpu goes idle, and the

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Rob Clark
Jordan, any idea if more frequent frequency changes would for some reason make a630 grumpy? I was expecting it should be somewhat similar to a618 (same GMU fw, etc). The main result of that patch should be clamping to min freq when gpu goes idle, and the toggling back to devfreq provided freq on

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Caleb Connolly
Hi Rob, This series causes a fatal crash on my Oneplus 6, the device goes to Qualcomm crashdump mode shortly after reaching UI with the following errors: https://paste.ubuntu.com/p/HvjmzZYtgw/ I did a git bisect and the patch ("drm/msm: Devfreq tuning") seems to be the cause of the crash, re

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Sam, On 7/28/21 12:08 PM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > Just to be sure... Can you confirm that vbltest is working OK *before* this patch? >>> >>> Yes, can you please verify that

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Thomas, On 7/28/21 11:17 AM, Thomas Zimmermann wrote: > Hi > > Am 28.07.21 um 20:11 schrieb Sam Ravnborg: >> Hi Dan, >> >> thanks for the quick feedback! >> >> On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com >> wrote: >>> On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERN

[Freedreno] [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660

2021-07-28 Thread Konrad Dybcio
VDDA is not present and the specified load value is wrong. Fix it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 - drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 11:11 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > thanks for the quick feedback! > > On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 8:44 AM, Sam Ravnbo

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 8:44 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 7:00 AM, Sam Ravnborg wrote: >>> [You don't often get em

[Freedreno] [PATCH] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-07-28 Thread Kuogee Hsieh
Currently at dp_pm_resume() is_connected state is decided base on hpd connection status only. This will put is_connected in wrongly "true" state at the scenario that dongle attached to DUT but without hmdi cable connecting to it. Fix this problem by adding read sink count from dongle and decided is

[Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Rob Clark
Hi Dave & Daniel, An early pull for v5.15 (there'll be more coming in a week or two), consisting of the drm/scheduler conversion and a couple other small series that one was based one. Mostly sending this now because IIUC danvet wanted it in drm-next so he could rebase on it. (Daniel, if you dis

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > > > > I think I got it - we need to set irq_enabled to true. > > The documentation says so: > > " > > * @irq_enabled: > > * > > * Indicates that interrupt handling is enabled, specifically > > vblank > > * handling. Drivers which don't use drm_ir

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 7:00 AM, Sam Ravnborg wrote: > [You don't often get email from s...@ravnborg.org. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > I hope y

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > >> > >> Just to be sure... > >> Can you confirm that vbltest is working OK *before* this patch? > > > > Yes, can you please verify that it regressed. If so, this would mean > > that the driver misses vblank interrupts with the patch applied. > > Yes, unfortunately the vbltest works be

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Thomas Zimmermann
Hi Am 28.07.21 um 20:11 schrieb Sam Ravnborg: Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Re: [Freedreno] [PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

2021-07-28 Thread Thomas Zimmermann
Hi Sam Am 28.07.21 um 15:31 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:09PM +0200, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: > On 7/28/21 8:44 AM, Sam Ravnborg wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi Dan, > > > > On Wed, Jul 28,

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: > On 7/28/21 7:00 AM, Sam Ravnborg wrote: > > [You don't often get email from s...@ravnborg.org. Learn why this is > > important at http://aka.ms/LearnAboutSenderIdentification.] > > > > EXTERNAL EMAIL: Do not cli

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-07-28 Thread Georgi Djakov
On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > the memory type setting required for the non-coherent masters to use > system cache.

Re: [Freedreno] [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

2021-07-28 Thread Christian König
Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. The interrupt number retur

Re: [Freedreno] [PATCH 14/14] drm: IRQ midlayer is now legacy

2021-07-28 Thread Sam Ravnborg
Hi Thomas, On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote: > Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use > the prefix drm_legacy_, and move declarations to drm_legacy.h. > In struct drm_device, move the fields irq and irq_enabled behind > CONFIG_DRM_LEGACY

Re: [Freedreno] [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

2021-07-28 Thread Alex Deucher
On Wed, Jul 28, 2021 at 6:27 AM Christian König wrote: > > Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ ca

Re: [Freedreno] [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, I hope you can fine to test this patch from Thomas. If this works then we can forget about my attempt to do the same. Hi Thomas, IRQ_NOTCONNECTED check seems redundant, as mentioned in another patch already. With that considered: Reviewed-by: Sam Ravnborg We shall wait for testing fro

Re: [Freedreno] [PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Thomas, On Tue, Jul 27, 2021 at 08:27:09PM +0200, Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > DRM IRQ callbacks are now being called directly

[Freedreno] [PATCH v3 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-07-28 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 29

[Freedreno] [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-28 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This has dependency on the below GPUCC bindings patch which is already accepted in clk-next: https://patchwork.kernel.org/project/linux-clk/list/?series=514831&state=%2A&archive=both Changes in v3: - Re-order

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-28 Thread Akhil P Oommen
On 7/27/2021 5:46 AM, Stephen Boyd wrote: Quoting Akhil P Oommen (2021-07-24 10:29:00) Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch/16