Re: [Freedreno] [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-07-15 Thread abhinavk
Hi Marijn Sorry for the late response. On 2021-07-13 02:10, Marijn Suijten wrote: On 6/29/21 9:04 PM, Abhinav Kumar wrote: During board bringups its useful to have a DSI test pattern generator to isolate a DPU vs a DSI issue and focus on the relevant hardware block. To facilitate this, add an

Re: [Freedreno] [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-15 Thread maitreye
Hi Stephen, Thanks for reviewing my code. On 2021-07-08 18:27, Stephen Boyd wrote: Quoting maitreye (2021-07-08 12:13:44) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0

Re: [Freedreno] [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:16:52) > On 2021-07-08 00:21, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-07-06 10:20:20) > >> Main link symbol locked is achieved at end of link training 2. Some > >> dongle main link symbol may become unlocked again if host did not end > >> link

Re: [Freedreno] [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:46:41) > On 2021-07-08 00:33, Stephen Boyd wrote: > >> + > >> +static bool dp_ctrl_any_lane_cr_lose(struct dp_ctrl_private *ctrl, > >> + u8 *cr_status) > >> +{ > >> + int i; > >> + u8 status; > >> +

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: display: msm: dsi-controller-main: restore assigned-clocks

2021-07-15 Thread Rob Herring
On Sat, 10 Jul 2021 00:07:22 +0300, Dmitry Baryshkov wrote: > Restore the assgined-clocks and assigned-clock-parents properties that > were lost during the txt -> YAML conversion. > > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/dsi-controller-main.yaml| 17 + >

[Freedreno] [PATCH] drm/msm: mdp4: drop vblank get/put from prepare/complete_commit

2021-07-15 Thread David Heidelberg
msm_atomic is doing vblank get/put's already, currently there no need to duplicate the effort in MDP4 Fix warning: ... WARNING: CPU: 3 PID: 79 at drivers/gpu/drm/drm_vblank.c:1194 drm_vblank_put+0x1cc/0x1d4 ... and multiple vblank time-outs: ... msm 510.mdp: vblank time out, crtc=1 ... Teste