Re: [Freedreno] [PATCH 8/8] drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy

2021-06-21 Thread Dmitry Baryshkov
On Tue, 22 Jun 2021 at 01:44, wrote: > > On 2021-05-15 06:12, Dmitry Baryshkov wrote: > > Remove struct msm_dsi_dphy_timing field from the struct msm_dsi_phy. > > There is no need to store them. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

Re: [Freedreno] [PATCH 8/8] drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Remove struct msm_dsi_dphy_timing field from the struct msm_dsi_phy. There is no need to store them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 18 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h

Re: [Freedreno] [PATCH 7/8] drm/msm/dsi: drop msm_dsi_phy_get_shared_timings

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Instead of fetching shared timing through an extra function call, get them directly from msm_dsi_phy_enable. This would allow removing phy timings from the struct msm_dsi_phy in the next patch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Ku

Re: [Freedreno] [PATCH 6/8] drm/msm/dsi: phy: use of_device_get_match_data

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Use of_device_get_match-data() instead of of_match_node(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers

Re: [Freedreno] [PATCH 5/8] drm/msm/dsi: stop setting clock parents manually

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic place. Sig

Re: [Freedreno] [PATCH 4/8] arm64: dts: qcom: sm8250: assign DSI clock source parents

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Can you please confirm if you have validated dual DSI with this change? With that, Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++

Re: [Freedreno] [PATCH 3/8] arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.d

Re: [Freedreno] [PATCH 2/8] arm64: dts: qcom: sdm845: assign DSI clock source parents

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

Re: [Freedreno] [PATCH 1/8] arm64: dts: qcom: sc7180: assign DSI clock source parents

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/a

Re: [Freedreno] [PATCH 0/8] dsi: rework clock parents and timing handling

2021-06-21 Thread abhinavk
On 2021-05-15 06:12, Dmitry Baryshkov wrote: This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi rework patchset earlier. Few notes: - assign-clock-parents is a mandatory proprety according to the current dsi.txt d

Re: [Freedreno] [v7 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-21 Thread Sam Ravnborg
Hi Doug, On Mon, Jun 21, 2021 at 08:34:51AM -0700, Doug Anderson wrote: > Hi, > > On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote: > > > > Hi Rajeev > > On Sat, Jun 19, 2021 at 04:10:30PM +0530, Rajeev Nandan wrote: > > > Add Samsung 13.3" FHD eDP AMOLED panel. > > > > > > Signed-off-by: Raje

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-21 Thread Sam Ravnborg
Hi Rajeev, On Mon, Jun 21, 2021 at 02:08:17PM +0530, rajee...@codeaurora.org wrote: > Hi Sam, > > On 20-06-2021 15:01, Sam Ravnborg wrote: > > Hi Rajeev > > > > On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: > > > Some panels support backlight control over DP AUX channel using >

Re: [Freedreno] [v7 5/5] drm/panel-simple: Add Samsung ATNA33XC20

2021-06-21 Thread Doug Anderson
Hi, On Sun, Jun 20, 2021 at 3:01 AM Sam Ravnborg wrote: > > Hi Rajeev > On Sat, Jun 19, 2021 at 04:10:30PM +0530, Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > > > Signed-off-by: Rajeev Nandan > > Reviewed-by: Douglas Anderson > > --- > > > > Changes in v4: > > - New > >

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-21 Thread rajeevny
Hi Sam, On 20-06-2021 15:01, Sam Ravnborg wrote: Hi Rajeev On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and