Re: [Freedreno] [PATCH 0/6] drm/msm: Trim down drm debugging logs

2021-04-30 Thread abhinavk
On 2021-04-30 12:30, Stephen Boyd wrote: This patch series attempts to trim down the drm logging in the msm driver to make it useable with DRM_UT_DRIVER, DRM_UT_KMS, and DRM_UT_DP levels enabled. Right now the log is really spammy and prints multiple lines for what feels like every frame. I moved

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread Doug Anderson
Hi, On Fri, Apr 30, 2021 at 8:10 AM wrote: > > On 30-04-2021 02:33, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > >> > >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > >> > Add bindings for DisplayPort aux backlight driver. > >> > >

[Freedreno] [PATCH 4/6] drm/msm: Move FB debug prints to drm_dbg_state()

2021-04-30 Thread Stephen Boyd
These are verbose prints that tell us about the framebuffer state. Let's move them to drm_dbg_state() so that they're only printed if we're interested in verbose state logging while drm debugging. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul

[Freedreno] [PATCH 6/6] drm/msm/disp: Move various debug logs to atomic bucket

2021-04-30 Thread Stephen Boyd
These prints flood the logs with drm debugging set to enable kms and driver logging (DRM_UT_KMS and DRM_UT_DRIVER). Let's move these prints to the atomic bucket (DRM_UT_ATOMIC) as they're related to the atomic paths. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeauror

[Freedreno] [PATCH 5/6] drm/msm/disp: Use plane debug print helper

2021-04-30 Thread Stephen Boyd
Use the DPU_DEBUG_PLANE() helper to print the plane number instead of open coding it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++-- 1 file cha

[Freedreno] [PATCH 0/6] drm/msm: Trim down drm debugging logs

2021-04-30 Thread Stephen Boyd
This patch series attempts to trim down the drm logging in the msm driver to make it useable with DRM_UT_DRIVER, DRM_UT_KMS, and DRM_UT_DP levels enabled. Right now the log is really spammy and prints multiple lines for what feels like every frame. I moved those prints off to other DRM_UT_* levels

[Freedreno] [PATCH 2/6] drm/msm: Use VERB() for extra verbose logging

2021-04-30 Thread Stephen Boyd
These messages are useful for bringup/early development but in production they don't provide much value. We know what sort of GPU we have and interrupt information can be gathered other ways. This cuts down on lines in the drm debug logs that happen too often, making the debug logs practically usel

[Freedreno] [PATCH 3/6] drm/msm/dp: Drop malformed debug print

2021-04-30 Thread Stephen Boyd
This print is missing a newline, and doesn't really provide any value. Drop it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Freedreno] [PATCH 1/6] drm/msm: Move vblank debug prints to drm_dbg_vbl()

2021-04-30 Thread Stephen Boyd
Put these debug prints in the vblank code into the appropriate vblank category via drm_dbg_vbl(). Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- dri

Re: [Freedreno] [v3 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-30 Thread Lyude Paul
JFYI for anyone who is interested, I will be respinning my patches for adding backlight helpers very soon since we've got pretty much all of the prep work for it upstream now On Mon, 2021-04-26 at 12:49 +0300, Jani Nikula wrote: > On Mon, 26 Apr 2021, Rajeev Nandan wrote: > > Add backlight driver

Re: [Freedreno] [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread Stephen Boyd
Quoting Rob Clark (2021-04-30 10:17:39) > From: Rob Clark > > dpu_crtc_atomic_flush() was directly poking it's attached planes in a > code path that ended up in dpu_plane_atomic_update(), even if the plane > was not involved in the current atomic update. While a bit dubious, > this worked before

Re: [Freedreno] [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread John Stultz
On Fri, Apr 30, 2021 at 10:14 AM Rob Clark wrote: > > From: Rob Clark > > dpu_crtc_atomic_flush() was directly poking it's attached planes in a > code path that ended up in dpu_plane_atomic_update(), even if the plane > was not involved in the current atomic update. While a bit dubious, > this w

[Freedreno] [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread Rob Clark
From: Rob Clark dpu_crtc_atomic_flush() was directly poking it's attached planes in a code path that ended up in dpu_plane_atomic_update(), even if the plane was not involved in the current atomic update. While a bit dubious, this worked before because plane->state would always point to somethin

Re: [Freedreno] [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-04-30 Thread Rob Clark
On Thu, Apr 8, 2021 at 6:20 AM Maxime Ripard wrote: > > Hi Stephen, > > On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2021-03-30 08:35:27) > > > Hi Stephen, > > > > > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > > Trimming Cc list

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-30 Thread rajeevny
On 30-04-2021 02:33, Doug Anderson wrote: Hi, On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > Add bindings for DisplayPort aux backlight driver. > > Changes in v2: > - New > > Signed-off-by: Rajeev Nandan > --- > .../bindi