[Freedreno] [PATCH] drm/msm: fix LLC not being enabled for mmu500 targets

2021-04-23 Thread Jonathan Marek
mmu500 targets don't have a "cx_mem" region, set llc_mmio to NULL in that case to avoid the IS_ERR() condition in a6xx_llc_activate(). Fixes: 3d247123b5a1 ("drm/msm/a6xx: Add support for using system cache on MMU500 based targets") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6

Re: [Freedreno] [v2 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-23 Thread kernel test robot
Hi Rajeev, Thank you for the patch! Yet something to improve: [auto build test ERROR on lee-backlight/for-backlight-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.12-rc8 next-20210423] [cannot apply to drm/drm

[Freedreno] [v2 2/2] backlight: Add DisplayPort aux backlight driver

2021-04-23 Thread Rajeev Nandan
Add backlight driver for the panels supporting backlight control using DPCD registers on the DisplayPort aux channel. Changes in v2: - New (most of the code reused from drm_dp_aux_backlight.c of v1) Signed-off-by: Rajeev Nandan --- drivers/video/backlight/Kconfig| 7 + drivers/vid

[Freedreno] [v2 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-04-23 Thread Rajeev Nandan
Add bindings for DisplayPort aux backlight driver. Changes in v2: - New Signed-off-by: Rajeev Nandan --- .../bindings/leds/backlight/dp-aux-backlight.yaml | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/dp-aux-

[Freedreno] [v2 0/2] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

2021-04-23 Thread Rajeev Nandan
The backlight level of an eDP panel can be controlled through the AUX channel using DPCD registers of the panel. The capability for the Source device to adjust backlight characteristics within the panel, using the Sink device DPCD registers is indicated by the TCON_BACKLIGHT_ADJUSTMENT_CAPABLE bit

[Freedreno] [PATCH 5/5] drm/msm: deprecate MSM_BO_UNCACHED (map as writecombine instead)

2021-04-23 Thread Jonathan Marek
There shouldn't be any reason to ever use uncached over writecombine, so just use writecombine for MSM_BO_UNCACHED. Note: userspace never used MSM_BO_UNCACHED anyway Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_gem.c | 4 +--- include/uapi/drm/msm_drm.h| 2 +- 2 files changed,

[Freedreno] [PATCH 4/5] drm/msm: add MSM_BO_CACHED_COHERENT

2021-04-23 Thread Jonathan Marek
Add a new cache mode for creating coherent host-cached BOs. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/ms

[Freedreno] [PATCH 3/5] drm/msm: use the right pgprot when mapping BOs in the kernel

2021-04-23 Thread Jonathan Marek
Use the same logic as the userspace mapping. This fixes msm_rd with cached BOs. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_gem.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c

[Freedreno] [PATCH 2/5] drm/msm: replace MSM_BO_UNCACHED with MSM_BO_WC for internal objects

2021-04-23 Thread Jonathan Marek
msm_gem_get_vaddr() currently always maps as writecombine, so use the right flag instead of relying on broken behavior (things don't actually work if they are mapped as uncached). Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/a

[Freedreno] [PATCH 1/5] drm/msm: remove unnecessary mmap logic for cached BOs

2021-04-23 Thread Jonathan Marek
No one knows what this is for anymore, so just remove it. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_gem.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index b199942266a2..09abda4

[Freedreno] [PATCH 0/5] drm/msm: add MSM_BO_CACHED_COHERENT (and related changes)

2021-04-23 Thread Jonathan Marek
Add support for MSM_BO_CACHED_COHERENT, a coherent version of MSM_BO_CACHED which is implemented by setting the IOMMU_CACHE flag. Jonathan Marek (5): drm/msm: remove unnecessary mmap logic for cached BOs drm/msm: replace MSM_BO_UNCACHED with MSM_BO_WC for internal objects drm/msm: use the ri

[Freedreno] [PATCH] drm/msm: fix minor version to indicate MSM_PARAM_SUSPENDS support

2021-04-23 Thread Jonathan Marek
Increase the minor version to indicate that MSM_PARAM_SUSPENDS is supported. Fixes: 3ab1c5cc3939 ("drm/msm: Add param for userspace to query suspend count") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[Freedreno] [PATCH v4 06/17] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-04-23 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Freedreno] [PATCH v4 05/17] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-04-23 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3 ++-

[Freedreno] [PATCH v4 03/17] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-04-23 Thread Lyude Paul
This is something that we've wanted for a while now: the ability to actually look up the respective drm_device for a given drm_dp_aux struct. This will also allow us to transition over to using the drm_dbg_*() helpers for debug message printing, as we'll finally have a drm_device to reference for d

[Freedreno] [PATCH v2 2/2] dt-bindings: display: msm/dsi: add qcom, dsi-phy-cphy-mode option

2021-04-23 Thread Jonathan Marek
Document qcom,dsi-phy-cphy-mode option, which can be used to control whether DSI will operate in D-PHY (default) or C-PHY mode. Signed-off-by: Jonathan Marek --- Documentation/devicetree/bindings/display/msm/dsi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bin

[Freedreno] [PATCH v2 1/2] drm/msm/dsi: support CPHY mode for 7nm pll/phy

2021-04-23 Thread Jonathan Marek
Add the required changes to support 7nm pll/phy in CPHY mode. This adds a "qcom,dsi-phy-cphy-mode" property for the PHY node to enable the CPHY mode. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi.xml.h | 2 + drivers/gpu/drm/msm/dsi/dsi_host.c| 34 - drive

[Freedreno] [PATCH v2 0/2] drm/msm/dsi: support CPHY mode for 7nm pll/phy

2021-04-23 Thread Jonathan Marek
Add the required changes to support 7nm pll/phy in CPHY mode. This adds a "qcom,dsi-phy-cphy-mode" property for the PHY node to enable the CPHY mode. v2: - rebased on DSI PHY reworks - reworked getting cphy_mode in dsi_host.c - documentation change in separate patch Jonathan Marek (2): drm/

Re: [Freedreno] [PATCH] drm/msm/dsi: fix msm_dsi_phy_get_clk_provider return code

2021-04-23 Thread Jonathan Marek
Tested-by: Jonathan Marek On 4/11/21 8:01 PM, Dmitry Baryshkov wrote: msm_dsi_phy_get_clk_provider() always returns two provided clocks, so return 0 instead of returning incorrect -EINVAL error code. Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") Signed

Re: [Freedreno] i.MX53 error during GPU use

2021-04-23 Thread Rob Clark
On Fri, Apr 23, 2021 at 4:58 AM Otavio Salvador wrote: > > Hello all, > > We found this error when using Freedreno driver on an i.MX53 device > with Wayland. Any idea how to fix this? > > [ 32.414110] [drm:msm_ioctl_gem_submit] *ERROR* invalid cmdstream size: 0 The invalid cmdstream size is som

[Freedreno] i.MX53 error during GPU use

2021-04-23 Thread Otavio Salvador
Hello all, We found this error when using Freedreno driver on an i.MX53 device with Wayland. Any idea how to fix this? [ 32.414110] [drm:msm_ioctl_gem_submit] *ERROR* invalid cmdstream size: 0 [ 39.177075] [ 39.178617] == [ 39.184804] WA