Re: [Freedreno] [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

2021-04-16 Thread Doug Anderson
Hi, On Wed, Apr 14, 2021 at 9:41 AM Rajeev Nandan wrote: > > The backlight level of an eDP panel can be controlled through the AUX > channel using DPCD registers of the panel. > > The capability for the Source device to adjust backlight characteristics > within the panel, using the Sink device DP

[Freedreno] [PATCH v5 7/7] drm/msm: add disp snapshot points across dpu driver

2021-04-16 Thread Abhinav Kumar
Add snapshot points across dpu driver to trigger dumps when critical errors are hit. changes in v5: - change the callers to use the snapshot function directly Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16 +--- drivers/gpu/drm/msm/disp/d

[Freedreno] [PATCH v5 3/7] drm/msm/dsi: add API to take DSI register snapshot

2021-04-16 Thread Abhinav Kumar
Add an API to take a snapshot of DSI controller registers. This API will be used by the msm_disp_snapshot module to capture the DSI snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 4 drivers/gpu/drm/msm/dsi/dsi.h | 5 - drivers/gpu/drm/msm/dsi/dsi_

[Freedreno] [PATCH v5 2/7] drm/msm: add support to take dpu snapshot

2021-04-16 Thread Abhinav Kumar
Add the msm_disp_snapshot module which adds supports to dump dpu registers and capture the drm atomic state which can be used in case of error conditions. changes in v5: - start storing disp_state in msm_kms instead of dpu_kms - get rid of MSM_DISP_SNAPSHOT_IN_* enum by simplifying the functions

[Freedreno] [PATCH v5 0/7] Add devcoredump support for DPU

2021-04-16 Thread Abhinav Kumar
This series adds support to use devcoredump for DPU driver. It introduces the msm_disp_snapshot module which assists in the capturing of register dumps during error scenarios. When a display related error happens, the msm_disp_snapshot module captures all the relevant register dumps along with th

[Freedreno] [PATCH v5 6/7] drm/msm: add support to take dsi, dp and dpu snapshot

2021-04-16 Thread Abhinav Kumar
Add support to take the register snapshot of dsi, dp and dpu modules. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 1 + drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 16 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/dr

[Freedreno] [PATCH v5 5/7] drm/msm/disp/dpu1: add API to take DPU register snapshot

2021-04-16 Thread Abhinav Kumar
Add an API to take a snapshot of DPU controller registers. This API will be used by the msm_disp_snapshot module to capture the DPU snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 50 + drivers/gpu/drm/msm/msm_kms.h |

[Freedreno] [PATCH v5 4/7] drm/msm/dp: add API to take DP register snapshot

2021-04-16 Thread Abhinav Kumar
Add an API to take a snapshot of DP controller registers. This API will be used by the msm_disp_snapshot module to capture the DP snapshot. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_catalog.c | 9 + drivers/gpu/drm/msm/dp/dp_catalog.h | 4 drivers/gpu/drm/msm/dp/d

[Freedreno] [PATCH v5 1/7] drm: allow drm_atomic_print_state() to accept any drm_printer

2021-04-16 Thread Abhinav Kumar
Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm snapshot. Rename the drm_atomic_print_state() to drm_atomic_print_new_state() so that it reflects its functionality bett

[Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-16 Thread Kuogee Hsieh
Some dongle may generate more than one irq_hpd events in a short period of time. This patch will treat those irq_hpd events as single one and service only one irq_hpd event. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + 1 file changed, 9 insertions(+) diff -

[Freedreno] [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-16 Thread Kuogee Hsieh
Maybe when the cable is disconnected the DP phy should be shutdown and some bit in the phy could effectively "cut off" the aux channel and then NAKs would start coming through here in the DP controller I/O register space. This patch have DP aux channel read/write to return NAK immediately if DP con

[Freedreno] [PATCH v3 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-16 Thread Kuogee Hsieh
Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add dp_display_signal_audio_start() Changes in v3: -- restore dp_display_handle_plugged_change() at dp_hpd_unplu

[Freedreno] [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie C

[Freedreno] [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU!

2021-04-16 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (40): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Remove unused variable 'ret'